From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Carew, Alan" <alan.carew-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v2 09/10] igbuio: show irq mode in sysfs
Date: Wed, 11 Jun 2014 18:27:35 +0000
Message-ID: <0E29434AEE0C3A4180987AB476A6F630593A63AB@IRSMSX101.ger.corp.intel.com>
References: <20140606235028.189345212@networkplumber.org>
 <20140606235115.248804518@networkplumber.org>
 <20140608153704.GA27652@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>, Stephen Hemminger
 <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20140608153704.GA27652-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

> -----Original Message-----
> From: Neil Horman [mailto:nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org]
> Sent: Sunday, June 08, 2014 4:37 PM
> To: Stephen Hemminger
> Cc: Carew, Alan; dev-VfR2kkLFssw@public.gmane.org
> Subject: Re: [dpdk-dev] [PATCH v2 09/10] igbuio: show irq mode in sysfs
>=20
> On Fri, Jun 06, 2014 at 04:50:37PM -0700, Stephen Hemminger wrote:
> > Since irq mode is determined dynamically on a per-device
> > basis, and virtio needs to know if using intx or msi-x,
> > make it a sysfs attribute.
> >
> > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > @@ -43,6 +43,10 @@
> >  	IGBUIO_MSIX_INTR_MODE
> >  };
> >
> > +static const char *igbuio_intr_modes[] =3D {
> > +	"legacy", "msi", "msix"
> > +};
> > +
> >  /**
> >   * A structure describing the private information for a uio device.
> >   */
> > @@ -128,8 +132,20 @@
> >  }
> >
> >  static DEVICE_ATTR(max_vfs, S_IRUGO | S_IWUSR, show_max_vfs,
> store_max_vfs);
> > +
> > +static ssize_t irq_mode_show(struct device *dev,
> > +			     struct device_attribute *attr, char *buf)
> > +{
> > +	struct uio_info *info =3D pci_get_drvdata(to_pci_dev(dev));
> > +	struct rte_uio_pci_dev *udev =3D igbuio_get_uio_pci_dev(info);
> > +
> > +	return sprintf(buf, "%s\n", igbuio_intr_modes[udev->mode]);
> > +}
> > +static DEVICE_ATTR(irq_mode, S_IRUGO, irq_mode_show, NULL);
> > +
> >  static struct attribute *dev_attrs[] =3D {
> >  	&dev_attr_max_vfs.attr,
> > +	&dev_attr_irq_mode.attr,
> >  	NULL,
> >  };
> >
> >
> >
> Do you really need this attribute?  The pci bus sysfs tree already export=
s irq
> mode information for each device allocated already in
> /sys/bus/pci/device/msi_irqs<irq_number>
>=20
> Neil

Hi Neil,

After some digging around, I now realise what you mean, it is a good sugges=
tion.
/sys/bus/pci/devices/<D:B:D.F>/msi_irqs/<IRQ>/mode, where "msi_irqs" direct=
ory only exists for msi/msix and not for int-x. Also the "mode" file contai=
ns string of configured interrupt mode.

Thanks,
Alan