From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xu, Rosen" Subject: Re: [PATCH v3 1/6] Add Intel FPGA BUS Command Parse Code Date: Wed, 4 Apr 2018 01:58:59 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D739F33DCA@SHSMSX104.ccr.corp.intel.com> References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1522229396-17898-1-git-send-email-rosen.xu@intel.com> <1522229396-17898-2-git-send-email-rosen.xu@intel.com> <20180328132603.eqb62ydah2gpdlnz@bidouze.vm.6wind.com> <0E78D399C70DA940A335608C6ED296D739F26797@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: "'dev@dpdk.org'" , "Doherty, Declan" , "Richardson, Bruce" , "'shreyansh.jain@nxp.com'" , "Zhang, Tianfei" , "Wu, Hao" To: "'gaetan.rivet@6wind.com'" Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D65331BAC8 for ; Wed, 4 Apr 2018 03:59:02 +0200 (CEST) In-Reply-To: <0E78D399C70DA940A335608C6ED296D739F26797@SHSMSX104.ccr.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Gaetan, Are my answers ok? If so, could you reply it? Many thanks to you. > -----Original Message----- > From: Xu, Rosen > Sent: Sunday, April 01, 2018 0:26 > To: gaetan.rivet@6wind.com > Cc: dev@dpdk.org; Doherty, Declan ; > Richardson, Bruce ; shreyansh.jain@nxp.com; > Zhang, Tianfei ; Wu, Hao > Subject: RE: [PATCH v3 1/6] Add Intel FPGA BUS Command Parse Code >=20 >=20 >=20 > > -----Original Message----- > > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > > Sent: Wednesday, March 28, 2018 21:26 > > To: Xu, Rosen > > Cc: dev@dpdk.org; Doherty, Declan ; > > Richardson, Bruce ; > > shreyansh.jain@nxp.com; Zhang, Tianfei ; Wu, > > Hao > > Subject: Re: [PATCH v3 1/6] Add Intel FPGA BUS Command Parse Code > > > > On Wed, Mar 28, 2018 at 05:29:51PM +0800, Rosen Xu wrote: > > > Signed-off-by: Rosen Xu > > > --- > > > lib/librte_eal/common/eal_common_options.c | 8 +++++++- > > > lib/librte_eal/common/eal_options.h | 2 ++ > > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_eal/common/eal_common_options.c > > > b/lib/librte_eal/common/eal_common_options.c > > > index 9f2f8d2..4fe0875 100644 > > > --- a/lib/librte_eal/common/eal_common_options.c > > > +++ b/lib/librte_eal/common/eal_common_options.c > > > @@ -73,6 +73,7 @@ > > > {OPT_VDEV, 1, NULL, OPT_VDEV_NUM }, > > > {OPT_VFIO_INTR, 1, NULL, OPT_VFIO_INTR_NUM }, > > > {OPT_VMWARE_TSC_MAP, 0, NULL, > > OPT_VMWARE_TSC_MAP_NUM }, > > > + {OPT_IFPGA, 1, NULL, OPT_IFPGA_NUM }, > > > {0, 0, NULL, 0 } > > > }; > > > > > > @@ -1160,7 +1161,12 @@ static int xdigit2val(unsigned char c) > > > > > > core_parsed =3D LCORE_OPT_MAP; > > > break; > > > - > > > + case OPT_IFPGA_NUM: > > > + if (eal_option_device_add(RTE_DEVTYPE_VIRTUAL, > > > + optarg) < 0) { > > > + return -1; > > > + } > > > + break; > > > > why do you need to add a new option if you only insert a virtual devarg= s? > > > > Why wouldn't --vdev option work instead? and for that matter, I was > > expecting you to provide a PCI address. Can you give a command line > > showing how you create your device? The devtype is essentially ignored > > currently (at option stage, maybe there are still cruft left in PCI > > bus), instead the devargs parsing will detect the bus from the given op= targ. > > > > This part of EAL will change rather soon, I'd prefer not to deal with > > additional options unless necessary. >=20 > For PATCH v4, I have removed all the modification from eal library. > Create vdev to take IFPGA parameters configuration. >=20 > The command line for PATCH v4 is(just take 2 AFU for example): > testpmd -c 0x3 -n 4 --socket-mem 1024,0 --huge-dir=3D/mnt/huge \ --vdev > 'net_ifpga_cfg0,bdf=3D5e:00.0,port=3D0,afu_bts=3D./xxx.gbs' \ --vdev > 'net_ifpga_cfg1,bdf=3Dbe:00.0,port=3D0,afu_bts=3D./xxx.gbs' -- -i --no-n= uma > Note: the parameter of "port" is used by OPAE for download bitstream. >=20 > > > /* don't know what to do, leave this to caller */ > > > default: > > > return 1; > > > diff --git a/lib/librte_eal/common/eal_options.h > > > b/lib/librte_eal/common/eal_options.h > > > index e86c711..bdbb2c4 100644 > > > --- a/lib/librte_eal/common/eal_options.h > > > +++ b/lib/librte_eal/common/eal_options.h > > > @@ -55,6 +55,8 @@ enum { > > > OPT_VFIO_INTR_NUM, > > > #define OPT_VMWARE_TSC_MAP "vmware-tsc-map" > > > OPT_VMWARE_TSC_MAP_NUM, > > > +#define OPT_IFPGA "ifpga" > > > + OPT_IFPGA_NUM, > > > OPT_LONG_MAX_NUM > > > }; > > > > > > -- > > > 1.8.3.1 > > > > > > > -- > > Ga=EBtan Rivet > > 6WIND