From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Xu, Rosen" <rosen.xu@intel.com>
Subject: Re: [PATCH v3 2/6] config/common_base: Add Intel FPGA
 Build Configuration Macro
Date: Wed, 4 Apr 2018 02:01:14 +0000
Message-ID: <0E78D399C70DA940A335608C6ED296D739F33DF1@SHSMSX104.ccr.corp.intel.com>
References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com>
 <1522229396-17898-1-git-send-email-rosen.xu@intel.com>
 <1522229396-17898-3-git-send-email-rosen.xu@intel.com>
 <20180328132726.ixwzcwaejetjyltw@bidouze.vm.6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Doherty, Declan"
 <declan.doherty@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "Zhang, Tianfei"
 <tianfei.zhang@intel.com>, "Wu, Hao" <hao.wu@intel.com>
To: "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id AD38C1B8DE
 for <dev@dpdk.org>; Wed,  4 Apr 2018 04:01:18 +0200 (CEST)
In-Reply-To: <20180328132726.ixwzcwaejetjyltw@bidouze.vm.6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Gaetan,

I have squash this patch with their relevant counterparts.
For PATCH v4 and later version CONFIG_RTE_LIBRTE_IFPGA_BUS is squashed with=
 ifpga_bus driver,
And CONFIG_RTE_LIBRTE_IFPGA_RAWDEV is squashed with ifpga_rawdev driver.
Is it ok?

> -----Original Message-----
> From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Wednesday, March 28, 2018 21:27
> To: Xu, Rosen <rosen.xu@intel.com>
> Cc: dev@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; shreyansh.jain@nxp.com;
> Zhang, Tianfei <tianfei.zhang@intel.com>; Wu, Hao <hao.wu@intel.com>
> Subject: Re: [PATCH v3 2/6] config/common_base: Add Intel FPGA Build
> Configuration Macro
>=20
> On Wed, Mar 28, 2018 at 05:29:52PM +0800, Rosen Xu wrote:
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > ---
> >  config/common_base | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/config/common_base b/config/common_base index
> > ad03cf4..08b7cce 100644
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -134,6 +134,12 @@ CONFIG_RTE_LIBRTE_PCI_BUS=3Dy
> > CONFIG_RTE_LIBRTE_VDEV_BUS=3Dy
> >
> >  #
> > +# Compile the Intel FPGA bus
> > +#
> > +CONFIG_RTE_LIBRTE_IFPGA_BUS=3Dy
> > +CONFIG_RTE_LIBRTE_IFPGA_RAWDEV=3Dy
> > +
> > +#
>=20
> Please squash this patch with their relevant counterparts.
> As it is, this won't trigger an error but the patch is meaningless.
>=20
> >  # Compile ARK PMD
> >  #
> >  CONFIG_RTE_LIBRTE_ARK_PMD=3Dy
> > --
> > 1.8.3.1
> >
>=20
> --
> Ga=EBtan Rivet
> 6WIND