From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Xu, Rosen" Subject: Re: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga Date: Wed, 2 Jan 2019 06:52:52 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A478CAA@SHSMSX104.ccr.corp.intel.com> References: <1545161721-382282-1-git-send-email-andy.pei@intel.com> <1545746524-116580-1-git-send-email-andy.pei@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Zhang, Tianfei" , "Yigit, Ferruh" To: "Pei, Andy" , "dev@dpdk.org" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 267B71B14C for ; Wed, 2 Jan 2019 07:52:56 +0100 (CET) In-Reply-To: <1545746524-116580-1-git-send-email-andy.pei@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, December 25, 2018 22:02 > To: dev@dpdk.org > Cc: Xu, Rosen ; Zhang, Tianfei > ; Pei, Andy > Subject: [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifp= ga >=20 > When ifpga_rawdev_create() allocate memory for a new rawdev, the original > code allocate redundant memory for adapter, which is a member of the > rawdev. > What is actually necessary is the adapter to be initialized, not memory > allocated. >=20 > What is different in v3 from v2 is that the adapter is no longer need to = be > freed. >=20 > fixes:ef1e8ede3da5 > cc: rosen.xu@intel.com > cc: tianfei.zhang@intel.com Acked-by: Rosen Xu