From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43295)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1bzmMV-0006LZ-1U
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:13:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1bzmMQ-0000Nu-3H
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:12:59 -0400
Received: from mail-yb0-x241.google.com ([2607:f8b0:4002:c09::241]:36454)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <programmingkidx@gmail.com>)
	id 1bzmMP-0000N8-VB
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 11:12:54 -0400
Received: by mail-yb0-x241.google.com with SMTP id d128so824992ybh.3
	for <qemu-devel@nongnu.org>; Thu, 27 Oct 2016 08:12:53 -0700 (PDT)
In-Reply-To: <1477580867.9075.24.camel@redhat.com>
References: <mailman.13406.1477569887.22738.qemu-devel@nongnu.org>
	<4B74416B-EEBE-408F-B589-41318045938D@gmail.com>
	<1477580867.9075.24.camel@redhat.com>
Mime-Version: 1.0 (Apple Message framework v753.1)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <0EB98440-B592-47F4-9F62-3956C2DE7F8F@gmail.com>
Content-Transfer-Encoding: 7bit
From: G 3 <programmingkidx@gmail.com>
Date: Thu, 27 Oct 2016 11:12:44 -0400
Subject: Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel qemu-devel <qemu-devel@nongnu.org>, Samuel Thibault <samuel.thibault@ens-lyon.org>


On Oct 27, 2016, at 11:07 AM, Gerd Hoffmann wrote:

>>> +# needed to make gcc accept wide unicode chars without warning
>>> +curses.o-cflags := -std=gnu99
>
>> Could we add a commit message to this patch? It could answer
>> questions like:
>>
>> Why this patch is needed?
>> Who needs this patch?
>> What problem it solves.
>
> The comment added by the patch explains things.
>
> I could cut+paste that into the commit msg, but given how small the
> patch is it looked pointless to me ...
>
> cheers,
>   Gerd

A commit message should go with every patch. It makes it easier for  
someone looking thru the commit history to understand your patch.

This might be good enough:

Makes gcc accept wide unicode characters without producing a warning  
during compilation.