From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1pAao1-0005XY-2D for mharc-grub-devel@gnu.org; Wed, 28 Dec 2022 13:05:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAanz-0005VN-8r for grub-devel@gnu.org; Wed, 28 Dec 2022 13:05:31 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAanv-0005Qw-3k for grub-devel@gnu.org; Wed, 28 Dec 2022 13:05:30 -0500 Date: Wed, 28 Dec 2022 18:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fomin.one; s=protonmail2; t=1672250723; x=1672509923; bh=suYetbExNUWpecQUaf6V9c28evDJwyBsZFJ996P0BhE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=iN3u+2PklZD278ccL3iI3L+Q/nNpm/o8LAgHwN6+ouN0Ojvwhoeo+ANsSh9AHnIvk Da/fNbXIe29TmAedRoozFeMDQvxgvXtD5JhQSn3JlhCcaevqr4oCYTYd06RMxF639F PJPLbid4KkZyL4nWGF11k1iRRCtSpaP0EIO9NtUYIMSQ0exMgW9YmjcNONh6YNJZxc H2R86UtS5t9FOBJUO6uIaKvuBDKSZMfngDNaXvuaIhLmFO+t9poJr4Bb4kVeLs7Us4 tv1TULBooZ3zhiEs8poXGC23nGFedIwJgMCQBVmjudOr5xruRpWXVVpgOBpPkQOGo4 Z7zpE89sESWug== To: "grub-devel@gnu.org" From: Maxim Fomin Cc: development@efficientek.com, "dkiper@net-space.pl" Subject: Re: [PATCH v8 1/1] plainmount: Support plain encryption mode Message-ID: <0Qcs75cDPyZfsiuxG6njat8bl8S2RLSEPOyQNBGr3vGUBziWT8GCHRUMp9nrKqqR2J9ThXBQys_UQ21Zkm61j2RNO1fDJp_LttHDm2eqjfI=@fomin.one> In-Reply-To: <20221223200933.3deeaf81@crass-HP-ZBook-15-G2> References: <20221201150046.093d61f4@crass-HP-ZBook-15-G2> <3fIZJQVSGi0Q_eyZ7CvJppLpelCcx9lgm1OeHzGjU2Va9mdeCH-J9TXdebbdgE7PN4s_qDesWKgbXHItgrnT6_HlhUvRt_wYtYEDgnmvjsY=@fomin.one> <20221223195447.2c340af9@crass-HP-ZBook-15-G2> <20221223200933.3deeaf81@crass-HP-ZBook-15-G2> Feedback-ID: 10594471:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.43.23; envelope-from=maxim@fomin.one; helo=mail-4323.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Dec 2022 18:05:32 -0000 ------- Original Message ------- On Saturday, December 24th, 2022 at 2:09 AM, Glenn Washburn wrote: >=20 > On Fri, 23 Dec 2022 19:54:47 -0600 > Glenn Washburn development@efficientek.com wrote: >=20 > > On Fri, 02 Dec 2022 17:11:23 +0000 > > Maxim Fomin maxim@fomin.one wrote: > >=20 > > > ------- Original Message ------- > > > On Friday, December 2nd, 2022 at 0:00, Glenn Washburn > > > development@efficientek.com wrote: > > >=20 > > > > I'm now compiling this patch and found a few compile issues below. > > > > You're compile testing this right? > > >=20 > > > First versions of the patch were tested in pure grub src directory. > > > Later I switched to directly making and installing GRUB package for > > > my distro using its source script syntax. It seems this process was > > > affected by environment options which hided these errors/warnings. > > >=20 > > > I test the patch on my two old laptops - one with UEFI BIOS > > > (x86_64-efi) and one is pre-UEFI (i386-pc). I was compiling i386-pc > > > target too, because otherwise the second laptop was unbootable. > > > During i386-pc compilation I noticed some warnings related to > > > 'PRIuGRUB_XXX' macros which were absent during efi target > > > compilation. I noticed that there are similar warnings in other > > > modules and decided that there are issues with 'PRIuGRUB_XXX' macros > > > at i386-pc platform at global level. In any case, these issues > > > didn't cause compilation fail in my working environment because I > > > would not be able to compile and boot pre-UEFI lap. Do you use > > > -Werror? > >=20 > > I didn't see this until just now. In case you're still interested, no > > I don't use -Werror or any special compiler flags. And I'm using gcc > > version 10.2.1 from a Debian 11 container. >=20 >=20 > Correction, -Werror is being used. Perhaps that's a default compiler > flag on Debian systems. >=20 > Glenn >=20 This explains why you have found these issues. However, it does not explain how you can compile grub with -Werror because currently there are following warnings in x86_64-efi mode: grub-core/lib/libgcrypt-grub/mpi/mpi-internal.h:150:24: warning: variable = =E2=80=98_ql=E2=80=99 set but not used [-Wunused-but-set-variable] grub-core/lib/libgcrypt-grub/mpi/mpih-div.c:53:9: warning: variable = =E2=80=98dummy=E2=80=99 set but not used [-Wunused-but-set-variable] When I was working with the patch earlier this year I remember having these and several more warnings which prevented me from using -Werror. Back then I have removed the switch and have forgotten about this issue completely. Best regards, Maxim Fomin