From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 729CAC00140 for ; Wed, 24 Aug 2022 15:01:43 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.392820.631409 (Exim 4.92) (envelope-from ) id 1oQrsq-0000Ag-A5; Wed, 24 Aug 2022 15:01:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 392820.631409; Wed, 24 Aug 2022 15:01:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oQrsq-0000AZ-6f; Wed, 24 Aug 2022 15:01:32 +0000 Received: by outflank-mailman (input) for mailman id 392820; Wed, 24 Aug 2022 15:01:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oQrso-0000A0-4w for xen-devel@lists.xenproject.org; Wed, 24 Aug 2022 15:01:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oQrsn-0006rw-Ui; Wed, 24 Aug 2022 15:01:29 +0000 Received: from [54.239.6.185] (helo=[192.168.29.89]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oQrsn-0000FB-OA; Wed, 24 Aug 2022 15:01:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=85vYf+BEEqubasSHdQXzaUUUYVxS/rgG4MhODPLo7JU=; b=upafYz2dUuXf6DANDA3tgOaaCv YyIRelYHrcNSt6DzXqvaI1oUC9dg7QIz+qeAe/nN2JeTx4aKoUja2tX14MGQbEz9Wcllu3mkqYxCr WvyVPnU0D0dwEM1Tu0Tfj6S0mcIQhfnowjJUkMlmHJP1oqL5OERrPhe1YXMRpbWxc0fQ=; Message-ID: <0a057b2d-a9e9-af47-a48d-511b31208ccc@xen.org> Date: Wed, 24 Aug 2022 16:01:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 04/10] xen/arm: smmuv3: Move definitions to a header Content-Language: en-US To: Rahul Singh , xen-devel@lists.xenproject.org Cc: Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 24/08/2022 14:53, Rahul Singh wrote: > Allow sharing structure definitions with the upcoming virtual > smmuv3 support for Arm SMMUv3, by moving them to a separate header. I haven't seen this feature posted yet. So I can't tell how this will allow sharing. I guess you will introduce a new file? In any case, I would suggest to either delay this patch until you send your work or find a different reason to split it (I can't think of one yet). Cheers, -- Julien Grall