All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>,
	Pingfan Liu <kernelfans@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	Ira Weiny <ira.weiny@intel.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
	Keith Busch <keith.busch@intel.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()
Date: Tue, 11 Jun 2019 12:49:44 -0700	[thread overview]
Message-ID: <0a05a49f-ac93-1d07-d222-0ec928e61568@nvidia.com> (raw)
In-Reply-To: <20190611135212.GA4591@infradead.org>

On 6/11/19 6:52 AM, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 08:29:35PM +0800, Pingfan Liu wrote:
>> Unable to get a NVME device to have a test. And when testing fio on the
> 
> How would a nvme test help?  FOLL_LONGTERM isn't used by any performance
> critical path to start with, so I don't see how this patch could be
> a problem.
> 

yes, you're right of course. We skip the loop entirely for FOLL_LONGTERM,
and I forgot for the moment that the direct IO paths are never going to
set that flag. :)

thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2019-06-11 19:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05  9:10 [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast() Pingfan Liu
2019-06-05  9:10 ` [PATCHv3 2/2] mm/gup: rename nr as nr_pinned " Pingfan Liu
2019-06-05 21:49 ` [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM " Andrew Morton
2019-06-06  2:19   ` Pingfan Liu
2019-06-06  2:19     ` Pingfan Liu
2019-06-06 21:17     ` John Hubbard
2019-06-07  6:10       ` Pingfan Liu
2019-06-07  6:10         ` Pingfan Liu
2019-06-11 12:29         ` Pingfan Liu
2019-06-11 13:52           ` Christoph Hellwig
2019-06-11 19:49             ` John Hubbard [this message]
2019-06-11 16:47           ` Ira Weiny
2019-06-12 14:10             ` Pingfan Liu
2019-06-12 14:10               ` Pingfan Liu
2019-06-11 16:15 ` Aneesh Kumar K.V
2019-06-11 16:29   ` Weiny, Ira
2019-06-12 13:54     ` Pingfan Liu
2019-06-12 23:50       ` Ira Weiny
2019-06-13 10:48         ` Pingfan Liu
2019-06-13 10:48           ` Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a05a49f-ac93-1d07-d222-0ec928e61568@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=hch@infradead.org \
    --cc=ira.weiny@intel.com \
    --cc=keith.busch@intel.com \
    --cc=kernelfans@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rppt@linux.ibm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.