From: Stefan Schmidt <stefan@datenfreihafen.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
h.morris@cascoda.com, alex.aring@gmail.com, davem@davemloft.net,
kuba@kernel.org
Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ieee802154: Remove redundant 'flush_workqueue()' calls
Date: Sat, 16 Oct 2021 22:54:52 +0200 [thread overview]
Message-ID: <0a080522-a30b-8b78-86d2-66c1c1a5f604@datenfreihafen.org> (raw)
In-Reply-To: <fedb57c4f6d4373e0d6888d13ad2de3a1d315d81.1634235880.git.christophe.jaillet@wanadoo.fr>
Hello Dave, Jakub.
I have nothing else in my ieee802154 tree for net right now so it would
be great if you could take it directly. If that poses a problem, let me
know and I will get it in through my tree.
On 14.10.21 20:26, Christophe JAILLET wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
>
> Remove the redundant 'flush_workqueue()' calls.
>
> This was generated with coccinelle:
>
> @@
> expression E;
> @@
> - flush_workqueue(E);
> destroy_workqueue(E);
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ieee802154/ca8210.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
> index 3a2824f24caa..ece6ff6049f6 100644
> --- a/drivers/net/ieee802154/ca8210.c
> +++ b/drivers/net/ieee802154/ca8210.c
> @@ -2938,9 +2938,7 @@ static int ca8210_dev_com_init(struct ca8210_priv *priv)
> */
> static void ca8210_dev_com_clear(struct ca8210_priv *priv)
> {
> - flush_workqueue(priv->mlme_workqueue);
> destroy_workqueue(priv->mlme_workqueue);
> - flush_workqueue(priv->irq_workqueue);
> destroy_workqueue(priv->irq_workqueue);
> }
>
>
Thanks Christophe for spotting and fixing this.
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
regards
Stefan Schmidt
next prev parent reply other threads:[~2021-10-16 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 18:26 [PATCH] ieee802154: Remove redundant 'flush_workqueue()' calls Christophe JAILLET
2021-10-16 20:54 ` Stefan Schmidt [this message]
2021-10-18 21:14 ` Jakub Kicinski
2021-10-19 7:18 ` Stefan Schmidt
2021-10-19 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a080522-a30b-8b78-86d2-66c1c1a5f604@datenfreihafen.org \
--to=stefan@datenfreihafen.org \
--cc=alex.aring@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=h.morris@cascoda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.