All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel@pengutronix.de>
Subject: Re: [PATCH] mux: mux-gpio: fix compatible according to binding documentation
Date: Thu, 13 Apr 2017 18:14:35 +0200	[thread overview]
Message-ID: <0a15d738-1f12-2b89-78a7-dd151a4e2f15@axentia.se> (raw)
In-Reply-To: <5035ac59-c2ad-f1d8-b81c-2bdbc1b7581e@axentia.se>

On 2017-04-13 18:10, Peter Rosin wrote:
> On 2017-04-13 16:24, Philipp Zabel wrote:
>> According to the device tree binding documentation, the compatible
>> should be "gpio-mux", not "mux-gpio".
>>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> ---
>>  drivers/mux/mux-gpio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
>> index b304845c4812b..227d3572e6dbf 100644
>> --- a/drivers/mux/mux-gpio.c
>> +++ b/drivers/mux/mux-gpio.c
>> @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>>  };
>>  
>>  static const struct of_device_id mux_gpio_dt_ids[] = {
>> -	{ .compatible = "mux-gpio", },
>> +	{ .compatible = "gpio-mux", },
>>  	{ /* sentinel */ }
>>  };
>>  MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
>>
> 
> Oh, crap, right you are. However, the mux patch series is not frozen yet,
> and I think Greg KH will want this fixed before they are. So, I guess I'll
> send a v11 of the mux series (shortly) instead of having this extra patch.

Should be v13 of course....

> Cheers,
> peda
> 

  reply	other threads:[~2017-04-13 16:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 14:24 [PATCH] mux: mux-gpio: fix compatible according to binding documentation Philipp Zabel
2017-04-13 16:10 ` Peter Rosin
2017-04-13 16:14   ` Peter Rosin [this message]
2017-04-18  8:21   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a15d738-1f12-2b89-78a7-dd151a4e2f15@axentia.se \
    --to=peda@axentia.se \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.