From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 836EDC5519F for ; Wed, 18 Nov 2020 23:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22C86246BC for ; Wed, 18 Nov 2020 23:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727353AbgKRXzh (ORCPT ); Wed, 18 Nov 2020 18:55:37 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2375 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbgKRXzg (ORCPT ); Wed, 18 Nov 2020 18:55:36 -0500 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Cc06p14fXz520J; Thu, 19 Nov 2020 07:55:14 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 19 Nov 2020 07:55:33 +0800 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 19 Nov 2020 07:55:33 +0800 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.1913.007; Thu, 19 Nov 2020 07:55:33 +0800 From: "Song Bao Hua (Barry Song)" To: Ard Biesheuvel CC: Will Deacon , Mike Rapoport , "anshuman.khandual@arm.com" , "catalin.marinas@arm.com" , Linuxarm , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] arm64: mm: add support for memmap kernel parameters Thread-Topic: [PATCH] arm64: mm: add support for memmap kernel parameters Thread-Index: AQHWvXVLtrpWHgsWH0upIuwmJUX89KnNolcAgAAa/ICAAJI6cP//pm8AgACWN3A= Date: Wed, 18 Nov 2020 23:55:33 +0000 Message-ID: <0a1de2555ed2458d97e5c79929f74380@hisilicon.com> References: <20201118063314.22940-1-song.bao.hua@hisilicon.com> <20201118173854.GA8537@kernel.org> <20201118191528.GA2680@willie-the-truck> <1d3780422d2648dfa80a6de87585819a@hisilicon.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.201.226] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQXJkIEJpZXNoZXV2ZWwg W21haWx0bzphcmRiQGtlcm5lbC5vcmddDQo+IFNlbnQ6IFRodXJzZGF5LCBOb3ZlbWJlciAxOSwg MjAyMCAxMTozOCBBTQ0KPiBUbzogU29uZyBCYW8gSHVhIChCYXJyeSBTb25nKSA8c29uZy5iYW8u aHVhQGhpc2lsaWNvbi5jb20+DQo+IENjOiBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPjsg TWlrZSBSYXBvcG9ydCA8cnBwdEBrZXJuZWwub3JnPjsNCj4gYW5zaHVtYW4ua2hhbmR1YWxAYXJt LmNvbTsgY2F0YWxpbi5tYXJpbmFzQGFybS5jb207IExpbnV4YXJtDQo+IDxsaW51eGFybUBodWF3 ZWkuY29tPjsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsNCj4gYWtwbUBsaW51eC1mb3Vu ZGF0aW9uLm9yZzsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnDQo+IFN1Ympl Y3Q6IFJlOiBbUEFUQ0hdIGFybTY0OiBtbTogYWRkIHN1cHBvcnQgZm9yIG1lbW1hcCBrZXJuZWwg cGFyYW1ldGVycw0KPiANCj4gT24gV2VkLCAxOCBOb3YgMjAyMCBhdCAyMToyNywgU29uZyBCYW8g SHVhIChCYXJyeSBTb25nKQ0KPiA8c29uZy5iYW8uaHVhQGhpc2lsaWNvbi5jb20+IHdyb3RlOg0K PiA+DQo+ID4NCj4gPg0KPiA+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZy b206IFdpbGwgRGVhY29uIFttYWlsdG86d2lsbEBrZXJuZWwub3JnXQ0KPiA+ID4gU2VudDogVGh1 cnNkYXksIE5vdmVtYmVyIDE5LCAyMDIwIDg6MTUgQU0NCj4gPiA+IFRvOiBNaWtlIFJhcG9wb3J0 IDxycHB0QGtlcm5lbC5vcmc+DQo+ID4gPiBDYzogU29uZyBCYW8gSHVhIChCYXJyeSBTb25nKSA8 c29uZy5iYW8uaHVhQGhpc2lsaWNvbi5jb20+Ow0KPiA+ID4gY2F0YWxpbi5tYXJpbmFzQGFybS5j b207IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gPiA+IGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGFrcG1AbGludXgtZm91bmRhdGlvbi5vcmc7DQo+ID4gPiBh bnNodW1hbi5raGFuZHVhbEBhcm0uY29tOyBMaW51eGFybSA8bGludXhhcm1AaHVhd2VpLmNvbT4N Cj4gPiA+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGFybTY0OiBtbTogYWRkIHN1cHBvcnQgZm9yIG1l bW1hcCBrZXJuZWwNCj4gcGFyYW1ldGVycw0KPiA+ID4NCj4gPiA+IE9uIFdlZCwgTm92IDE4LCAy MDIwIGF0IDA3OjM4OjU0UE0gKzAyMDAsIE1pa2UgUmFwb3BvcnQgd3JvdGU6DQo+ID4gPiA+IE9u IFdlZCwgTm92IDE4LCAyMDIwIGF0IDA3OjMzOjE0UE0gKzEzMDAsIEJhcnJ5IFNvbmcgd3JvdGU6 DQo+ID4gPiA+ID4gbWVtbWFwIHNob3VsZCBiZSBhbiB1c2VmdWwga2VybmVsIHBhcmFtZXRlciB3 aGljaCBoYXMgYmVlbg0KPiBzdXBwb3J0ZWQNCj4gPiA+IGJ5DQo+ID4gPiA+ID4geDg2LCBtaXBz IGFuZCB4dGVuc2EuDQo+ID4gPiA+DQo+ID4gPiA+IFdoeSBpcyB0aGlzIHBhcmFtZXRlciBzaG91 bGQgYmUgdXNlZnVsIGZvciBBUk02ND8NCj4gPiA+ID4gTXkgdW5kZXJzdGFuZGluZyBpcyB0aGF0 IGl0IGlzIHJlcXVpcmVkIG9ubHkgdG8gd29yayBhcm91bmQgcmVhbGx5DQo+ID4gPiA+IGJyb2tl biBib290bG9hZGVycywgaXNuJ3QgaXQ/DQo+ID4gPg0KPiA+DQo+ID4gR29vZCBxdWVzdGlvbi4g T3JpZ2luYWxseSBJIHdyb3RlIHRoaXMgcGF0Y2ggdG8gZGVidWcgYW5kIHZlcmlmeSB0aGUNCj4g dm1lbW1hcA0KPiA+IGxlYWsgaXNzdWUgcmVwb3J0ZWQgaW4gdGhpcyBwYXRjaDoNCj4gPiBbUEFU Q0ggdjJdIGFybTY0OiBtbTogZnJlZSB1bnVzZWQgbWVtbWFwIGZvciBzcGFyc2UgbWVtb3J5IG1v ZGVsIHRoYXQNCj4gZGVmaW5lIFZNRU1NQVANCj4gPg0KPiBodHRwczovL2xvcmUua2VybmVsLm9y Zy9saW51eC1hcm0ta2VybmVsLzIwMjAwODEyMDEwNjU1Ljk2MzM5LTEtbGl3ZWkyMTNADQo+IGh1 YXdlaS5jb20vDQo+ID4gSSBkb24ndCBoYXZlIGEgbWFjaGluZSB3aGljaCByZWFsbHkgaGFzIGhv bGVzIGluIG1lbW9yeV9zZWN0aW9uIHRvIGRlYnVnLA0KPiBidXQgbWVtbWFwDQo+ID4gY2FuIGhl bHAuIFdpdGggbWVtbWFwLCBJIGNvdWxkIHNwZWNpZmllZCBhIG1hY2hpbmUgd2l0aCB2YXJpb3Vz IGhvbGRzIGluDQo+IG1lbV9zZWN0aW9ucy4NCj4gPg0KPiA+IEFmdGVyIHRoYXQsIEkgZmlndXJl ZCBvdXQgdGhpcyBpcyBub3Qgb25seSB1c2VmdWwgZm9yIGRlYnVnZ2luZyBwdXJwb3NlLiBpdCBj YW4NCj4gaGF2ZSBzb21lIHJlYWwgdXNlciBjYXNlcy4NCj4gPiBGb3IgZXhhbXBsZToNCj4gPg0K PiA+IDEuIERBWCBvbiBEUkFNLg0KPiA+IGtlcm5lbCBwYXJhbWV0ZXIgbWVtbWFwPVhHIVlHIHNw ZWNpZmllcyBhIHJhbmdlIG9mIFJBTSB0byBlbXVsYXRlDQo+IHBtZW0uIFRoZW4gd2UgYXJlIGFi bGUNCj4gPiB0byBydW4gREFYIGFuZCBmaWxlc3lzdGVtIG9uIHRvcCBvZiBpdC4gRnVydGhlcm1v cmUsIHRoaXMgd2lsbCBwcm9iYWJseSBhbHNvDQo+IGJlbmVmaXQgdGhlIGNhc2UNCj4gPiB0aGlz IGJpZyBwYXRjaHNldCB3YW50cyB0byAiZml4IiB2aWEgZGlyZWN0IGFjY2VzcyB0byBtZW1vcnk6 DQo+ID4NCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC9jb3Zlci4xNjAyMDkzNzYwLmdp dC55dWxlaXh6aGFuZ0B0ZW5jZW50LmNvbS9UDQo+IC8jbTFhNzcwNzRiOGUxZGFkYzU5MGE1ZjQ1 YTUyZDljM2NkYTY5YzA3ODANCj4gPiBhcyB0aGUgY29tbWVudHMgaGF2ZSBjbGVhcmx5IHNob3du Lg0KPiA+DQo+ID4gMi4gcmVzZXJ2ZSBzb21lIG1lbW9yeSBmb3IgdXNlcnNwYWNlIHRvIG1hbmFn ZSB2aWEgL2Rldi9tZW0NCj4gPg0KPiANCj4gQXBvbG9naWVzIGZvciB0aGUgYmx1bnRuZXNzLCBi dXQgd2hhdCB5b3UgYXJlIHNheWluZyBoZXJlIGlzIHRoYXQgeW91DQo+IG5lZWQgYSBoYWNrIHRv IHBpbGUgdGhvc2Ugb3RoZXIgaGFja3Mgb250by4NCj4gDQo+IEN1cnJlbnRseSwgd2UgdXNlIHRo ZSBOT01BUCBhdHRyaWJ1dGUgaW4gbWVtYmxvY2sgdG8gZGVzY3JpYmUgbWVtb3J5DQo+IHRoYXQg aXMgb21pdHRlZCBmcm9tIHRoZSBkaXJlY3QgbWFwLiBSZW1vdmluZyBtZW1vcnkgZnJvbSBtZW1i bG9jaw0KPiBlbnRpcmVseSBhbHNvIHN0cmlwcyBpdCBvZiB0aGlzIGFubm90YXRpb24sIHdoaWNo IG1lYW5zIHRoYXQNCj4gcGh5c19tZW1fYWNjZXNzX3Byb3QoKSB3aWxsIGlkZW50aWZ5IGl0IGFz IGRldmljZSBtZW1vcnkgbm90IERSQU0sIGFuZA0KPiB1c2UgdGhlIHdyb25nIGF0dHJpYnV0ZXMg d2hlbiB1c2luZyAvZGV2L21lbS4NCj4gDQo+IFRoZXJlIGFyZSBsaWtlbHkgb3RoZXIgcGxhY2Vz IHdoZXJlIHRoaXMgZGlzdGluY3Rpb24gbWF0dGVycywgYW5kIHNvIEkNCj4gYW0gbm90IGJ1eWlu ZyB0aGUganVzdGlmaWNhdGlvbiB0aGF0IHdlIGNhbiBtYWtlIG1lYW5pbmdmdWwgdXNlIG9mDQo+ IHRoaXMgbWVtb3J5IGluIHRoZSBnZW5lcmFsIGNhc2UsIGFuZCBhbnl0aGluZyB0aGF0IHJlbGll cyBvbiBpdCB3aWxsDQo+IGJlIGZyYWdpbGUsIGFuZCBwcm9iYWJseSBvbmx5IGxpbWl0ZWQgdG8g dmVyeSBzcGVjaWZpYyBkZWJ1Zw0KPiBzY2VuYXJpb3MuDQoNClllcC4gb3JpZ2luYWxseSBJIGRp ZCB0aGF0IGZvciBkZWJ1Z2dpbmcgcHVycG9zZSB0byBlbXVsYXRlIGEgbWFjaGluZSB3aXRoDQpz b21lIGhvbGVzIGluIG1lbV9zZWN0aW9uLiBJIGd1ZXNzIGl0IHNob3VsZCBiZSBhbHNvIHVzZWZ1 bCB0byBvdGhlciBwZW9wbGUNCmlmIHRoZXkgbmVlZCB0aGUgc2FtZSB0aGluZyBmb3IgZGVidWdn aW5nLg0KDQo+IA0KPiBTbyBJIGRvbid0IHRoaW5rIHdlIHNob3VsZCBtZXJnZSB0aGlzLg0KDQpJ dCBzaG91bGQgYmUgaW4gdGhlIHNhbWUgc2l0dWF0aW9uIGZvciBvdGhlciBwbGF0Zm9ybXMgbGlr ZSB4ODYsIG1pcHMgYW5kIHh0ZW5zYQ0KYnV0IHRoZXkgaGF2ZSBlbmFibGVkIHRoaXMga2VybmVs IHBhcmFtZXRlci4NCg0KbWF5YmUgdGhlIGVtdWxhdGVkIHBtZW0gYnkgRFJBTSBpcyBhbiB1c2Vm dWwgc2NlbmFyaW8gb3RoZXIgdGhhbiBkZWJ1Z2dpbmcuDQoNCkxhdGVyLCBodHRwczovL2xvcmUu a2VybmVsLm9yZy9sa21sL2NvdmVyLjE2MDIwOTM3NjAuZ2l0Lnl1bGVpeHpoYW5nQHRlbmNlbnQu Y29tL1QvI20xYTc3MDc0YjhlMWRhZGM1OTBhNWY0NWE1MmQ5YzNjZGE2OWMwNzgwDQptaWdodCBi ZSBhYmxlIHRvIHVzZSB0aGlzIHBhcmFtZXRlci4NCg0KQW55d2F5LCBJIGRvbid0IG1pbmQga2Vl cGluZyBpdCBsb2NhbCBmb3IgZGVidWdnaW5nIGF0IHRoaXMgc3RhZ2UgYW5kIHdhaXRpbmcgZm9y IGENCm1vcmUgY29udmluY2luZyB1c2UgY2FzZS4NCg0KPiANCj4gDQo+ID4NCj4gPiA+IEFncmVl ZCwgSSBjYW4ndCBzZWUgdGhpcyBiZWluZyBzb21ldGhpbmcgd2UgcmVhbGx5IHdhbnQgdG8gc3Vw cG9ydC4gSWYgaXQNCj4gPiA+IHR1cm5zIG91dCB0aGF0IGl0IGlzIGdlbmVyYWxseSB1c2VmdWws IHRoZW4gdGhlIGltcGxlbWVudGF0aW9uIHNob3VsZA0KPiA+ID4gcHJvYmFibHkgYmUgc29tZXdo ZXJlIG91dHNpZGUgb2YgYXJjaC8gd2hlcmUgSSBkb24ndCBoYXZlIHRvIGxvb2sgYXQgaXQgOikN Cj4gPiA+DQo+ID4NCj4gPiBXaGF0IHN0b3BzIHRoaXMgYmVjb21pbmcgY29tbW9uIGNvZGUgaXMg dGhhdCBlYWNoIHBsYXRmb3JtIGhhcyBkaWZmZXJlbnQNCj4gd2F5cw0KPiA+IGFuZCBib290IHNl cXVlbmNlcyB0byBwb3B1bGF0ZSBtZW1ibG9jay4NCj4gPiBGb3IgZXhhbXBsZSwgb24gQXJtNjQs IHdoaWxlIGVhcmx5X3BhcmFtIGlzIHBvcHVsYXRlZCwgZHQgaGFzIHBvcHVsYXRlZA0KPiA+IG1l bWJsb2NrIGJlZm9yZSB0aGF0LiBPdGhlciBwbGF0Zm9ybXMgbWlnaHQgYmVlbiBtdWNoIGRpZmZl cmVudC4NCj4gPg0KPiA+ID4gV2lsbA0KPiA+DQoNClRoYW5rcw0KQmFycnkNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9E0C5519F for ; Wed, 18 Nov 2020 23:56:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48BA2246BB for ; Wed, 18 Nov 2020 23:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r30xzA0e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48BA2246BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zUbPhCCQXyjwBIe4qg076ZTbSZGxzZPQ+rRhZtRPnHM=; b=r30xzA0eE5tSP3x1mXyyqnlHi LgEp9YXU5rhBuksn8BcFI68teOpk/WDHbaonhNXeFeS3n1/eIWbPmsztysqp5vTCVCrmP/ajdum8r KFIMr8o9aRe1iyX6HeK0XKae3GeycEpXwTiq8tEAggWA8N0y0lPo+ByfSyypr5iP07dLSz8eaKIwz Z8PDJzdY8kKhcQjEOi5dnuJuymkY2abytSt6C3o4mpd3iouBe6dUmXn4jPrkKFqNDcc92lHPaUS49 KLQxgBuEetL7+15jbrz2iNOyaFzEc3ZU159UZbC50DKYAZM3dP2bkRUO7DUYmA/2pTwUEjnKvWu/Y JCauDPIEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfXIp-0004SD-GC; Wed, 18 Nov 2020 23:55:55 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfXIa-0004Oi-Ug for linux-arm-kernel@lists.infradead.org; Wed, 18 Nov 2020 23:55:45 +0000 Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Cc06p14fXz520J; Thu, 19 Nov 2020 07:55:14 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 19 Nov 2020 07:55:33 +0800 Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Thu, 19 Nov 2020 07:55:33 +0800 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.1913.007; Thu, 19 Nov 2020 07:55:33 +0800 From: "Song Bao Hua (Barry Song)" To: Ard Biesheuvel Subject: RE: [PATCH] arm64: mm: add support for memmap kernel parameters Thread-Topic: [PATCH] arm64: mm: add support for memmap kernel parameters Thread-Index: AQHWvXVLtrpWHgsWH0upIuwmJUX89KnNolcAgAAa/ICAAJI6cP//pm8AgACWN3A= Date: Wed, 18 Nov 2020 23:55:33 +0000 Message-ID: <0a1de2555ed2458d97e5c79929f74380@hisilicon.com> References: <20201118063314.22940-1-song.bao.hua@hisilicon.com> <20201118173854.GA8537@kernel.org> <20201118191528.GA2680@willie-the-truck> <1d3780422d2648dfa80a6de87585819a@hisilicon.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.201.226] MIME-Version: 1.0 X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_185541_624787_29B5EB6D X-CRM114-Status: GOOD ( 38.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "anshuman.khandual@arm.com" , "catalin.marinas@arm.com" , "linux-kernel@vger.kernel.org" , Linuxarm , "linux-arm-kernel@lists.infradead.org" , "akpm@linux-foundation.org" , Will Deacon , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Ard Biesheuvel [mailto:ardb@kernel.org] > Sent: Thursday, November 19, 2020 11:38 AM > To: Song Bao Hua (Barry Song) > Cc: Will Deacon ; Mike Rapoport ; > anshuman.khandual@arm.com; catalin.marinas@arm.com; Linuxarm > ; linux-kernel@vger.kernel.org; > akpm@linux-foundation.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH] arm64: mm: add support for memmap kernel parameters > > On Wed, 18 Nov 2020 at 21:27, Song Bao Hua (Barry Song) > wrote: > > > > > > > > > -----Original Message----- > > > From: Will Deacon [mailto:will@kernel.org] > > > Sent: Thursday, November 19, 2020 8:15 AM > > > To: Mike Rapoport > > > Cc: Song Bao Hua (Barry Song) ; > > > catalin.marinas@arm.com; linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org; akpm@linux-foundation.org; > > > anshuman.khandual@arm.com; Linuxarm > > > Subject: Re: [PATCH] arm64: mm: add support for memmap kernel > parameters > > > > > > On Wed, Nov 18, 2020 at 07:38:54PM +0200, Mike Rapoport wrote: > > > > On Wed, Nov 18, 2020 at 07:33:14PM +1300, Barry Song wrote: > > > > > memmap should be an useful kernel parameter which has been > supported > > > by > > > > > x86, mips and xtensa. > > > > > > > > Why is this parameter should be useful for ARM64? > > > > My understanding is that it is required only to work around really > > > > broken bootloaders, isn't it? > > > > > > > Good question. Originally I wrote this patch to debug and verify the > vmemmap > > leak issue reported in this patch: > > [PATCH v2] arm64: mm: free unused memmap for sparse memory model that > define VMEMMAP > > > https://lore.kernel.org/linux-arm-kernel/20200812010655.96339-1-liwei213@ > huawei.com/ > > I don't have a machine which really has holes in memory_section to debug, > but memmap > > can help. With memmap, I could specified a machine with various holds in > mem_sections. > > > > After that, I figured out this is not only useful for debugging purpose. it can > have some real user cases. > > For example: > > > > 1. DAX on DRAM. > > kernel parameter memmap=XG!YG specifies a range of RAM to emulate > pmem. Then we are able > > to run DAX and filesystem on top of it. Furthermore, this will probably also > benefit the case > > this big patchset wants to "fix" via direct access to memory: > > > https://lore.kernel.org/lkml/cover.1602093760.git.yuleixzhang@tencent.com/T > /#m1a77074b8e1dadc590a5f45a52d9c3cda69c0780 > > as the comments have clearly shown. > > > > 2. reserve some memory for userspace to manage via /dev/mem > > > > Apologies for the bluntness, but what you are saying here is that you > need a hack to pile those other hacks onto. > > Currently, we use the NOMAP attribute in memblock to describe memory > that is omitted from the direct map. Removing memory from memblock > entirely also strips it of this annotation, which means that > phys_mem_access_prot() will identify it as device memory not DRAM, and > use the wrong attributes when using /dev/mem. > > There are likely other places where this distinction matters, and so I > am not buying the justification that we can make meaningful use of > this memory in the general case, and anything that relies on it will > be fragile, and probably only limited to very specific debug > scenarios. Yep. originally I did that for debugging purpose to emulate a machine with some holes in mem_section. I guess it should be also useful to other people if they need the same thing for debugging. > > So I don't think we should merge this. It should be in the same situation for other platforms like x86, mips and xtensa but they have enabled this kernel parameter. maybe the emulated pmem by DRAM is an useful scenario other than debugging. Later, https://lore.kernel.org/lkml/cover.1602093760.git.yuleixzhang@tencent.com/T/#m1a77074b8e1dadc590a5f45a52d9c3cda69c0780 might be able to use this parameter. Anyway, I don't mind keeping it local for debugging at this stage and waiting for a more convincing use case. > > > > > > > Agreed, I can't see this being something we really want to support. If it > > > turns out that it is generally useful, then the implementation should > > > probably be somewhere outside of arch/ where I don't have to look at it :) > > > > > > > What stops this becoming common code is that each platform has different > ways > > and boot sequences to populate memblock. > > For example, on Arm64, while early_param is populated, dt has populated > > memblock before that. Other platforms might been much different. > > > > > Will > > Thanks Barry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel