From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382E3C433E0 for ; Mon, 25 Jan 2021 22:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B4BB207B7 for ; Mon, 25 Jan 2021 22:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732152AbhAYWPm (ORCPT ); Mon, 25 Jan 2021 17:15:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21051 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733093AbhAYWBX (ORCPT ); Mon, 25 Jan 2021 17:01:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611611993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTaS+FJ+pDjg42gXdYSeQXvC2ANYuAqrw02JSEW1Iro=; b=WsEloqmdVveSVnX3eRyfSivhA5X8F6ihjftLx1FoHtLjJkp0w5mD9STTN8FSNwg2E1d37a LjPqEHq0FD0QVF6Qa8fAlcV/dalZ9KAh8H3AczhPbXRE2aWkOL4AXDyG9mqUsraMXmSrHX L+imaj7JE2cV4seAbqhHaG6eraoVxFc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-_1BtxbmaPj2gThHmAOz_YQ-1; Mon, 25 Jan 2021 16:59:51 -0500 X-MC-Unique: _1BtxbmaPj2gThHmAOz_YQ-1 Received: by mail-ed1-f69.google.com with SMTP id k5so8269238edk.15 for ; Mon, 25 Jan 2021 13:59:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lTaS+FJ+pDjg42gXdYSeQXvC2ANYuAqrw02JSEW1Iro=; b=TeQLqNeigySoVKZc/ALpL1xkiePnXZ5IjrxDQgdyTN0AQzPLXHa1bMgAlw0EVwXwEs /NW8mPW7tv5yMbmGnGtkCzAYq5hU//wBi+ACJsUcjWanM04FlqzKJoG/lbEqRuUMsQBS fDnSOVsG5HrBIWZKCIYHd/PpzluqsCTsysKD814/p9k5Kopql/aQm1gBh+jIin1V92KB O9BFWV/6LlIZuo+b1ZfAFWn/gqTjlw2g5cMiVFWXmI6bK6SY0Ub3POaxSi6/5o4BvOvA qQ+aU1/9KG01efx8oFbG5fNfoO/O4VXt1LxJWcZU3q9CcmHiGRbO5gBTUkp4wCHLWiQG ReRg== X-Gm-Message-State: AOAM531bvBhWq/G32hKwgN7vllug73RaY7n+YN8X+NDthuycQIzGnOzg PSP7oZTWJEdaaTykVElaT40K224lvPtVmikayN5MDysvRLNdycL5q3icLWRSHGcf+eWZdWnSZ1n qUob4u3E9LE/UWz9GOUuWaUtG X-Received: by 2002:a17:906:653:: with SMTP id t19mr1628477ejb.44.1611611990731; Mon, 25 Jan 2021 13:59:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFicYGI8UZfLBuXqK/9ExrQkJcwoegaqfEX0vXIxsXsElafNGgvf039NuqutCFQCTGnV9zJA== X-Received: by 2002:a17:906:653:: with SMTP id t19mr1628467ejb.44.1611611990543; Mon, 25 Jan 2021 13:59:50 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id d9sm8882754ejy.123.2021.01.25.13.59.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 13:59:49 -0800 (PST) Subject: Re: [PATCH] KVM: x86: allow KVM_REQ_GET_NESTED_STATE_PAGES outside guest mode for VMX To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable@vger.kernel.org References: <20210125172044.1360661-1-pbonzini@redhat.com> <0b90c11b-0dce-60f3-c98d-3441b418e771@redhat.com> From: Paolo Bonzini Message-ID: <0a1e025a-ff66-8a68-1eae-8797a0a34419@redhat.com> Date: Mon, 25 Jan 2021 22:59:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/21 20:53, Sean Christopherson wrote: > Eh, I would argue that it is more common to do KVM_REQ_GET_NESTED_STATE_PAGES > with is_guest_mode() than it is with !is_guest_mode(), as the latter is valid if > and only if eVMCS is in use. But, I think we're only vying for internet points.:-) > >> however the idea was to remove the call to nested_get_evmcs_page from >> nested_get_vmcs12_pages, since that one is only needed after >> KVM_GET_NESTED_STATE and not during VMLAUNCH/VMRESUME. > > I'm confused, this patch explicitly adds a call to nested_get_evmcs_page() in > nested_get_vmcs12_pages(). What I really meant is that the patch was wrong. :/ I'll send my pull request to Linus without this one, and include it later this week. Paolo