From: Arend Van Spriel <aspriel@gmail.com>
To: Danny van Heumen <danny@dannyvanheumen.nl>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>
Subject: Re: [PATCH v5] brcmfmac: prevent double-free on hardware-reset
Date: Mon, 18 Jul 2022 22:29:32 +0200 [thread overview]
Message-ID: <0a2b1520-b5d2-8a19-b85b-62b7df77553d@gmail.com> (raw)
In-Reply-To: <Jf288fBmG7i8omrWIg5n1dG3Ei2z8Cc-sPjQGVhBHbeHxN8OZYfMhPNX4kop3CpXz4dh7FBKtw-t29PO0MhIthA_030s1GhpnMlKjnAeies=@dannyvanheumen.nl>
On 7/18/2022 7:17 PM, Danny van Heumen wrote:
> ------- Original Message -------
> On Thursday, July 14th, 2022 at 12:04, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
>> [..]
>>
>> That said, I think the $subject patch looks reasonable to me. So feel
>> free to add:
>>
>> Reviewed-by: Ulf Hansson ulf.hansson@linaro.org
>
> I am a first-time contributor. Is this your way of saying that I should submit
> the patch somewhere other than 'linux-wireless@...'? I suppose this fix is not
> urgent enough for 'stable@...', or is it?
>
> I would appreciate information on who will and/or how to follow-up.
Hi Danny,
The above means that Uffe is okay with the patch being included. Kalle
Valo is the linux-wireless maintainer and he will apply the patch to the
linux-wireless repo. The status of your patch can be monitored through
patchwork [1].
By the way, you can add the Fixes: tag referring to the commit that
introduced the issue. Not sure which one should be considered here, but
it is either this one ...
Fixes: 9982464379e8 ("brcmfmac: make sdio suspend wait for threads to
freeze")
... or ...
Fixes: 7836102a750a ("brcmfmac: reset SDIO bus on a firmware crash")
How to create the tag is described here [2]. With git configured
properly you can simply do:
$ git log --pretty=fixes -1 <commit_sha1>
Stable patches have their additional rules [3]. The bus reset was added
in kernel v5.9. Hope this helps.
Regards,
Arend
[1]
https://patchwork.kernel.org/project/linux-wireless/patch/id1HN6qCMAirApBzTA6fT7ZFWBBGCJhULpflxQ7NT6cgCboVnn3RHpiOFjA9SbRqzBRFLk9ES0C4FNvO6fUQsNg7pqF6ZSNAYUo99nHy8PY=@dannyvanheumen.nl/
[2]
https://www.kernel.org/doc/html/v4.10/process/submitting-patches.html#describe-your-changes
[3]
https://www.kernel.org/doc/html/v4.10/process/stable-kernel-rules.html#procedure-for-submitting-patches-to-the-stable-tree
next prev parent reply other threads:[~2022-07-18 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 23:21 [PATCH v5] brcmfmac: prevent double-free on hardware-reset Danny van Heumen
2022-07-12 8:08 ` Arend Van Spriel
2022-07-14 10:04 ` Ulf Hansson
2022-07-14 12:49 ` Arend Van Spriel
2022-07-14 14:39 ` Ulf Hansson
2022-07-15 13:19 ` Arend Van Spriel
2022-07-18 17:17 ` Danny van Heumen
2022-07-18 20:29 ` Arend Van Spriel [this message]
2022-07-28 9:59 ` [v5] wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a2b1520-b5d2-8a19-b85b-62b7df77553d@gmail.com \
--to=aspriel@gmail.com \
--cc=danny@dannyvanheumen.nl \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.