From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C639C433EF for ; Thu, 24 Feb 2022 10:31:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F0ABC83A74; Thu, 24 Feb 2022 11:31:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="dd3phs6a"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 44A6383A70; Thu, 24 Feb 2022 11:31:14 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D2A3F83A74 for ; Thu, 24 Feb 2022 11:31:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1645698667; bh=bv0tUIjStMUwoB9NcF2nlYcd+4copXobRrHRc3INrcA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=dd3phs6aOnvjLzcXNksRuOI4AzQM69m50Me6vA3TMh3HuRh6k6L8nytMLTLOuYzlZ b9VVs8zT63dxHodVmNmYeV7D3aWlKWQlBtkgvvb3TQI06T5rLpfbNfhZI4xh56JqzE Yy6YwxJUAs+o77quNo9O7Sau1CNwShkYlJHj6uTo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.55] ([88.152.144.107]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mi2Nv-1nrpON3cjh-00e7bQ; Thu, 24 Feb 2022 11:31:06 +0100 Message-ID: <0a33b8ef-a130-2097-a4e3-ceb44e1c577c@gmx.de> Date: Thu, 24 Feb 2022 11:31:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC PATCH v2 0/4] enable menu-driven boot device selection Content-Language: en-US To: Masahisa Kojima Cc: Ilias Apalodimas , Simon Glass , Takahiro Akashi , Francois Ozog , Mark Kettenis , u-boot@lists.denx.de References: <20220222160235.24748-1-masahisa.kojima@linaro.org> From: Heinrich Schuchardt In-Reply-To: <20220222160235.24748-1-masahisa.kojima@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:B3MppY68kiyGr/4r4903RCDioqcXAnrbBYSxyqoAlyar+Zb9C8V wH2x3GrKNtBgwaTzehE7b+CWTPfpXBTaq7exo5ETU8/jKQhn6ngABpSso94AiWLwF2qpEY3 7+zXR2blVwgRNha4CTzjwLHZoA0CCGK3Ji7w5Bgly8zR0mLtTrx0KwrzqPTDepxM8lE9YWG h913s27F5+UXfHhj1eppg== X-UI-Out-Filterresults: notjunk:1;V03:K0:a+WzD9OBsiM=:RQPXGdXN7l1cJR8gBSftQB SkroRXwhlkNEqYzadWfO1mbhmFcEK4HMSsDULiBIdqQ/nQFQEiWugLaifY6sBFy6RVeAnGQ6J HXvJIkIKBAPM0uAcp8pVtCzvjeKBDTGlqCkDVrRgegv6Kcr6GXLkd6WnhBvXvDjjf3XaTk7KS zhhaAK9WWHFXcJrjKyxu5zHBuzAvYEN1ZJM3ro2WQ2x1fKN2n8V9Qm5G0cdjps+QT89eYqG8y k1fnPslF1/sXpY129Ghcxe8/P+XAWJGkDAxe7kVWaS1a7bDKpHQZDao0UFjJkWmIVFQqGvayQ gA9GG41l/StNcznnK7VJ7B7e0ZJ/TgM7ZsXG2PQd8voZN/41Xul45poUmr318EDjrr7XWtfY7 BX1Vxf/RtfrSHZpyObKDAsS07bM4bEGBNtsuGhpT9mPCAnCQfskGs0nsww/mR5yLnFkC/PT+9 hLTvn5svfSFyuV3AIO9M+G8pUl/dbuTGQpG31aq3tec+d1bN32oHTBeVhMsCuNsni8Eii5rp+ wW942kS8b16emVqxK2BW5QCKwNeNokxiUg+e/D3DT+3sW8eFRfU4VXlX8yemqafZ/FaLuFeIs JuXnu9VSS20Osr89jzPFUft+JSqpNJEHBoExXTWjA1rJd0qZJ4drhgpMrOD3CwWAudzR34aTv T5FdKNBwUG1UXe/hB0FjYVfMcpYNd91kenywInUWiemV/JVV+g/8f5JMhReLsCoR4eY1i+gW9 n1XiXU3+Ljig6ta8Qca7zxXsjWsJYkuxWWrTba4xznvfhYK3robWOsP7q2me3xofN86MipV67 n8JCZt2tae3kgueEFIn1vCwRHxQScvlKATlSm7O2l126L2/ScHKoGUyZ+8Y9y9B6iICy8t3kW /PBqe8CwGzdz6mnloFTh0ew8g0IwNR4jizmlSgOagPYQccMYzbu9s2cdEiwpommj0ddMbx9Fb j0ltNABOCergmg6Q/hHgpoc7jxMb13ptbJbkRqGpkgU5gPvY4lkiLnH4yfSofsPs8fFCRTN72 x9knnrYR6yF87erm2AbMuJ2U3DZp7sWRnD2k4zpHMVarrioOIDwuDRsUDvI7MvGuNVH5Fz8+z 8efUSXl86DQSyE= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/22/22 17:02, Masahisa Kojima wrote: > This patch series adds the menu-driven boot device selection. > This menu also provides the functionality to add and delete > Boot#### variable, and edit the BootOrder variable. > > This menu appears with the command "bootefi bootmgr", > the menu structure is as follows. Unfortunately there is neither a changelog in this coverletter nor the individual patches. What is the difference to v1? Best regards Heinrich > > * Menu structure > [Boot Manager] > -> select Boot#### to boot > [Boot Manager Maintenance] > - [Add Boot Option] > -> add new Boot#### variable > - [Delete Boot Option] > -> delete existing Boot#### variable > - [Change Boot Order] > -> update BootOrder variable > > * Things to consider > - eliminate EFI_CALLs > - replacement of ANSI_CLEAR_CONSOLE > > * Remaining items > - Support of adding Boot#### other than block device(e.g. network) > - error notification > > Masahisa Kojima (4): > efi_loader: add menu-driven boot device selection > lib/charset: add u16_strlcat() function > test: unit test for u16_strlcat() > efi_loader: add menu-driven UEFI Boot Variable maintenance > > cmd/bootmenu.c | 145 ----- > common/menu.c | 137 ++++ > include/charset.h | 15 + > include/efi_loader.h | 27 + > include/menu.h | 20 + > lib/charset.c | 20 + > lib/efi_loader/Kconfig | 20 + > lib/efi_loader/efi_bootmgr.c | 1105 ++++++++++++++++++++++++++++++++- > lib/efi_loader/efi_boottime.c | 55 +- > lib/efi_loader/efi_console.c | 81 +++ > lib/efi_loader/efi_file.c | 74 ++- > test/unicode_ut.c | 45 ++ > 12 files changed, 1548 insertions(+), 196 deletions(-) >