From mboxrd@z Thu Jan 1 00:00:00 1970 From: noralf@tronnes.org (=?UTF-8?Q?Noralf_Tr=c3=b8nnes?=) Date: Mon, 12 Feb 2018 14:42:53 +0100 Subject: [PATCH] drm/pl111: Fix regression from fbdev CMA helper In-Reply-To: <20180212124019.25268-1-linus.walleij@linaro.org> References: <20180212124019.25268-1-linus.walleij@linaro.org> Message-ID: <0a3e5888-e8fc-df25-377c-5259c767aeed@tronnes.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Den 12.02.2018 13.40, skrev Linus Walleij: > Commit d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") > refactored the driver to use fbdev handling in the core, but > mistakedly limited the number of maximum connections to 0. > > Predictably, zero possible connections also gives zero > framebuffers when using the system. So let's bump it to 1 so > we get our framebuffer back. > > Cc: Noralf Tr?nnes > Cc: Eric Anholt > Fixes: d18df744de1a ("drm/pl111: Use drm_fb_cma_fbdev_init/fini()") > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/pl111/pl111_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c > index acb738c69873..306ac7cabd90 100644 > --- a/drivers/gpu/drm/pl111/pl111_drv.c > +++ b/drivers/gpu/drm/pl111/pl111_drv.c > @@ -138,7 +138,7 @@ static int pl111_modeset_init(struct drm_device *dev) > > drm_mode_config_reset(dev); > > - drm_fb_cma_fbdev_init(dev, 32, 0); > + drm_fb_cma_fbdev_init(dev, 32, 1); > > drm_kms_helper_poll_init(dev); > Sorry about that. I don't know how bridges work, but since it doesn't work this means that there's no connector available at this point? This is the arg docs: ?* @max_conn_count: Maximum number of connectors. ?*????????????????? @dev->mode_config.num_connector is used if this is zero. Anyways: Acked-by: Noralf Tr?nnes From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Subject: Re: [PATCH] drm/pl111: Fix regression from fbdev CMA helper Date: Mon, 12 Feb 2018 14:42:53 +0100 Message-ID: <0a3e5888-e8fc-df25-377c-5259c767aeed@tronnes.org> References: <20180212124019.25268-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 30D066E044 for ; Mon, 12 Feb 2018 13:43:09 +0000 (UTC) In-Reply-To: <20180212124019.25268-1-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij , Daniel Vetter , Jani Nikula , Sean Paul , Eric Anholt Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CkRlbiAxMi4wMi4yMDE4IDEzLjQwLCBza3JldiBMaW51cyBXYWxsZWlqOgo+IENvbW1pdCBkMThk Zjc0NGRlMWEgKCJkcm0vcGwxMTE6IFVzZSBkcm1fZmJfY21hX2ZiZGV2X2luaXQvZmluaSgpIikK PiByZWZhY3RvcmVkIHRoZSBkcml2ZXIgdG8gdXNlIGZiZGV2IGhhbmRsaW5nIGluIHRoZSBjb3Jl LCBidXQKPiBtaXN0YWtlZGx5IGxpbWl0ZWQgdGhlIG51bWJlciBvZiBtYXhpbXVtIGNvbm5lY3Rp b25zIHRvIDAuCj4KPiBQcmVkaWN0YWJseSwgemVybyBwb3NzaWJsZSBjb25uZWN0aW9ucyBhbHNv IGdpdmVzIHplcm8KPiBmcmFtZWJ1ZmZlcnMgd2hlbiB1c2luZyB0aGUgc3lzdGVtLiBTbyBsZXQn cyBidW1wIGl0IHRvIDEgc28KPiB3ZSBnZXQgb3VyIGZyYW1lYnVmZmVyIGJhY2suCj4KPiBDYzog Tm9yYWxmIFRyw7hubmVzIDxub3JhbGZAdHJvbm5lcy5vcmc+Cj4gQ2M6IEVyaWMgQW5ob2x0IDxl cmljQGFuaG9sdC5uZXQ+Cj4gRml4ZXM6IGQxOGRmNzQ0ZGUxYSAoImRybS9wbDExMTogVXNlIGRy bV9mYl9jbWFfZmJkZXZfaW5pdC9maW5pKCkiKQo+IFNpZ25lZC1vZmYtYnk6IExpbnVzIFdhbGxl aWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9w bDExMS9wbDExMV9kcnYuYyB8IDIgKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigr KSwgMSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9w bDExMV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV9kcnYuYwo+IGluZGV4IGFj YjczOGM2OTg3My4uMzA2YWM3Y2FiZDkwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9w bDExMS9wbDExMV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wbDExMS9wbDExMV9kcnYu Ywo+IEBAIC0xMzgsNyArMTM4LDcgQEAgc3RhdGljIGludCBwbDExMV9tb2Rlc2V0X2luaXQoc3Ry dWN0IGRybV9kZXZpY2UgKmRldikKPiAgIAo+ICAgCWRybV9tb2RlX2NvbmZpZ19yZXNldChkZXYp Owo+ICAgCj4gLQlkcm1fZmJfY21hX2ZiZGV2X2luaXQoZGV2LCAzMiwgMCk7Cj4gKwlkcm1fZmJf Y21hX2ZiZGV2X2luaXQoZGV2LCAzMiwgMSk7Cj4gICAKPiAgIAlkcm1fa21zX2hlbHBlcl9wb2xs X2luaXQoZGV2KTsKPiAgIAoKU29ycnkgYWJvdXQgdGhhdC4KCkkgZG9uJ3Qga25vdyBob3cgYnJp ZGdlcyB3b3JrLCBidXQgc2luY2UgaXQgZG9lc24ndCB3b3JrIHRoaXMgbWVhbnMgdGhhdAp0aGVy ZSdzIG5vIGNvbm5lY3RvciBhdmFpbGFibGUgYXQgdGhpcyBwb2ludD8KClRoaXMgaXMgdGhlIGFy ZyBkb2NzOgoKIMKgKiBAbWF4X2Nvbm5fY291bnQ6IE1heGltdW0gbnVtYmVyIG9mIGNvbm5lY3Rv cnMuCiDCoCrCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEBkZXYtPm1vZGVfY29u ZmlnLm51bV9jb25uZWN0b3IgaXMgdXNlZCBpZiB0aGlzIGlzIAp6ZXJvLgoKQW55d2F5czoKQWNr ZWQtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==