From: Richard Henderson <richard.henderson@linaro.org>
To: Jonathan Albrecht <jonathan.albrecht@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Cc: ruixin.bao@ibm.com, iii@linux.ibm.com, david@redhat.com,
cohuck@redhat.com, laurent@vivier.eu, borntraeger@de.ibm.com,
qemu-s390x@nongnu.org, krebbel@linux.ibm.com
Subject: Re: [PATCH v3 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap
Date: Fri, 9 Jul 2021 09:50:37 -0700 [thread overview]
Message-ID: <0a401699-06bc-d937-d41b-111e2098a6ec@linaro.org> (raw)
In-Reply-To: <20210709160459.4962-2-jonathan.albrecht@linux.vnet.ibm.com>
On 7/9/21 9:04 AM, Jonathan Albrecht wrote:
> Currently when a compare-and-trap instruction is executed, qemu will
> always raise a SIGILL signal. On real hardware, a SIGFPE is raised.
>
> Change the PGM_DATA case in cpu_loop to follow the behavior in
> linux kernel /arch/s390/kernel/traps.c.
> * Only raise SIGILL if DXC == 0
> * If DXC matches a non-simulated IEEE exception, raise SIGFPE with
> correct si_code
> * Raise SIGFPE with si_code == 0 for everything else
>
> When applied on20210705210434.45824-2-iii@linux.ibm.com, this fixes
> crashes in the java jdk such as the linked bug.
>
> Buglink:https://bugs.launchpad.net/qemu/+bug/1920913
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/319
> Signed-off-by: Jonathan Albrecht<jonathan.albrecht@linux.vnet.ibm.com>
> ---
> linux-user/s390x/cpu_loop.c | 54 +++++++++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 20 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-07-09 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 16:04 [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap Jonathan Albrecht
2021-07-09 16:04 ` [PATCH v3 1/2] " Jonathan Albrecht
2021-07-09 16:50 ` Richard Henderson [this message]
2021-07-09 16:04 ` [PATCH v3 2/2] tests/tcg: Test that compare-and-trap raises SIGFPE Jonathan Albrecht
2021-07-12 20:02 ` [PATCH v3 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap Laurent Vivier
2021-07-12 21:29 ` jonathan.albrecht
2021-07-13 12:01 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a401699-06bc-d937-d41b-111e2098a6ec@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=jonathan.albrecht@linux.vnet.ibm.com \
--cc=krebbel@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=ruixin.bao@ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.