From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA21C433E0 for ; Sat, 25 Jul 2020 16:40:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEAF2206E3 for ; Sat, 25 Jul 2020 16:40:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jnkDKO4o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbgGYQkS (ORCPT ); Sat, 25 Jul 2020 12:40:18 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:41850 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgGYQkR (ORCPT ); Sat, 25 Jul 2020 12:40:17 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdTDm089050; Sat, 25 Jul 2020 11:39:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595695169; bh=NbfVhg/Rso9iy/ZTX1Svn7MyhcuckxecUCwfUCbjpwA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jnkDKO4oa9Oox6+Q4wWWFHVKw+m7O+JBDYxwU7Ow6WnND0erPbuAUIHpz7sxm2QVF phS3Z3V4SP+uFb3QIXVOHlT2i7x+cww2yGt9BOXzmZb3/Mv3R8APJHMyJHIA6pIaO5 ewSIqkKNfETiU7FJ3tCP56llvvzsqCja4ArkYhNo= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdTeo121873; Sat, 25 Jul 2020 11:39:29 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sat, 25 Jul 2020 11:39:28 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sat, 25 Jul 2020 11:39:28 -0500 Received: from [10.250.34.248] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdSbB096543; Sat, 25 Jul 2020 11:39:28 -0500 Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts To: Marc Zyngier CC: Grzegorz Jaszczyk , , , , , , , , , , References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> <3a73bb14-9f7b-970d-fbae-f9c7bb7bdf1e@ti.com> <87imemxv3l.wl-maz@kernel.org> <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> From: Suman Anna Message-ID: <0a5664c1-88af-072e-7ad2-6a0b28fce28f@ti.com> Date: Sat, 25 Jul 2020 11:39:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 7/25/20 11:27 AM, Marc Zyngier wrote: > On 2020-07-25 16:57, Suman Anna wrote: > > Suman, > >> Hi Marc, > > [...] > >>>>>> @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct >>>>>> platform_device *pdev) >>>>>>           return -ENOMEM; >>>>>> >>>>>>       for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { >>>>>> +        if (intc->invalid_intr & BIT(i)) >>>>>> +            continue; >>>>>> + >>>>>>           irq = platform_get_irq_byname(pdev, irq_names[i]); >>>>>>           if (irq <= 0) { >>>>>> +            if (intc->shared_intr & BIT(i)) >>>>>> +                continue; >>>>> >>>>> I don't really understand why you are treating these "shared" >>>>> interrupts >>>>> differently from the invalid ones. In all cases, they shouldn't be >>>>> used. >>>> >>>> The behavior is the same in how we handle it, but the difference is >>>> that an "invalid" one is never even connected to the ARM interrupt >>>> controller, while the "shared" one is a choice. So, unless this >>>> interrupt is being used/handled by a different processor/entity, you >>>> would not see this skipped from the dts node. >>> >>> And I'm saying that all that matters is that you are discarding these >>> interrupts. Whether they are flagged invalid or shared, they are not >>> available to Linux. So the difference in handling is pointless and >>> only makes it harder to understand what you are doing. >> >> The primary reason for using two properties and this logic was to >> accurately describe the h/w and usage of these in the DT bindings to >> distinguish the "never connected" vs the "optionally can be skipped" >> interrupts rather than go by how these are handled in the driver. I >> feel we will loose this description and make it confusing for SoC >> product integration developers. > > This logic makes zero difference to Linux, and I do not see what > you gain by having two code paths with separate list of unusable > interrupts. OK, I understand your stance on this. And why on Earth would a "Soc product integration > developer" have any business to mess with this driver code? > They should very much stay away from it and deal with their > precious value add. It really depends on how they put together the system and exercise the PRUs and the number of processors interacting with them. We have had customers put together usecases where both the ARM core running Linux and a remote processor like an M4 or R5 talk to the PRU at the same time, or even inter PRUSS instances. They would have to adjust the DT in their board dts files in general. > > If you want two properties or even twenty, go for it, and have fun. > Just don't make this driver even more unreadable than it already is. > Merge all these interrupts in *one* list of unusable interrupts, > and be done with it. Yes, we are merging this for the next version. regards Suman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F99C433E0 for ; Sat, 25 Jul 2020 16:41:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FB9F206F6 for ; Sat, 25 Jul 2020 16:41:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cFvlLrJx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jnkDKO4o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FB9F206F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lHxIkOU/BmALhoW9p6KSV5SymLAEwD0Rc/oCjXTAnxc=; b=cFvlLrJx5ZNAx08eydedv1+Jz hAjz6RvCh5OujPn0U5INM6jFTakgKE2qh5eConm/crfzZTcWCQu1IKYwDYH04CGSe5cHJ76dHaWSG /SIPod5hHF02DNhXHOz2yEMmS1Z0rFgH+7XUM2ggCjAt2udXDSlS4hT41DHi6RWiKmn6t4Y0NiK2B e70c3Ao8mcBSyhEBEfd53XJD3CRBqjrmY4DZ9H49+swytaiYf83cnmjV7vMeBKZAHWEplj2FG17Kr KrT77zwV3Brm8YlSCUjqjVw9o/X3W666Ao0ACGasXcguVd17TpGYwoNy6opi2+tG64UEfXy9u+9ll 5j3WFv1Sw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzNDe-0001tp-KZ; Sat, 25 Jul 2020 16:40:18 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzNDb-0001sF-Lb for linux-arm-kernel@lists.infradead.org; Sat, 25 Jul 2020 16:40:16 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdTDm089050; Sat, 25 Jul 2020 11:39:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1595695169; bh=NbfVhg/Rso9iy/ZTX1Svn7MyhcuckxecUCwfUCbjpwA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jnkDKO4oa9Oox6+Q4wWWFHVKw+m7O+JBDYxwU7Ow6WnND0erPbuAUIHpz7sxm2QVF phS3Z3V4SP+uFb3QIXVOHlT2i7x+cww2yGt9BOXzmZb3/Mv3R8APJHMyJHIA6pIaO5 ewSIqkKNfETiU7FJ3tCP56llvvzsqCja4ArkYhNo= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdTeo121873; Sat, 25 Jul 2020 11:39:29 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sat, 25 Jul 2020 11:39:28 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sat, 25 Jul 2020 11:39:28 -0500 Received: from [10.250.34.248] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 06PGdSbB096543; Sat, 25 Jul 2020 11:39:28 -0500 Subject: Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts To: Marc Zyngier References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-4-git-send-email-grzegorz.jaszczyk@linaro.org> <2a6b0391f1395eb0aa15ffee6769184e@kernel.org> <3a73bb14-9f7b-970d-fbae-f9c7bb7bdf1e@ti.com> <87imemxv3l.wl-maz@kernel.org> <14a0978a-f38f-8cd7-3fee-b0e438513396@ti.com> <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> From: Suman Anna Message-ID: <0a5664c1-88af-072e-7ad2-6a0b28fce28f@ti.com> Date: Sat, 25 Jul 2020 11:39:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1cd0b6c9bfe2dc42e9c6b69baacf4635@kernel.org> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200725_124015_853396_9A362DA8 X-CRM114-Status: GOOD ( 21.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Grzegorz Jaszczyk , jason@lakedaemon.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, tglx@linutronix.de, linux-omap@vger.kernel.org, lee.jones@linaro.org, wmills@ti.com, linux-arm-kernel@lists.infradead.org, david@lechnology.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIDcvMjUvMjAgMTE6MjcgQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPiBPbiAy MDIwLTA3LTI1IDE2OjU3LCBTdW1hbiBBbm5hIHdyb3RlOgo+IAo+IFN1bWFuLAo+IAo+PiBIaSBN YXJjLAo+IAo+IFsuLi5dCj4gCj4+Pj4+PiBAQCAtMjQ0LDggKzI5NSwxNCBAQCBzdGF0aWMgaW50 IHBydXNzX2ludGNfcHJvYmUoc3RydWN0Cj4+Pj4+PiBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FTk9NRU07Cj4+Pj4+Pgo+Pj4+Pj4gwqDC oMKgwqDCoCBmb3IgKGkgPSAwOyBpIDwgTUFYX05VTV9IT1NUX0lSUVM7IGkrKykgewo+Pj4+Pj4g K8KgwqDCoMKgwqDCoMKgIGlmIChpbnRjLT5pbnZhbGlkX2ludHIgJiBCSVQoaSkpCj4+Pj4+PiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb250aW51ZTsKPj4+Pj4+ICsKPj4+Pj4+IMKgwqDCoMKg wqDCoMKgwqDCoCBpcnEgPSBwbGF0Zm9ybV9nZXRfaXJxX2J5bmFtZShwZGV2LCBpcnFfbmFtZXNb aV0pOwo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmIChpcnEgPD0gMCkgewo+Pj4+Pj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKGludGMtPnNoYXJlZF9pbnRyICYgQklUKGkpKQo+Pj4+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjb250aW51ZTsKPj4+Pj4KPj4+Pj4g SSBkb24ndCByZWFsbHkgdW5kZXJzdGFuZCB3aHkgeW91IGFyZSB0cmVhdGluZyB0aGVzZSAic2hh cmVkIiAKPj4+Pj4gaW50ZXJydXB0cwo+Pj4+PiBkaWZmZXJlbnRseSBmcm9tIHRoZSBpbnZhbGlk IG9uZXMuIEluIGFsbCBjYXNlcywgdGhleSBzaG91bGRuJ3QgYmUgCj4+Pj4+IHVzZWQuCj4+Pj4K Pj4+PiBUaGUgYmVoYXZpb3IgaXMgdGhlIHNhbWUgaW4gaG93IHdlIGhhbmRsZSBpdCwgYnV0IHRo ZSBkaWZmZXJlbmNlIGlzCj4+Pj4gdGhhdCBhbiAiaW52YWxpZCIgb25lIGlzIG5ldmVyIGV2ZW4g Y29ubmVjdGVkIHRvIHRoZSBBUk0gaW50ZXJydXB0Cj4+Pj4gY29udHJvbGxlciwgd2hpbGUgdGhl ICJzaGFyZWQiIG9uZSBpcyBhIGNob2ljZS4gU28sIHVubGVzcyB0aGlzCj4+Pj4gaW50ZXJydXB0 IGlzIGJlaW5nIHVzZWQvaGFuZGxlZCBieSBhIGRpZmZlcmVudCBwcm9jZXNzb3IvZW50aXR5LCB5 b3UKPj4+PiB3b3VsZCBub3Qgc2VlIHRoaXMgc2tpcHBlZCBmcm9tIHRoZSBkdHMgbm9kZS4KPj4+ Cj4+PiBBbmQgSSdtIHNheWluZyB0aGF0IGFsbCB0aGF0IG1hdHRlcnMgaXMgdGhhdCB5b3UgYXJl IGRpc2NhcmRpbmcgdGhlc2UKPj4+IGludGVycnVwdHMuIFdoZXRoZXIgdGhleSBhcmUgZmxhZ2dl ZCBpbnZhbGlkIG9yIHNoYXJlZCwgdGhleSBhcmUgbm90Cj4+PiBhdmFpbGFibGUgdG8gTGludXgu IFNvIHRoZSBkaWZmZXJlbmNlIGluIGhhbmRsaW5nIGlzIHBvaW50bGVzcyBhbmQKPj4+IG9ubHkg bWFrZXMgaXQgaGFyZGVyIHRvIHVuZGVyc3RhbmQgd2hhdCB5b3UgYXJlIGRvaW5nLgo+Pgo+PiBU aGUgcHJpbWFyeSByZWFzb24gZm9yIHVzaW5nIHR3byBwcm9wZXJ0aWVzIGFuZCB0aGlzIGxvZ2lj IHdhcyB0bwo+PiBhY2N1cmF0ZWx5IGRlc2NyaWJlIHRoZSBoL3cgYW5kIHVzYWdlIG9mIHRoZXNl IGluIHRoZSBEVCBiaW5kaW5ncyB0bwo+PiBkaXN0aW5ndWlzaCB0aGUgIm5ldmVyIGNvbm5lY3Rl ZCIgdnMgdGhlICJvcHRpb25hbGx5IGNhbiBiZSBza2lwcGVkIgo+PiBpbnRlcnJ1cHRzIHJhdGhl ciB0aGFuIGdvIGJ5IGhvdyB0aGVzZSBhcmUgaGFuZGxlZCBpbiB0aGUgZHJpdmVyLiBJCj4+IGZl ZWwgd2Ugd2lsbCBsb29zZSB0aGlzIGRlc2NyaXB0aW9uIGFuZCBtYWtlIGl0IGNvbmZ1c2luZyBm b3IgU29DCj4+IHByb2R1Y3QgaW50ZWdyYXRpb24gZGV2ZWxvcGVycy4KPiAKPiBUaGlzIGxvZ2lj IG1ha2VzIHplcm8gZGlmZmVyZW5jZSB0byBMaW51eCwgYW5kIEkgZG8gbm90IHNlZSB3aGF0Cj4g eW91IGdhaW4gYnkgaGF2aW5nIHR3byBjb2RlIHBhdGhzIHdpdGggc2VwYXJhdGUgbGlzdCBvZiB1 bnVzYWJsZQo+IGludGVycnVwdHMuIAoKT0ssIEkgdW5kZXJzdGFuZCB5b3VyIHN0YW5jZSBvbiB0 aGlzLgoKQW5kIHdoeSBvbiBFYXJ0aCB3b3VsZCBhICJTb2MgcHJvZHVjdCBpbnRlZ3JhdGlvbgo+ IGRldmVsb3BlciIgaGF2ZSBhbnkgYnVzaW5lc3MgdG8gbWVzcyB3aXRoIHRoaXMgZHJpdmVyIGNv ZGU/Cj4gVGhleSBzaG91bGQgdmVyeSBtdWNoIHN0YXkgYXdheSBmcm9tIGl0IGFuZCBkZWFsIHdp dGggdGhlaXIKPiBwcmVjaW91cyB2YWx1ZSBhZGQuCgpJdCByZWFsbHkgZGVwZW5kcyBvbiBob3cg dGhleSBwdXQgdG9nZXRoZXIgdGhlIHN5c3RlbSBhbmQgZXhlcmNpc2UgdGhlIApQUlVzIGFuZCB0 aGUgbnVtYmVyIG9mIHByb2Nlc3NvcnMgaW50ZXJhY3Rpbmcgd2l0aCB0aGVtLiBXZSBoYXZlIGhh ZCAKY3VzdG9tZXJzIHB1dCB0b2dldGhlciB1c2VjYXNlcyB3aGVyZSBib3RoIHRoZSBBUk0gY29y ZSBydW5uaW5nIExpbnV4IAphbmQgYSByZW1vdGUgcHJvY2Vzc29yIGxpa2UgYW4gTTQgb3IgUjUg dGFsayB0byB0aGUgUFJVIGF0IHRoZSBzYW1lIAp0aW1lLCBvciBldmVuIGludGVyIFBSVVNTIGlu c3RhbmNlcy4gVGhleSB3b3VsZCBoYXZlIHRvIGFkanVzdCB0aGUgRFQgaW4gCnRoZWlyIGJvYXJk IGR0cyBmaWxlcyBpbiBnZW5lcmFsLgoKPiAKPiBJZiB5b3Ugd2FudCB0d28gcHJvcGVydGllcyBv ciBldmVuIHR3ZW50eSwgZ28gZm9yIGl0LCBhbmQgaGF2ZSBmdW4uCj4gSnVzdCBkb24ndCBtYWtl IHRoaXMgZHJpdmVyIGV2ZW4gbW9yZSB1bnJlYWRhYmxlIHRoYW4gaXQgYWxyZWFkeSBpcy4KPiBN ZXJnZSBhbGwgdGhlc2UgaW50ZXJydXB0cyBpbiAqb25lKiBsaXN0IG9mIHVudXNhYmxlIGludGVy cnVwdHMsCj4gYW5kIGJlIGRvbmUgd2l0aCBpdC4KClllcywgd2UgYXJlIG1lcmdpbmcgdGhpcyBm b3IgdGhlIG5leHQgdmVyc2lvbi4KCnJlZ2FyZHMKU3VtYW4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK