From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Danielle Ratson <danieller@mellanox.com>,
netdev@vger.kernel.org, davem@davemloft.net,
michael.chan@broadcom.com, jeffrey.t.kirsher@intel.com,
saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com,
idosch@mellanox.com, snelson@pensando.io, drivers@pensando.io,
andrew@lunn.ch, vivien.didelot@gmail.com, mlxsw@mellanox.com,
Petr Machata <petrm@mellanox.com>
Subject: Re: [RFC PATCH net-next 8/8] selftests: net: Add port split test
Date: Wed, 3 Jun 2020 21:01:17 -0700 [thread overview]
Message-ID: <0a5ac09d-ea4d-fddf-fc58-9a42b7e086f8@gmail.com> (raw)
In-Reply-To: <20200603201638.608cfdb0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 6/3/2020 8:16 PM, Jakub Kicinski wrote:
> On Wed, 3 Jun 2020 11:12:51 -0700 Florian Fainelli wrote:
>> Any reason why this is written in python versus shell?
>
> Perhaps personal preference of the author :)
>
> I'd be curious to hear the disadvantages, is python too big for
> embedded targets?
The uncompressed root filesystem (buildroot based) we use is 37MB
without it and becomes 55MB with python3. Compressed, we are looking at
a 16MB vs 22MB kernel+initramfs, this is a sizable increase, but still
within reason.
NFS mounting when testing network is not such a great idea unless you
have a dedicated port that you can reserve which you sometimes do not
have, that makes extending your program base a bit harder.
In general there appears to be no direction from kernel maintainers
about what scripting language is acceptable for writing selftests. My
concern over time is that if we all let our preferences pick a scripting
language, we could make it harder for people to actually run these tests
when running non mainstream systems and we could start requiring more
and more interpreters or runtime environments over time.
If there is no strong technical reason for using python, which at first
glance there does not appear to be, could we consider shell?
--
Florian
next prev parent reply other threads:[~2020-06-04 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 11:31 [RFC PATCH net-next 0/8] Expose devlink port attributes Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 1/8] devlink: Move set attribute of devlink_port_attrs to devlink_port Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 2/8] devlink: Move switch_port " Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 3/8] devlink: Replace devlink_port_attrs_set parameters with a struct Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 4/8] mlxsw: Set number of port lanes attribute in driver Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 5/8] devlink: Add a new devlink port lanes attribute and pass to netlink Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 6/8] mlxsw: Set port split ability attribute in driver Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 7/8] devlink: Add a new devlink port split ability attribute and pass to netlink Danielle Ratson
2020-06-02 11:31 ` [RFC PATCH net-next 8/8] selftests: net: Add port split test Danielle Ratson
2020-06-03 18:12 ` Florian Fainelli
2020-06-04 3:16 ` Jakub Kicinski
2020-06-04 4:01 ` Florian Fainelli [this message]
2020-06-04 9:44 ` Petr Machata
2020-06-02 16:21 ` [RFC PATCH net-next 0/8] Expose devlink port attributes Jakub Kicinski
2020-06-02 19:33 ` Jakub Kicinski
2020-06-03 10:45 ` Jiri Pirko
2020-06-04 2:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5ac09d-ea4d-fddf-fc58-9a42b7e086f8@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=danieller@mellanox.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=idosch@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=snelson@pensando.io \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.