From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Wed, 05 Dec 2018 15:29:40 +0000 Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address Message-Id: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> MIME-Version: 1 Content-Type: multipart/mixed; boundary="p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR" List-Id: References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> To: Mike Rapoport , Andrew Morton Cc: Michal Hocko , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Michal Simek , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michael Ellerman , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: multipart/mixed; boundary="qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Michal Simek Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address= and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. >=20 > Signed-off-by: Mike Rapoport > --- > arch/microblaze/mm/init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index b17fd8a..44f4b89 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -363,8 +363,9 @@ void __init *early_get_page(void) > * Mem start + kernel_tlb -> here is limit > * because of mem mapping from head.S > */ > - return __va(memblock_alloc_base(PAGE_SIZE, PAGE_SIZE, > - memory_start + kernel_tlb)); > + return memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE, > + MEMBLOCK_LOW_LIMIT, memory_start + kernel_tlb, > + NUMA_NO_NODE); > } > =20 > #endif /* CONFIG_MMU */ >=20 I can't see any issue with functionality when this patch is applied. If you want me to take this via my tree please let me know. Otherwise: Tested-by: Michal Simek Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f-- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlwH7ugACgkQykllyylKDCF+oQCcD3h8FTgH3lqEuM6g3LYVVKdA 5FUAn2kZEag4xhKtRwOtFFVaEnckXAmY =WdzP -----END PGP SIGNATURE----- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FEC6C04EB9 for ; Wed, 5 Dec 2018 15:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59E592084C for ; Wed, 5 Dec 2018 15:30:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="gVRyw7+2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59E592084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727895AbeLEPaB (ORCPT ); Wed, 5 Dec 2018 10:30:01 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:34186 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727842AbeLEP37 (ORCPT ); Wed, 5 Dec 2018 10:29:59 -0500 Received: by mail-wm1-f66.google.com with SMTP id y185so12036039wmd.1 for ; Wed, 05 Dec 2018 07:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=gVRyw7+2g5KFCamDnZaliagJzRR+8ZW/wry1HEYx8H2xI4jpnB0Me40TNKY7YHKe0S pxFTB6QNOUdWNxtXO/tD14kMjV3bHXMo+lOTwWRUlCddHu4yTNj6mqXvoSHLyuy5xChK Aa/VeTjhz4+jI0mENDqayDErCiOBtGguQViGy+qCrUnUqtL64Qo5nV1jF1Q7PaDO3nn0 1GYg1uFzfOABmwsQ9TarYKtQtJ+lX8IdnRBrXt2lMtmlQzK+qxdgLYZHR7lcaAGGE9bf 2Kk2k2iz8ej8EFJpbouIML+tRU+v/fQp8vv0ZrAGqAy9RIBpqHWExPi5zqRw57kxX280 GISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=cZPDVCRHKgDdYAnBn/9OE6wDs/kjhrF3U6MfG952/cTl84TYu/zHueoMEOJYFgYft4 bBS53hxksA2sUCSShCbXwuDZ4zqmVWpwMME1u4y3nM5vdafljNQd9aFaTTr8ovvpQ2E5 xBP2l36QZFDzkDSgkDKWCpFGxwnAz87DtoTaDq7H1ABSZVdqWvu+OWbrwvyfHRXa6mBx DlbGezQoKt6CKh6MykWLrBTH/KVZUpktyKq1QVrOFdMTtxILp/oKesGJ/1GMPDLv3B1d 5UsidTWJ5Kh0Gt3UYbKm86HjenHqFB8xdxJUfWCTvgK0ez8u+GVlyNTtQE5XO15th7DA rjUg== X-Gm-Message-State: AA+aEWamJVokfctCbZ0oVpZYcfIZ1S92LGAcrhoKjWaOQTs6ypvCZRVu NI1TAlh/MKHUfFtKrFYfJkn6ow== X-Google-Smtp-Source: AFSGD/UHtq4fk2Wl67rrTSZM/Q3hwcRK9hTJrXAQMEQQBKeuqJAU/I+aTPVjWv7XJam/i7TTO8Knpw== X-Received: by 2002:a1c:2e0c:: with SMTP id u12mr16477992wmu.81.1544023797695; Wed, 05 Dec 2018 07:29:57 -0800 (PST) Received: from [74.125.206.109] ([149.199.62.131]) by smtp.gmail.com with ESMTPSA id p74sm20297323wmd.29.2018.12.05.07.29.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 07:29:56 -0800 (PST) Reply-To: monstr@monstr.eu Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Michal Simek References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> From: Michal Simek Openpgp: preference=signencrypt Autocrypt: addr=monstr@monstr.eu; prefer-encrypt=mutual; keydata= xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzR9NaWNoYWwgU2lt ZWsgPG1vbnN0ckBtb25zdHIuZXU+wsGBBBMBAgArAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIe AQIXgAIZAQUCWq+GEgUJDuRkWQAKCRA3fH8h/j0fkW9/D/9IBoykgOWah2BakL43PoHAyEKb Wt3QxWZSgQjeV3pBys08uQDxByChT1ZW3wsb30GIQSTlzQ7juacoUosje1ygaLHR4xoFMAT9 L6F4YzZaPwW6aLI8pUJad63r50sWiGDN/UlhvPrHa3tinhReTEgSCoPCFg3TjjT4nI/NSxUS 5DAbL9qpJyr+dZNDUNX/WnPSqMc4q5R1JqVUxw2xuKPtH0KI2YMoMZ4BC+qfIM+hz+FTQAzk nAfA0/fbNi0gi4050wjouDJIN+EEtgqEewqXPxkJcFd3XHZAXcR7f5Q1oEm1fH3ecyiMJ3ye Paim7npOoIB5+wL24BQ7IrMn3NLeFLdFMYZQDSBIUMe4NNyTfvrHPiwZzg2+9Z+OHvR9hv+r +u/iQ5t5IJrnZQIHm4zEsW5TD7HaWLDx6Uq/DPUf2NjzKk8lPb1jgWbCUZ0ccecESwpgMg35 jRxodat/+RkFYBqj7dpxQ91T37RyYgSqKV9EhkIL6F7Whrt9o1cFxhlmTL86hlflPuSs+/Em XwYVS+bO454yo7ksc54S+mKhyDQaBpLZBSh/soJTxB/nCOeJUji6HQBGXdWTPbnci1fnUhF0 iRNmR5lfyrLYKp3CWUrpKmjbfePnUfQS+njvNjQG+gds5qnIk2glCvDsuAM1YXlM5mm5Yh+v z47oYKzXe87BTQRRbrwxARAAl6ol+YeCANN3yTsIfvNmkFnh1QBA6Yw8yuYUkiWQxOeSj/G6 9RWa4K470PTGu7YUrtZm6/snXiKqDtf4jH2QPgwz6b6OpLHI3qddWzYVWtCaR4cJzHxzU0hw zKvTly/WWaZLv/jl7WqSEsyB99+qeGVFAeWrGnfFMe9IOIJiPdni1gcxRXZckeINVYrOddTZ +PNZbAzvS2YSslnpW4n+xSir+KdxUT0mwbxIIe9VdzQwj5SSaIh4mGkvCDd7mrFf0tfnMVW8 M9lnFBGQqXh3GNqrEABKqeBjOzxdhuoLcyDgVDJO345LtZs5ceMz+7o/OyxiUzgMUFCdRx5c dy4vsbtqBfVb9dNf37ApqbQAFDKOyoiYDy7vE7D9ZooKDqEmxlDEdI0KVHChdi9o2jVUurqX bzY20ZhaIytsugPwXOlgCobXb/P3tP2W8olQO/xDeaYWdRroDCcTixydXqsOw0OQh3EkOWzs dGI5oYOD0+qW1t5gdcPgpQJ8YQG8jLHwZ18b73I1iD5wVZQdmdGB/4IszA3TNEmvxyM/quyU e15Bi+DGHgDNeZuju4ZAiXKBVeyzM5DSpDogmdxNCWA7DF75od0uBFVgBvm7gPvW3hJQplw3 FzyOD4pzD6qcJizXBIT1TEH7wGEakKdn4Nb0xMiufDLPtGvS9ZOTL72xYPUAEQEAAcLBZQQY AQIADwIbDAUCWq+GZQUJDuRksQAKCRA3fH8h/j0fkfg6EACjlUQpjvO/rOASSebpxdxoBEcY ffebTPWHC2OMt9XIuVrNqsPVUnv1GQqCq0AtR3Sf9PULCb40yn3b0iwE+kLlCXcWWBBCy88v pKzYGeCGgOvjAdWr7SWxo8hEpxBQ44EqoppqB8bYvnNKvfCuX2UBnlhlNCYjiELJVpGn7H3+ Xd2Zr0brzNjl/DVpi6qmpKlXr7npAalv7hYMxRvQD+j5ee1H/89+cOyHUofjwAZ9t0pIwjzc gl3dX43sVVHYFZTWtnwIUMUC5aPfvi2jwqKcLsGwmdCXHtzULPEHoe33c298tozJG2qBzti+ DZ8rI7/5fNg84cDBM8zjGuU6YIpk0jjOQ+V5V5ees+7JprwswaqMDnaA2xDmDetSSGnrUbDu DzeuMMNmzm+BntDbHcJ0fSYutA/Da71Anwrw5WdcW2Iq3xAvcVq6RsIohw/eiAJxMcne3vmb j6nAfnQwzXJB0WCq0vE+CuCfdTt9RVL3Hgw/I7nskMU84bihrQ5lfJ2VU/vCucl2LebwOeWP HIic/FvF0oY3lecyr+v1jvS5FXJ6rCn3uwotd30azG5pKDtAkpRqW283+LueDVQ5P/Gwp5V1 9e6oMggSVn53IRVPB4MzTXVm/Q03c5YXPqgP4bPIF624HAPRnUxCWY1yrZuE4zNPG5dfY0PN RmzhqoTJlA== Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Date: Wed, 5 Dec 2018 16:29:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: multipart/mixed; boundary="qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Michal Simek Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address= and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. >=20 > Signed-off-by: Mike Rapoport > --- > arch/microblaze/mm/init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index b17fd8a..44f4b89 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -363,8 +363,9 @@ void __init *early_get_page(void) > * Mem start + kernel_tlb -> here is limit > * because of mem mapping from head.S > */ > - return __va(memblock_alloc_base(PAGE_SIZE, PAGE_SIZE, > - memory_start + kernel_tlb)); > + return memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE, > + MEMBLOCK_LOW_LIMIT, memory_start + kernel_tlb, > + NUMA_NO_NODE); > } > =20 > #endif /* CONFIG_MMU */ >=20 I can't see any issue with functionality when this patch is applied. If you want me to take this via my tree please let me know. Otherwise: Tested-by: Michal Simek Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f-- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlwH7ugACgkQykllyylKDCF+oQCcD3h8FTgH3lqEuM6g3LYVVKdA 5FUAn2kZEag4xhKtRwOtFFVaEnckXAmY =WdzP -----END PGP SIGNATURE----- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C096C04EB9 for ; Wed, 5 Dec 2018 15:32:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6329B2084C for ; Wed, 5 Dec 2018 15:32:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="gVRyw7+2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6329B2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4392mM2DgbzDqDp for ; Thu, 6 Dec 2018 02:32:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="gVRyw7+2"; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=monstr.eu (client-ip=2a00:1450:4864:20::343; helo=mail-wm1-x343.google.com; envelope-from=monstr@monstr.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="gVRyw7+2"; dkim-atps=neutral Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4392jS5zjszDqw9 for ; Thu, 6 Dec 2018 02:30:01 +1100 (AEDT) Received: by mail-wm1-x343.google.com with SMTP id m22so13377207wml.3 for ; Wed, 05 Dec 2018 07:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=gVRyw7+2g5KFCamDnZaliagJzRR+8ZW/wry1HEYx8H2xI4jpnB0Me40TNKY7YHKe0S pxFTB6QNOUdWNxtXO/tD14kMjV3bHXMo+lOTwWRUlCddHu4yTNj6mqXvoSHLyuy5xChK Aa/VeTjhz4+jI0mENDqayDErCiOBtGguQViGy+qCrUnUqtL64Qo5nV1jF1Q7PaDO3nn0 1GYg1uFzfOABmwsQ9TarYKtQtJ+lX8IdnRBrXt2lMtmlQzK+qxdgLYZHR7lcaAGGE9bf 2Kk2k2iz8ej8EFJpbouIML+tRU+v/fQp8vv0ZrAGqAy9RIBpqHWExPi5zqRw57kxX280 GISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=XBC816knKMIrbrnliysUTl2dXMci0vUsl+Bi9Z3yBrAle3Y9SoW7gLfqq6gCSvcgw0 V54E9iU5Rtpw/rYA/Poq+TQbwxzTZtAk4hIaqBBpKlB07v2R8d7o7MrKA+wCluEgtiwX yFYkAkVWanhchGrjli8qTli5kmk2jGg9oz/2wTlGdFvn9LXk9o5vwClmrnmp6JjMyRgx g4dMS2uOTMgy2XUxM9Xg4AdkTVCPLJYW1k/HGG0vl9IAufp0zSQaBAgOgQgKQCaZ0jwv NqtZsAspdvyViMQ0FsGRMoTAb/RI4KuykeEeVPFjJjet6BcFkr1+/Iyf27VVsfdkI/3/ Fkzg== X-Gm-Message-State: AA+aEWZFyJHGUziPLdsbEsuWjSoRIuxxJJEYLysNUEs9qwsIgCeQZxQd 7qaKaLFTJAbuGTbjMwJpch2CRA== X-Google-Smtp-Source: AFSGD/UHtq4fk2Wl67rrTSZM/Q3hwcRK9hTJrXAQMEQQBKeuqJAU/I+aTPVjWv7XJam/i7TTO8Knpw== X-Received: by 2002:a1c:2e0c:: with SMTP id u12mr16477992wmu.81.1544023797695; Wed, 05 Dec 2018 07:29:57 -0800 (PST) Received: from [74.125.206.109] ([149.199.62.131]) by smtp.gmail.com with ESMTPSA id p74sm20297323wmd.29.2018.12.05.07.29.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 07:29:56 -0800 (PST) Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address To: Mike Rapoport , Andrew Morton References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> From: Michal Simek Openpgp: preference=signencrypt Autocrypt: addr=monstr@monstr.eu; prefer-encrypt=mutual; keydata= xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzR9NaWNoYWwgU2lt ZWsgPG1vbnN0ckBtb25zdHIuZXU+wsGBBBMBAgArAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIe AQIXgAIZAQUCWq+GEgUJDuRkWQAKCRA3fH8h/j0fkW9/D/9IBoykgOWah2BakL43PoHAyEKb Wt3QxWZSgQjeV3pBys08uQDxByChT1ZW3wsb30GIQSTlzQ7juacoUosje1ygaLHR4xoFMAT9 L6F4YzZaPwW6aLI8pUJad63r50sWiGDN/UlhvPrHa3tinhReTEgSCoPCFg3TjjT4nI/NSxUS 5DAbL9qpJyr+dZNDUNX/WnPSqMc4q5R1JqVUxw2xuKPtH0KI2YMoMZ4BC+qfIM+hz+FTQAzk nAfA0/fbNi0gi4050wjouDJIN+EEtgqEewqXPxkJcFd3XHZAXcR7f5Q1oEm1fH3ecyiMJ3ye Paim7npOoIB5+wL24BQ7IrMn3NLeFLdFMYZQDSBIUMe4NNyTfvrHPiwZzg2+9Z+OHvR9hv+r +u/iQ5t5IJrnZQIHm4zEsW5TD7HaWLDx6Uq/DPUf2NjzKk8lPb1jgWbCUZ0ccecESwpgMg35 jRxodat/+RkFYBqj7dpxQ91T37RyYgSqKV9EhkIL6F7Whrt9o1cFxhlmTL86hlflPuSs+/Em XwYVS+bO454yo7ksc54S+mKhyDQaBpLZBSh/soJTxB/nCOeJUji6HQBGXdWTPbnci1fnUhF0 iRNmR5lfyrLYKp3CWUrpKmjbfePnUfQS+njvNjQG+gds5qnIk2glCvDsuAM1YXlM5mm5Yh+v z47oYKzXe87BTQRRbrwxARAAl6ol+YeCANN3yTsIfvNmkFnh1QBA6Yw8yuYUkiWQxOeSj/G6 9RWa4K470PTGu7YUrtZm6/snXiKqDtf4jH2QPgwz6b6OpLHI3qddWzYVWtCaR4cJzHxzU0hw zKvTly/WWaZLv/jl7WqSEsyB99+qeGVFAeWrGnfFMe9IOIJiPdni1gcxRXZckeINVYrOddTZ +PNZbAzvS2YSslnpW4n+xSir+KdxUT0mwbxIIe9VdzQwj5SSaIh4mGkvCDd7mrFf0tfnMVW8 M9lnFBGQqXh3GNqrEABKqeBjOzxdhuoLcyDgVDJO345LtZs5ceMz+7o/OyxiUzgMUFCdRx5c dy4vsbtqBfVb9dNf37ApqbQAFDKOyoiYDy7vE7D9ZooKDqEmxlDEdI0KVHChdi9o2jVUurqX bzY20ZhaIytsugPwXOlgCobXb/P3tP2W8olQO/xDeaYWdRroDCcTixydXqsOw0OQh3EkOWzs dGI5oYOD0+qW1t5gdcPgpQJ8YQG8jLHwZ18b73I1iD5wVZQdmdGB/4IszA3TNEmvxyM/quyU e15Bi+DGHgDNeZuju4ZAiXKBVeyzM5DSpDogmdxNCWA7DF75od0uBFVgBvm7gPvW3hJQplw3 FzyOD4pzD6qcJizXBIT1TEH7wGEakKdn4Nb0xMiufDLPtGvS9ZOTL72xYPUAEQEAAcLBZQQY AQIADwIbDAUCWq+GZQUJDuRksQAKCRA3fH8h/j0fkfg6EACjlUQpjvO/rOASSebpxdxoBEcY ffebTPWHC2OMt9XIuVrNqsPVUnv1GQqCq0AtR3Sf9PULCb40yn3b0iwE+kLlCXcWWBBCy88v pKzYGeCGgOvjAdWr7SWxo8hEpxBQ44EqoppqB8bYvnNKvfCuX2UBnlhlNCYjiELJVpGn7H3+ Xd2Zr0brzNjl/DVpi6qmpKlXr7npAalv7hYMxRvQD+j5ee1H/89+cOyHUofjwAZ9t0pIwjzc gl3dX43sVVHYFZTWtnwIUMUC5aPfvi2jwqKcLsGwmdCXHtzULPEHoe33c298tozJG2qBzti+ DZ8rI7/5fNg84cDBM8zjGuU6YIpk0jjOQ+V5V5ees+7JprwswaqMDnaA2xDmDetSSGnrUbDu DzeuMMNmzm+BntDbHcJ0fSYutA/Da71Anwrw5WdcW2Iq3xAvcVq6RsIohw/eiAJxMcne3vmb j6nAfnQwzXJB0WCq0vE+CuCfdTt9RVL3Hgw/I7nskMU84bihrQ5lfJ2VU/vCucl2LebwOeWP HIic/FvF0oY3lecyr+v1jvS5FXJ6rCn3uwotd30azG5pKDtAkpRqW283+LueDVQ5P/Gwp5V1 9e6oMggSVn53IRVPB4MzTXVm/Q03c5YXPqgP4bPIF624HAPRnUxCWY1yrZuE4zNPG5dfY0PN RmzhqoTJlA== Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Date: Wed, 5 Dec 2018 16:29:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: monstr@monstr.eu Cc: Michal Hocko , linux-sh@vger.kernel.org, Michal Simek , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: multipart/mixed; boundary="qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Michal Simek Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address= and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. >=20 > Signed-off-by: Mike Rapoport > --- > arch/microblaze/mm/init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index b17fd8a..44f4b89 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -363,8 +363,9 @@ void __init *early_get_page(void) > * Mem start + kernel_tlb -> here is limit > * because of mem mapping from head.S > */ > - return __va(memblock_alloc_base(PAGE_SIZE, PAGE_SIZE, > - memory_start + kernel_tlb)); > + return memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE, > + MEMBLOCK_LOW_LIMIT, memory_start + kernel_tlb, > + NUMA_NO_NODE); > } > =20 > #endif /* CONFIG_MMU */ >=20 I can't see any issue with functionality when this patch is applied. If you want me to take this via my tree please let me know. Otherwise: Tested-by: Michal Simek Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f-- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlwH7ugACgkQykllyylKDCF+oQCcD3h8FTgH3lqEuM6g3LYVVKdA 5FUAn2kZEag4xhKtRwOtFFVaEnckXAmY =WdzP -----END PGP SIGNATURE----- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A94AC04EB9 for ; Wed, 5 Dec 2018 15:30:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C8620878 for ; Wed, 5 Dec 2018 15:30:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ftuwX8zz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="gVRyw7+2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9C8620878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:Reply-To :List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yQOr0wbxpbo9l6a1V0M0/o4Igr38qx2FKim5jtxnqng=; b=ftuwX8zzKqAvPMy4SM4MaFLfs fAYKfOBkV8RE9SHr4GlWlVTWvVWYXxYue1iOPvvt2rcmFj2XkNSW4nQU/zcdY+Of3BHKK47ts/15h aEYAu3e6B8F9Fy4DVZkH5t/8KbsRSDv18Mhh/BCSf1U6K8KiBG23bg/DIsDJqu6OI68GIgixfcz0r zN2xkUJgARgcp6bmG8DcaHkT4u2ry8sgpVkF4AZHDlsrvzG0u6x3bDDs3EuqUx8wQJ5tBnySvpwFq 6iOccOTELXCLb9XlmdSGroO4kWEJPJwNc1/DNLs08kELiWduYO0BnqQaZJ+vRCKffpmMvQcCJ6xp8 fvnhfAgIA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUZ7s-0003bR-GH; Wed, 05 Dec 2018 15:30:12 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUZ7p-0002Ga-Mh for linux-arm-kernel@lists.infradead.org; Wed, 05 Dec 2018 15:30:11 +0000 Received: by mail-wm1-x341.google.com with SMTP id m22so13377205wml.3 for ; Wed, 05 Dec 2018 07:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=reply-to:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=gVRyw7+2g5KFCamDnZaliagJzRR+8ZW/wry1HEYx8H2xI4jpnB0Me40TNKY7YHKe0S pxFTB6QNOUdWNxtXO/tD14kMjV3bHXMo+lOTwWRUlCddHu4yTNj6mqXvoSHLyuy5xChK Aa/VeTjhz4+jI0mENDqayDErCiOBtGguQViGy+qCrUnUqtL64Qo5nV1jF1Q7PaDO3nn0 1GYg1uFzfOABmwsQ9TarYKtQtJ+lX8IdnRBrXt2lMtmlQzK+qxdgLYZHR7lcaAGGE9bf 2Kk2k2iz8ej8EFJpbouIML+tRU+v/fQp8vv0ZrAGqAy9RIBpqHWExPi5zqRw57kxX280 GISg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to; bh=Ur086D7qzDoupcVAByhiQQIwNEmAWU9EL932ufFCXSc=; b=MA496OJuDqFYv/sBQQW/w7rCW/N1WF+2KFllgjUbphxisJPl/LKUU+uXcGmjKwAj7x 79IWi2Q8EcmiZ2sFAbduUrsWBy/Au0HXoPG+NnZErRCnrOzPF5tZ/P0T2A1otJuuSW9P 36FUo0zwJXfJwrSwFpd4yVuJRHMexfP0w5BIA+xPrOReNno0dJAtgXkETlkJYRqMa5Qp axmPcUXFaagYboQhGLbYgfxt1jayqwKXaHCAgt6QuzuUH2ejwvFT/CapGTdsogn9vS2r NUiDCo+yvIPxbO+Avq6r2SNVWleR34LJbflgaYoMGCRvY1YWg7lU+JuSFqcvWZOD3QGT j1lw== X-Gm-Message-State: AA+aEWaJShEmhhvgoNgv9V+w7SLU4Ai3KYYARN+/kWOZ9k3jRlcjtqet SGOLRnddh+TY6JcRH4CzjhNNTQ== X-Google-Smtp-Source: AFSGD/UHtq4fk2Wl67rrTSZM/Q3hwcRK9hTJrXAQMEQQBKeuqJAU/I+aTPVjWv7XJam/i7TTO8Knpw== X-Received: by 2002:a1c:2e0c:: with SMTP id u12mr16477992wmu.81.1544023797695; Wed, 05 Dec 2018 07:29:57 -0800 (PST) Received: from [74.125.206.109] ([149.199.62.131]) by smtp.gmail.com with ESMTPSA id p74sm20297323wmd.29.2018.12.05.07.29.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 07:29:56 -0800 (PST) Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address To: Mike Rapoport , Andrew Morton References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> From: Michal Simek Openpgp: preference=signencrypt Autocrypt: addr=monstr@monstr.eu; prefer-encrypt=mutual; keydata= xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzR9NaWNoYWwgU2lt ZWsgPG1vbnN0ckBtb25zdHIuZXU+wsGBBBMBAgArAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIe AQIXgAIZAQUCWq+GEgUJDuRkWQAKCRA3fH8h/j0fkW9/D/9IBoykgOWah2BakL43PoHAyEKb Wt3QxWZSgQjeV3pBys08uQDxByChT1ZW3wsb30GIQSTlzQ7juacoUosje1ygaLHR4xoFMAT9 L6F4YzZaPwW6aLI8pUJad63r50sWiGDN/UlhvPrHa3tinhReTEgSCoPCFg3TjjT4nI/NSxUS 5DAbL9qpJyr+dZNDUNX/WnPSqMc4q5R1JqVUxw2xuKPtH0KI2YMoMZ4BC+qfIM+hz+FTQAzk nAfA0/fbNi0gi4050wjouDJIN+EEtgqEewqXPxkJcFd3XHZAXcR7f5Q1oEm1fH3ecyiMJ3ye Paim7npOoIB5+wL24BQ7IrMn3NLeFLdFMYZQDSBIUMe4NNyTfvrHPiwZzg2+9Z+OHvR9hv+r +u/iQ5t5IJrnZQIHm4zEsW5TD7HaWLDx6Uq/DPUf2NjzKk8lPb1jgWbCUZ0ccecESwpgMg35 jRxodat/+RkFYBqj7dpxQ91T37RyYgSqKV9EhkIL6F7Whrt9o1cFxhlmTL86hlflPuSs+/Em XwYVS+bO454yo7ksc54S+mKhyDQaBpLZBSh/soJTxB/nCOeJUji6HQBGXdWTPbnci1fnUhF0 iRNmR5lfyrLYKp3CWUrpKmjbfePnUfQS+njvNjQG+gds5qnIk2glCvDsuAM1YXlM5mm5Yh+v z47oYKzXe87BTQRRbrwxARAAl6ol+YeCANN3yTsIfvNmkFnh1QBA6Yw8yuYUkiWQxOeSj/G6 9RWa4K470PTGu7YUrtZm6/snXiKqDtf4jH2QPgwz6b6OpLHI3qddWzYVWtCaR4cJzHxzU0hw zKvTly/WWaZLv/jl7WqSEsyB99+qeGVFAeWrGnfFMe9IOIJiPdni1gcxRXZckeINVYrOddTZ +PNZbAzvS2YSslnpW4n+xSir+KdxUT0mwbxIIe9VdzQwj5SSaIh4mGkvCDd7mrFf0tfnMVW8 M9lnFBGQqXh3GNqrEABKqeBjOzxdhuoLcyDgVDJO345LtZs5ceMz+7o/OyxiUzgMUFCdRx5c dy4vsbtqBfVb9dNf37ApqbQAFDKOyoiYDy7vE7D9ZooKDqEmxlDEdI0KVHChdi9o2jVUurqX bzY20ZhaIytsugPwXOlgCobXb/P3tP2W8olQO/xDeaYWdRroDCcTixydXqsOw0OQh3EkOWzs dGI5oYOD0+qW1t5gdcPgpQJ8YQG8jLHwZ18b73I1iD5wVZQdmdGB/4IszA3TNEmvxyM/quyU e15Bi+DGHgDNeZuju4ZAiXKBVeyzM5DSpDogmdxNCWA7DF75od0uBFVgBvm7gPvW3hJQplw3 FzyOD4pzD6qcJizXBIT1TEH7wGEakKdn4Nb0xMiufDLPtGvS9ZOTL72xYPUAEQEAAcLBZQQY AQIADwIbDAUCWq+GZQUJDuRksQAKCRA3fH8h/j0fkfg6EACjlUQpjvO/rOASSebpxdxoBEcY ffebTPWHC2OMt9XIuVrNqsPVUnv1GQqCq0AtR3Sf9PULCb40yn3b0iwE+kLlCXcWWBBCy88v pKzYGeCGgOvjAdWr7SWxo8hEpxBQ44EqoppqB8bYvnNKvfCuX2UBnlhlNCYjiELJVpGn7H3+ Xd2Zr0brzNjl/DVpi6qmpKlXr7npAalv7hYMxRvQD+j5ee1H/89+cOyHUofjwAZ9t0pIwjzc gl3dX43sVVHYFZTWtnwIUMUC5aPfvi2jwqKcLsGwmdCXHtzULPEHoe33c298tozJG2qBzti+ DZ8rI7/5fNg84cDBM8zjGuU6YIpk0jjOQ+V5V5ees+7JprwswaqMDnaA2xDmDetSSGnrUbDu DzeuMMNmzm+BntDbHcJ0fSYutA/Da71Anwrw5WdcW2Iq3xAvcVq6RsIohw/eiAJxMcne3vmb j6nAfnQwzXJB0WCq0vE+CuCfdTt9RVL3Hgw/I7nskMU84bihrQ5lfJ2VU/vCucl2LebwOeWP HIic/FvF0oY3lecyr+v1jvS5FXJ6rCn3uwotd30azG5pKDtAkpRqW283+LueDVQ5P/Gwp5V1 9e6oMggSVn53IRVPB4MzTXVm/Q03c5YXPqgP4bPIF624HAPRnUxCWY1yrZuE4zNPG5dfY0PN RmzhqoTJlA== Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Date: Wed, 5 Dec 2018 16:29:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_073009_747058_6C5B4232 X-CRM114-Status: GOOD ( 20.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: monstr@monstr.eu Cc: Michal Hocko , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Michal Simek , linux-mm@kvack.org, Rich Felker , Paul Mackerras , sparclinux@vger.kernel.org, Vincent Chen , Jonas Bonn , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Michael Ellerman , Russell King , Mark Salter , Arnd Bergmann , Stefan Kristiansson , openrisc@lists.librecores.org, Greentime Hu , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: multipart/mixed; boundary="===============1390191206482479406==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1390191206482479406== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: multipart/mixed; boundary="qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f"; protected-headers="v1" From: Michal Simek Reply-To: monstr@monstr.eu To: Mike Rapoport , Andrew Morton Cc: Arnd Bergmann , Benjamin Herrenschmidt , "David S. Miller" , Guan Xuetao , Greentime Hu , Jonas Bonn , Michael Ellerman , Michal Hocko , Mark Salter , Paul Mackerras , Rich Felker , Russell King , Stefan Kristiansson , Stafford Horne , Vincent Chen , Yoshinori Sato , linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, Michal Simek Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> Subject: Re: [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address= and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. >=20 > Signed-off-by: Mike Rapoport > --- > arch/microblaze/mm/init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index b17fd8a..44f4b89 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -363,8 +363,9 @@ void __init *early_get_page(void) > * Mem start + kernel_tlb -> here is limit > * because of mem mapping from head.S > */ > - return __va(memblock_alloc_base(PAGE_SIZE, PAGE_SIZE, > - memory_start + kernel_tlb)); > + return memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE, > + MEMBLOCK_LOW_LIMIT, memory_start + kernel_tlb, > + NUMA_NO_NODE); > } > =20 > #endif /* CONFIG_MMU */ >=20 I can't see any issue with functionality when this patch is applied. If you want me to take this via my tree please let me know. Otherwise: Tested-by: Michal Simek Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs --qysf5netJxUn4CkAZbDPuVrHjaMDiAo4f-- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlwH7ugACgkQykllyylKDCF+oQCcD3h8FTgH3lqEuM6g3LYVVKdA 5FUAn2kZEag4xhKtRwOtFFVaEnckXAmY =WdzP -----END PGP SIGNATURE----- --p80uXp4MQpFTW9kBmtIO081Y5oGpJXXIR-- --===============1390191206482479406== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1390191206482479406==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Wed, 5 Dec 2018 16:29:40 +0100 Subject: [OpenRISC] [PATCH v2 2/6] microblaze: prefer memblock API returning virtual address In-Reply-To: <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> References: <1543852035-26634-1-git-send-email-rppt@linux.ibm.com> <1543852035-26634-3-git-send-email-rppt@linux.ibm.com> Message-ID: <0a5e0aef-15fd-2d0c-765c-e7ba60219b00@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On 03. 12. 18 16:47, Mike Rapoport wrote: > Rather than use the memblock_alloc_base that returns a physical address and > then convert this address to the virtual one, use appropriate memblock > function that returns a virtual address. > > Signed-off-by: Mike Rapoport > --- > arch/microblaze/mm/init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c > index b17fd8a..44f4b89 100644 > --- a/arch/microblaze/mm/init.c > +++ b/arch/microblaze/mm/init.c > @@ -363,8 +363,9 @@ void __init *early_get_page(void) > * Mem start + kernel_tlb -> here is limit > * because of mem mapping from head.S > */ > - return __va(memblock_alloc_base(PAGE_SIZE, PAGE_SIZE, > - memory_start + kernel_tlb)); > + return memblock_alloc_try_nid_raw(PAGE_SIZE, PAGE_SIZE, > + MEMBLOCK_LOW_LIMIT, memory_start + kernel_tlb, > + NUMA_NO_NODE); > } > > #endif /* CONFIG_MMU */ > I can't see any issue with functionality when this patch is applied. If you want me to take this via my tree please let me know. Otherwise: Tested-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: OpenPGP digital signature URL: