From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caz9v-0002GP-MV for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:21:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caz9s-0006fH-Jb for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:21:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caz9s-0006f7-E6 for qemu-devel@nongnu.org; Tue, 07 Feb 2017 01:21:44 -0500 References: <1486110164-13797-1-git-send-email-peterx@redhat.com> <1486110164-13797-7-git-send-email-peterx@redhat.com> <20170207061630.GV5151@pxdev.xzpeter.org> From: Jason Wang Message-ID: <0a5e74e0-c096-5ca6-071a-339e4c4ef219@redhat.com> Date: Tue, 7 Feb 2017 14:21:31 +0800 MIME-Version: 1.0 In-Reply-To: <20170207061630.GV5151@pxdev.xzpeter.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v6 06/18] intel_iommu: renaming gpa to iova where proper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, tianyu.lan@intel.com, kevin.tian@intel.com, mst@redhat.com, jan.kiszka@siemens.com, David Gibson , alex.williamson@redhat.com, bd.aviv@gmail.com On 2017=E5=B9=B402=E6=9C=8807=E6=97=A5 14:16, Peter Xu wrote: > On Tue, Feb 07, 2017 at 01:27:37PM +0800, Jason Wang wrote: >> >> On 2017=E5=B9=B402=E6=9C=8803=E6=97=A5 16:22, Peter Xu wrote: >>> There are lots of places in current intel_iommu.c codes that named >>> "iova" as "gpa". It is really confusing to use a name "gpa" in these >>> places (which is very easily to be understood as "Guest Physical >>> Address", while it's not). To make the codes (much) easier to be read= , I >>> decided to do this once and for all. >>> >>> No functional change is made. Only literal ones. >>> >>> Signed-off-by: Peter Xu >> Reviewed-by: Jason Wang >> >> Actually, there's one more left: >> >> $git grep gpa hw/i386/intel_iommu.c >> hw/i386/intel_iommu.c:static int vtd_gpa_to_slpte(VTDContextEntry *ce, >> uint64_t iova, bool is_write, >> hw/i386/intel_iommu.c: ret_fr =3D vtd_gpa_to_slpte(&ce, addr, is_wr= ite, >> &slpte, &level, > Yes, will fix this as well. Thanks, > > -- peterx You can keep my Reviewed-by with this fixed. Thanks