From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752020AbeEQT7o (ORCPT ); Thu, 17 May 2018 15:59:44 -0400 Received: from mail-qt0-f196.google.com ([209.85.216.196]:43997 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbeEQT7n (ORCPT ); Thu, 17 May 2018 15:59:43 -0400 X-Google-Smtp-Source: AB8JxZqhvKLAZ8YVjKv7b991LA0I0CaB3MbRFyFHzlx304mv+wMcT++sm4hMNVzofhE5Xb/wF1oKFw== Subject: Re: [PATCH] arm: bcm2835: Add the PMU to the devicetree. To: Vince Weaver , Peter Zijlstra , marc.zyngier@arm.com Cc: Stefan Wahren , Ingo Molnar , Arnaldo Carvalho de Melo , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, Eric Anholt , linux-arm-kernel@lists.infradead.org, Mark Rutland References: <20180517131727.29263-1-eric@anholt.net> <1412187220.62585.1526572780332@email.1und1.de> <307323036.63872.1526576126537@email.1und1.de> <20180517180758.GK12198@hirez.programming.kicks-ass.net> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: <0a643984-1586-8c56-6627-430f0c2a4ba8@gmail.com> Date: Thu, 17 May 2018 12:59:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/17/2018 12:31 PM, Vince Weaver wrote: > On Thu, 17 May 2018, Vince Weaver wrote: > >> On Thu, 17 May 2018, Peter Zijlstra wrote: >> with cortex-a7 now, would it be possible to later drop that if proper >> cortex-a53 support is added to the armv7 pmu driver? Or would that lead >> to all kinds of back-compatability mess? > > For what it's worth, the pi-foundation kernel bcm2710 device tree file > does: > > arm-pmu { > #ifdef RPI364 > compatible = "arm,armv8-pmuv3", "arm,cortex-a7-pmu"; > #else > compatible = "arm,cortex-a7-pmu"; > #endif > interrupt-parent = <&local_intc>; > interrupts = <9>; > }; > > > Which is probably where I was getting the arm,armv8-pmuv3 from in my > original patch. I thought somehow that Marc Z. had unified arch/arm/kernel/perf_event_v7.c and arch/arm64/kernel/perf_event.c into a common driver entry point under drivers/perf/arm_pmu.c but I don't see it and after about 15 minutes looking at it, it does not look as trivial as I though to separate out those files so the ARMv8 PMU description can be moved into a generic location for instance. FWIW, Broadcom STB chips, even when 64-bit capable or often used with an 32-bit ARM kernel, so having the ARMv8 PMUs work under a 32-bit ARM kernel would be great. The downstream solution we have sued thus far is to find the closest compatible string to represent those, which is not great... -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: f.fainelli@gmail.com (Florian Fainelli) Date: Thu, 17 May 2018 12:59:28 -0700 Subject: [PATCH] arm: bcm2835: Add the PMU to the devicetree. In-Reply-To: References: <20180517131727.29263-1-eric@anholt.net> <1412187220.62585.1526572780332@email.1und1.de> <307323036.63872.1526576126537@email.1und1.de> <20180517180758.GK12198@hirez.programming.kicks-ass.net> Message-ID: <0a643984-1586-8c56-6627-430f0c2a4ba8@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/17/2018 12:31 PM, Vince Weaver wrote: > On Thu, 17 May 2018, Vince Weaver wrote: > >> On Thu, 17 May 2018, Peter Zijlstra wrote: >> with cortex-a7 now, would it be possible to later drop that if proper >> cortex-a53 support is added to the armv7 pmu driver? Or would that lead >> to all kinds of back-compatability mess? > > For what it's worth, the pi-foundation kernel bcm2710 device tree file > does: > > arm-pmu { > #ifdef RPI364 > compatible = "arm,armv8-pmuv3", "arm,cortex-a7-pmu"; > #else > compatible = "arm,cortex-a7-pmu"; > #endif > interrupt-parent = <&local_intc>; > interrupts = <9>; > }; > > > Which is probably where I was getting the arm,armv8-pmuv3 from in my > original patch. I thought somehow that Marc Z. had unified arch/arm/kernel/perf_event_v7.c and arch/arm64/kernel/perf_event.c into a common driver entry point under drivers/perf/arm_pmu.c but I don't see it and after about 15 minutes looking at it, it does not look as trivial as I though to separate out those files so the ARMv8 PMU description can be moved into a generic location for instance. FWIW, Broadcom STB chips, even when 64-bit capable or often used with an 32-bit ARM kernel, so having the ARMv8 PMUs work under a 32-bit ARM kernel would be great. The downstream solution we have sued thus far is to find the closest compatible string to represent those, which is not great... -- Florian