From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Jon Mason <jdmason@kudzu.us>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [meta-oe][PATCH v2 1/6] Space-comma Cleanups
Date: Mon, 28 Sep 2020 12:25:25 +0100 [thread overview]
Message-ID: <0a774fc3ff7030cb11f09bd05948c437a0928dc6.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAPoiz9zS8sXVb6iFh3Yndtej_toUXKNw4nOGdUx5WpaeevQADA@mail.gmail.com>
On Sun, 2020-09-27 at 21:47 -0400, Jon Mason wrote:
> On Fri, Sep 25, 2020 at 5:29 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2020-09-25 at 15:28 -0400, Jon Mason wrote:
> > > Multiple files have " ," instead of ", " in expressions. This
> > > changes
> > > them to conform to the way the rest of them are done.
> > >
> > > Found and corrected via:
> > > git ls-files | xargs sed -i 's/ ,d/, d/g'
> > >
> > > Signed-off-by: Jon Mason <jon.mason@arm.com>
> > > ---
> > > meta/classes/linuxloader.bbclass | 2 +-
> > > meta/classes/rootfs_rpm.bbclass | 2 +-
> > > meta/conf/machine/include/arm/arch-arm64.inc | 10 +-
> > > meta/conf/machine/include/arm/arch-armv4.inc | 2 +-
> > > meta/conf/machine/include/arm/arch-armv5.inc | 2 +-
> > > meta/conf/machine/include/arm/arch-armv6.inc | 2 +-
> > > meta/conf/machine/include/arm/arch-armv6m.inc | 2 +-
> > > meta/conf/machine/include/arm/arch-armv7a.inc | 2 +-
> > > .../conf/machine/include/arm/arch-armv7ve.inc | 2 +-
> > > .../machine/include/arm/arch-armv8-2a.inc | 2 +-
> > > meta/conf/machine/include/arm/arch-armv8a.inc | 2 +-
> > > meta/conf/machine/include/mips/arch-mips.inc | 16 +-
> > > .../conf/machine/include/tune-arm1136jf-s.inc | 2 +-
> > > .../conf/machine/include/tune-arm1176jz-s.inc | 2 +-
> > > meta/conf/machine/include/tune-arm920t.inc | 2 +-
> > > meta/conf/machine/include/tune-arm926ejs.inc | 2 +-
> > > meta/conf/machine/include/tune-arm9tdmi.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa15.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa17.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa5.inc | 2 +-
> > > .../include/tune-cortexa57-cortexa53.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa7.inc | 2 +-
> > > .../include/tune-cortexa72-cortexa53.inc | 2 +-
> > > .../include/tune-cortexa73-cortexa53.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa8.inc | 2 +-
> > > meta/conf/machine/include/tune-cortexa9.inc | 2 +-
> > > meta/conf/machine/include/tune-ep9312.inc | 2 +-
> > > meta/conf/machine/include/tune-iwmmxt.inc | 2 +-
> > > .../machine/include/tune-strongarm1100.inc | 2 +-
> > > meta/conf/machine/include/tune-xscale.inc | 2 +-
> > > meta/conf/machine/include/x86/arch-x86.inc | 12 +-
> > > .../recipes-core/images/core-image-minimal.bb | 2 +-
> > > .../qemu/qemu-system-native_5.1.0.bb | 2 +-
> > > meta/recipes-devtools/qemu/qemu_5.1.0.bb | 4 +-
> > > .../vulkan/vulkan-demos_git.bb | 2 +-
> > > meta/recipes-kernel/linux/linux-yocto-dev.bb | 2 +-
> > > .../linux/linux-yocto-rt_5.4.bb | 2 +-
> > > .../linux/linux-yocto-rt_5.8.bb | 2 +-
> > > meta/recipes-kernel/linux/linux-yocto_5.4.bb | 4 +-
> > > meta/recipes-kernel/linux/linux-yocto_5.8.bb | 4 +-
> > > .../libpng/libpng_1.6.37.bb | 2 +-
> > > scripts/pybootchartgui/pybootchartgui/main.py | 184
> > > +++++++++++++++++-
> >
> > Cleanup is good but this last bit doesn't look quite right!
>
> I 100% agree, but it is from the the command I mentioned in the
> commit
> message. In fact, I ran it again just to be sure it wasn't an
> accident. I have no idea why that file is being so heavily modified
> perhaps the sed regex is having some unforeseen side effect. I'll
> remove it by hand from the commit and push a v3.
I think the diff is generated without git -M ? With -M it might have
been clearer what was going on, as the patch stands it looks like the
file is deleted and then recreated which was enough to have me thinking
"what?". From just a quick glance, it looks like something accidentally
added although I now see its not, the changes are just unclear.
Thanks for clarifying!
Cheers,
Richard
next prev parent reply other threads:[~2020-09-28 11:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 19:28 [meta-oe][PATCH v2 0/6] ARMv8 Tune add and reorg Jon Mason
2020-09-25 19:28 ` [meta-oe][PATCH v2 1/6] Space-comma Cleanups Jon Mason
2020-09-25 21:29 ` [OE-core] " Richard Purdie
2020-09-28 1:47 ` Jon Mason
2020-09-28 2:11 ` Martin Jansa
2020-09-28 13:01 ` Jon Mason
2020-09-28 11:25 ` Richard Purdie [this message]
2020-09-25 19:28 ` [meta-oe][PATCH v2 2/6] armv8/tunes: Move TUNECONFLICTS Jon Mason
2020-09-25 19:28 ` [meta-oe][PATCH v2 3/6] armv8/tunes: reference parent's TUNE_FEATURES Jon Mason
2020-09-25 19:28 ` [meta-oe][PATCH v2 4/6] armv8/tunes: Add tunes for supported ARMv8a cores Jon Mason
2020-09-25 19:28 ` [meta-oe][PATCH v2 5/6] armv8/tunes: Add tunes for supported ARMv8.2a cores Jon Mason
2020-09-25 19:28 ` [meta-oe][PATCH v2 6/6] tunes/armv8: move to a new location Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a774fc3ff7030cb11f09bd05948c437a0928dc6.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=jdmason@kudzu.us \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.