From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96648C7EE29 for ; Fri, 2 Jun 2023 10:20:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233875AbjFBKUh (ORCPT ); Fri, 2 Jun 2023 06:20:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234401AbjFBKUe (ORCPT ); Fri, 2 Jun 2023 06:20:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C160E47 for ; Fri, 2 Jun 2023 03:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685701170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BgLDHXPX2IZLtz7SOTVGOnJeSheCUt+28MHjp4LRwzo=; b=CmkLXEcdJG6yey/Mv2xyOI4igZPMLkFZ1elGwzcTzl/73VtkIxJ9r2p6n881PjwudWjYx6 YlfEpSE8lhbkYBVVVdpmMj+hQdAQ/DByQvKOGz3aQ3NJ9oD17o2KKMrMyc+AeWVxA8foCR +35T1PG3Cswr90x5Ct9zcEbAj9rtq+M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-466-GbMbz7REP4WXH2uoAGnL4A-1; Fri, 02 Jun 2023 06:19:29 -0400 X-MC-Unique: GbMbz7REP4WXH2uoAGnL4A-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f608ea691fso10841285e9.3 for ; Fri, 02 Jun 2023 03:19:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685701168; x=1688293168; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BgLDHXPX2IZLtz7SOTVGOnJeSheCUt+28MHjp4LRwzo=; b=EpYYZTEVfmq2xJiH/xq8lZrh+0PBRFI7LcXHIBZAs9n1vl05YEPXwqg8lM3u+eyeN4 I+2CwlhLkuCOv2YLr67rHDyFHPuc9oGlnjH+ihg1N62Yr6oXefU3Y9dVEfG1mUq2F/bk 2I8THQtj2P6j6gvMofc87jV27ya2/x0OsrSdsAilucYy7m9TvYnJJYGWldUGPJSB7Z5J jTT34KAzoBBybkO4kBZivo353up+9pqRwEgGRiHjRec7YXHGpPBqpq+cwfjzatm9tPGV +IqOtJUtPQr6SILrJhtUBM3GRhE3tpLwxDrie9cMNRAPHsqfrlfGeSDrF77yyOxpGBqr RZSg== X-Gm-Message-State: AC+VfDzOQZQEmvHW9+LnXJ36JdYpg+aDoMhqrp5n7UvWIF0+v6AmDVXZ QsXAPPYSztDde8QYQuc0b9smY9SJgkdyj+D5pvsEtezFbLnGWb/KujphH0USNNMGcqkce2DRx4k oANKnhqGrwliKDx5PJ79KPKQ0 X-Received: by 2002:adf:e908:0:b0:307:a36b:e7b1 with SMTP id f8-20020adfe908000000b00307a36be7b1mr4270250wrm.5.1685701168058; Fri, 02 Jun 2023 03:19:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4E/eiNP/vn86p1E+l3RW0GQURo5l23eZb2+28Fm1bHrGkj3O36n10ajTDVlA2/H9wIv7YqQg== X-Received: by 2002:adf:e908:0:b0:307:a36b:e7b1 with SMTP id f8-20020adfe908000000b00307a36be7b1mr4270235wrm.5.1685701167672; Fri, 02 Jun 2023 03:19:27 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2e:ae00:f2e3:50e0:73f7:451? (p200300d82f2eae00f2e350e073f70451.dip0.t-ipconnect.de. [2003:d8:2f2e:ae00:f2e3:50e0:73f7:451]) by smtp.gmail.com with ESMTPSA id m6-20020adff386000000b0030630120e56sm1236957wro.57.2023.06.02.03.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 03:19:27 -0700 (PDT) Message-ID: <0a838454-90d0-9d85-fc2c-8c2571240fb5@redhat.com> Date: Fri, 2 Jun 2023 12:19:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 09/12] selftests/mm: move psize(), pshift() into vm_utils.c Content-Language: en-US To: John Hubbard , Andrew Morton Cc: Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML References: <20230602013358.900637-1-jhubbard@nvidia.com> <20230602013358.900637-10-jhubbard@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230602013358.900637-10-jhubbard@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.06.23 03:33, John Hubbard wrote: > This is in preparation for linking test programs with both vm_utils.c > and uffd-common.c. The static inline routines would prevent that, and > there is no particular need for inlining here, so turn these into normal > functions that are more flexible to build and link. I'm probably missing something important, but isn't it the most common thing to use "static inline" across multiple objects that we then link? Hope you can enlighten me what the real issue here is. -- Thanks, David / dhildenb