Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>,
	"faithilikerun@gmail.com" <faithilikerun@gmail.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "hreitz@redhat.com" <hreitz@redhat.com>,
	"hare@suse.de" <hare@suse.de>,
	"sgarzare@redhat.com" <sgarzare@redhat.com>,
	"mehta.aaru20@gmail.com" <mehta.aaru20@gmail.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"fam@euphon.net" <fam@euphon.net>,
	"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
	"kwolf@redhat.com" <kwolf@redhat.com>,
	"jusual@redhat.com" <jusual@redhat.com>
Subject: Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers
Date: Tue, 14 Mar 2023 12:49:45 +0900	[thread overview]
Message-ID: <0ab0bafd-6e21-2f4d-8d73-8c6683b6d1dd@opensource.wdc.com> (raw)
In-Reply-To: <e143490361477503b5e7bba43e79f369e3cd7d9b.camel@wdc.com>

On 3/14/23 11:23, Dmitry Fomichev wrote:
>> @@ -3339,10 +3473,27 @@ static int coroutine_fn
>> raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op,
>>                          len >> BDRV_SECTOR_BITS);
>>      ret = raw_thread_pool_submit(bs, handle_aiocb_zone_mgmt, &acb);
>>      if (ret != 0) {
>> +        update_zones_wp(s->fd, wps, offset, index);
>>          ret = -errno;
>>          error_report("ioctl %s failed %d", op_name, ret);
>> +        goto out;
>>      }
>>  
>> +    if (zo == BLKRESETZONE && len == capacity) {
>> +        for (int i = 0; i < bs->bl.nr_zones; ++i) {
>> +            if (!BDRV_ZT_IS_CONV(wps->wp[i])) {
>> +                wps->wp[i] = i * bs->bl.zone_size;
> 
> This will reset write pointers of all read-only zones that may exist on the
> device and make the data stored in those zones unreadable. R/O zones need to be
> skipped in this loop.

And offline zones need to be skipped as well.

-- 
Damien Le Moal
Western Digital Research