All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bezdeka, Florian" <florian.bezdeka@siemens.com>
To: "xenomai@xenomai.org" <xenomai@xenomai.org>,
	"jan.kiszka@siemens.com" <jan.kiszka@siemens.com>
Subject: Re: [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot
Date: Mon, 12 Apr 2021 07:45:21 +0000	[thread overview]
Message-ID: <0aef13f824395e02ddbf66e57c64b4577a0151ba.camel@siemens.com> (raw)
In-Reply-To: <1312625a-17c9-801a-719a-08068b697b25@siemens.com>

On Thu, 2021-04-08 at 19:24 +0200, Jan Kiszka wrote:
> On 08.04.21 17:12, Florian Bezdeka wrote:
> > Trying to boot up the example image on an x86 board with UEFI failed
> > because vfat support was missing. The x86 defconfig has been
> > re-synchronized with the arm64 defconfig to enable UEFI boot support.
> > 
> > Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> > ---
> >  recipes-kernel/linux/files/amd64_defconfig | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/recipes-kernel/linux/files/amd64_defconfig b/recipes-kernel/linux/files/amd64_defconfig
> > index bc5cd0b..2b7e63f 100644
> > --- a/recipes-kernel/linux/files/amd64_defconfig
> > +++ b/recipes-kernel/linux/files/amd64_defconfig
> > @@ -3609,7 +3609,10 @@ CONFIG_FSCACHE_HISTOGRAM=y
> >  # DOS/FAT/NT Filesystems
> >  #
> >  # CONFIG_MSDOS_FS is not set
> > -# CONFIG_VFAT_FS is not set
> > +CONFIG_VFAT_FS=y
> > +CONFIG_FAT_DEFAULT_CODEPAGE=437
> > +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"
> > +# CONFIG_FAT_DEFAULT_UTF8 is not set
> >  # CONFIG_NTFS_FS is not set
> >  #
> > @@ -3681,8 +3684,8 @@ CONFIG_9P_FSCACHE=y
> >  CONFIG_9P_FS_POSIX_ACL=y
> >  # CONFIG_9P_FS_SECURITY is not set
> >  CONFIG_NLS=y
> > -CONFIG_NLS_DEFAULT="cp437"
> > -# CONFIG_NLS_CODEPAGE_437 is not set
> > +CONFIG_NLS_DEFAULT="iso8859-1"
> > +CONFIG_NLS_CODEPAGE_437=y
> >  # CONFIG_NLS_CODEPAGE_737 is not set
> >  # CONFIG_NLS_CODEPAGE_775 is not set
> >  # CONFIG_NLS_CODEPAGE_850 is not set
> > @@ -3706,7 +3709,7 @@ CONFIG_NLS_DEFAULT="cp437"
> >  # CONFIG_NLS_CODEPAGE_1250 is not set
> >  # CONFIG_NLS_CODEPAGE_1251 is not set
> >  # CONFIG_NLS_ASCII is not set
> > -# CONFIG_NLS_ISO8859_1 is not set
> > +CONFIG_NLS_ISO8859_1=y
> >  # CONFIG_NLS_ISO8859_2 is not set
> >  # CONFIG_NLS_ISO8859_3 is not set
> >  # CONFIG_NLS_ISO8859_4 is not set
> > 
> 
> I wonder if we should rather store a savedefconfig result here. That
> might have prevented this. Or are those options not part of the
> x86_64-defconfig?

On the long run: Yes, sounds reasonable. 

Converting that to a defconfig now will trigger a lot of reformatting,
resulting in a big diff. Other configs (arm64, armhf) are affected as
well. Maybe something we should postpone to 3.2, so we get the
necessary testing?

> 
> Jan
> 


  reply	other threads:[~2021-04-12  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 15:12 [xenomai-images][PATCH] linux-xenomai: x86: Enable vfat support for UEFI boot Florian Bezdeka
2021-04-08 17:24 ` Jan Kiszka
2021-04-12  7:45   ` Bezdeka, Florian [this message]
2021-04-12  7:46     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aef13f824395e02ddbf66e57c64b4577a0151ba.camel@siemens.com \
    --to=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.