From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbdFAG77 (ORCPT ); Thu, 1 Jun 2017 02:59:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:52572 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751013AbdFAG76 (ORCPT ); Thu, 1 Jun 2017 02:59:58 -0400 Subject: Re: [PATCH v1 7/7] nvmet: allow overriding the NVMe VS via configfs To: Christoph Hellwig , Johannes Thumshirn Cc: Sagi Grimberg , Keith Busch , Max Gurtovoy , Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170601065255.GG16778@lst.de> From: Hannes Reinecke Message-ID: <0af0f525-918d-d2b3-2f08-f4f19c83fab1@suse.de> Date: Thu, 1 Jun 2017 08:59:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170601065255.GG16778@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2017 08:52 AM, Christoph Hellwig wrote: > On Wed, May 31, 2017 at 03:32:17PM +0200, Johannes Thumshirn wrote: >> Allow overriding the announced NVMe Version of a via configfs. >> >> This is particularly helpful when debugging new features for the host >> or target side without bumping the hard coded version (as the target >> might not be fully compliant to the announced version yet). > > It is. Just bump to 1.3, please as Identify 3h is the only mandatory > change: http://nvmexpress.org/changes/ > Actually, I still do like this. With it it'll be very easy to test version compliance; and validate our initiator behaviour against older versions. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Thu, 1 Jun 2017 08:59:52 +0200 Subject: [PATCH v1 7/7] nvmet: allow overriding the NVMe VS via configfs In-Reply-To: <20170601065255.GG16778@lst.de> References: <20170601065255.GG16778@lst.de> Message-ID: <0af0f525-918d-d2b3-2f08-f4f19c83fab1@suse.de> On 06/01/2017 08:52 AM, Christoph Hellwig wrote: > On Wed, May 31, 2017@03:32:17PM +0200, Johannes Thumshirn wrote: >> Allow overriding the announced NVMe Version of a via configfs. >> >> This is particularly helpful when debugging new features for the host >> or target side without bumping the hard coded version (as the target >> might not be fully compliant to the announced version yet). > > It is. Just bump to 1.3, please as Identify 3h is the only mandatory > change: http://nvmexpress.org/changes/ > Actually, I still do like this. With it it'll be very easy to test version compliance; and validate our initiator behaviour against older versions. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare at suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg)