From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF07C48BE5 for ; Thu, 17 Jun 2021 09:43:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84135613E7 for ; Thu, 17 Jun 2021 09:43:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231750AbhFQJpi (ORCPT ); Thu, 17 Jun 2021 05:45:38 -0400 Received: from szxga03-in.huawei.com ([45.249.212.189]:7350 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbhFQJph (ORCPT ); Thu, 17 Jun 2021 05:45:37 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G5H7w6kgSz6vT9; Thu, 17 Jun 2021 17:39:24 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:25 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:24 +0800 Subject: Re: [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2 To: Marc Zyngier CC: Will Deacon , Quentin Perret , Alexandru Elisei , , , , , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , , , References: <20210616095200.38008-1-wangyanan55@huawei.com> <20210616095200.38008-2-wangyanan55@huawei.com> <87eed2lzcc.wl-maz@kernel.org> <8340be12-cc80-8c2a-3597-ecba05eaf35a@huawei.com> <87o8c4dikn.wl-maz@kernel.org> <0dced974-b507-ce48-b89d-344d41a02418@huawei.com> <87mtrodgn2.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <0af45a89-03cd-ac0d-9fa2-7f57eb828c86@huawei.com> Date: Thu, 17 Jun 2021 17:43:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87mtrodgn2.wl-maz@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme712-chm.china.huawei.com (10.1.199.108) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 2021/6/17 16:44, Marc Zyngier wrote: > On Thu, 17 Jun 2021 09:22:51 +0100, > "wangyanan (Y)" wrote: >> >> >> On 2021/6/17 16:03, Marc Zyngier wrote: >>> On Thu, 17 Jun 2021 07:48:29 +0100, >>> "wangyanan (Y)" wrote: >>>> Hi Marc, >>>> >>>> On 2021/6/16 21:21, Marc Zyngier wrote: >>>>> Hi Yanan, >>>>> >>>>> On Wed, 16 Jun 2021 10:51:57 +0100, >>>>> Yanan Wang wrote: >>>>>> To prepare for performing guest CMOs in the fault handlers in pgtable.c, >>>>>> introduce two cache maintenance callbacks in struct kvm_pgtable_mm_ops. >>>>>> >>>>>> The new callbacks are specific for guest stage-2, so they will only be >>>>>> initialized in 'struct kvm_pgtable_mm_ops kvm_s2_mm_ops'. >>>>>> >>>>>> Signed-off-by: Yanan Wang >>>>>> --- >>>>>> arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> index c3674c47d48c..302eca32e0af 100644 >>>>>> --- a/arch/arm64/include/asm/kvm_pgtable.h >>>>>> +++ b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> @@ -44,6 +44,11 @@ typedef u64 kvm_pte_t; >>>>>> * in the current context. >>>>>> * @virt_to_phys: Convert a virtual address mapped in the current context >>>>>> * into a physical address. >>>>>> + * @flush_dcache: Clean data cache for a guest page address range before >>>>>> + * creating the corresponding stage-2 mapping. >>>>> Please don't reintroduce the word 'flush'. We are really trying to >>>>> move away from it as it doesn't describe what we want to do. >>>> I agree with this. I intended to make the names short and laconic, but this >>>> missed the information about the callback's actual behaviors. >>>>> Here this >>>>> should be 'clean_invalidate_dcache' which, despite being a mouthful, >>>>> describe accurately what we expect it to do. >>>> Sure, I will change the name as you suggested. >>>>> The comment is also missing the invalidate part, and we shouldn't >>>>> assume that this is only used for S2 mapping. >>>> Ok, will refine the comment. I think something like"Clean and invalidate the >>>> date cache for the specified memory address range" may be generic enough. >>>>>> + * @flush_icache: Invalidate instruction cache for a guest page address >>>>>> + * range before creating or updating the corresponding >>>>>> + * stage-2 mapping. >>>>> Same thing here; this should be 'invalidate_icache', and the comment >>>>> cleaned up. >>>> Thanks, I will also correct this part. >>>> >>>> Besides the callback names and comments, is there anything else that still >>>> needs some adjustment in the other three patches? :) >>> It looks pretty good so far, much nicer than the previous versions. >>> >>> I have a small nit on the last patch, which should be dead easy to >>> address. I'm currently running a bunch of tests, hopefully nothing bad >>> will come out of it. >>> >>> If you respin it shortly, that nothing fails, and unless someone >>> shouts, I'll queue it for -next. >> It would be nice, thanks! >> I will address the nit and respin the series soon. > By the way, what the status of your selftest series that originally > came with this series? Are you planning to respin it? It would be > useful to have something that checks for regressions, and that series > did seem to do the trick. Actually they have already gone into upstream, since v5.13-rc1. :) The path is tools/testing/selftests/kvm/kvm_page_table_test.c, so it will be much convenient to test a 5.13 kernel, you can also have a try. I am using the original test data from v3 in the cover-letter because I think the test results will be almost the same with a different kernel. Thanks, Yanan . > Thanks, > > M. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A01EFC2B9F4 for ; Thu, 17 Jun 2021 09:43:36 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 1C02161209 for ; Thu, 17 Jun 2021 09:43:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C02161209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8D3BC4086A; Thu, 17 Jun 2021 05:43:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OR+tUWIuK3n5; Thu, 17 Jun 2021 05:43:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7E44840870; Thu, 17 Jun 2021 05:43:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 216C34083E for ; Thu, 17 Jun 2021 05:43:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id J+Dkc8F3Yiz0 for ; Thu, 17 Jun 2021 05:43:30 -0400 (EDT) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E0B1D4081C for ; Thu, 17 Jun 2021 05:43:29 -0400 (EDT) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G5H7w6kgSz6vT9; Thu, 17 Jun 2021 17:39:24 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:25 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:24 +0800 Subject: Re: [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2 To: Marc Zyngier References: <20210616095200.38008-1-wangyanan55@huawei.com> <20210616095200.38008-2-wangyanan55@huawei.com> <87eed2lzcc.wl-maz@kernel.org> <8340be12-cc80-8c2a-3597-ecba05eaf35a@huawei.com> <87o8c4dikn.wl-maz@kernel.org> <0dced974-b507-ce48-b89d-344d41a02418@huawei.com> <87mtrodgn2.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <0af45a89-03cd-ac0d-9fa2-7f57eb828c86@huawei.com> Date: Thu, 17 Jun 2021 17:43:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87mtrodgn2.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme712-chm.china.huawei.com (10.1.199.108) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Cc: kvm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Marc, On 2021/6/17 16:44, Marc Zyngier wrote: > On Thu, 17 Jun 2021 09:22:51 +0100, > "wangyanan (Y)" wrote: >> >> >> On 2021/6/17 16:03, Marc Zyngier wrote: >>> On Thu, 17 Jun 2021 07:48:29 +0100, >>> "wangyanan (Y)" wrote: >>>> Hi Marc, >>>> >>>> On 2021/6/16 21:21, Marc Zyngier wrote: >>>>> Hi Yanan, >>>>> >>>>> On Wed, 16 Jun 2021 10:51:57 +0100, >>>>> Yanan Wang wrote: >>>>>> To prepare for performing guest CMOs in the fault handlers in pgtable.c, >>>>>> introduce two cache maintenance callbacks in struct kvm_pgtable_mm_ops. >>>>>> >>>>>> The new callbacks are specific for guest stage-2, so they will only be >>>>>> initialized in 'struct kvm_pgtable_mm_ops kvm_s2_mm_ops'. >>>>>> >>>>>> Signed-off-by: Yanan Wang >>>>>> --- >>>>>> arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> index c3674c47d48c..302eca32e0af 100644 >>>>>> --- a/arch/arm64/include/asm/kvm_pgtable.h >>>>>> +++ b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> @@ -44,6 +44,11 @@ typedef u64 kvm_pte_t; >>>>>> * in the current context. >>>>>> * @virt_to_phys: Convert a virtual address mapped in the current context >>>>>> * into a physical address. >>>>>> + * @flush_dcache: Clean data cache for a guest page address range before >>>>>> + * creating the corresponding stage-2 mapping. >>>>> Please don't reintroduce the word 'flush'. We are really trying to >>>>> move away from it as it doesn't describe what we want to do. >>>> I agree with this. I intended to make the names short and laconic, but this >>>> missed the information about the callback's actual behaviors. >>>>> Here this >>>>> should be 'clean_invalidate_dcache' which, despite being a mouthful, >>>>> describe accurately what we expect it to do. >>>> Sure, I will change the name as you suggested. >>>>> The comment is also missing the invalidate part, and we shouldn't >>>>> assume that this is only used for S2 mapping. >>>> Ok, will refine the comment. I think something like"Clean and invalidate the >>>> date cache for the specified memory address range" may be generic enough. >>>>>> + * @flush_icache: Invalidate instruction cache for a guest page address >>>>>> + * range before creating or updating the corresponding >>>>>> + * stage-2 mapping. >>>>> Same thing here; this should be 'invalidate_icache', and the comment >>>>> cleaned up. >>>> Thanks, I will also correct this part. >>>> >>>> Besides the callback names and comments, is there anything else that still >>>> needs some adjustment in the other three patches? :) >>> It looks pretty good so far, much nicer than the previous versions. >>> >>> I have a small nit on the last patch, which should be dead easy to >>> address. I'm currently running a bunch of tests, hopefully nothing bad >>> will come out of it. >>> >>> If you respin it shortly, that nothing fails, and unless someone >>> shouts, I'll queue it for -next. >> It would be nice, thanks! >> I will address the nit and respin the series soon. > By the way, what the status of your selftest series that originally > came with this series? Are you planning to respin it? It would be > useful to have something that checks for regressions, and that series > did seem to do the trick. Actually they have already gone into upstream, since v5.13-rc1. :) The path is tools/testing/selftests/kvm/kvm_page_table_test.c, so it will be much convenient to test a 5.13 kernel, you can also have a try. I am using the original test data from v3 in the cover-letter because I think the test results will be almost the same with a different kernel. Thanks, Yanan . > Thanks, > > M. > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDFD7C2B9F4 for ; Thu, 17 Jun 2021 09:45:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7FB861209 for ; Thu, 17 Jun 2021 09:45:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7FB861209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LHJJBiXk7A8Ia74pI2ufq+CFdorxpjR4Jgw5VwiPEkY=; b=Ditxn1LZGSDXC+AdjEKtHCqVuU XT7pZ9TdYY2wteStI2wHFvsh0r6PRuD888PU69QPIWFEDVTBbL+J/qhZ7w9eBJbyNaDNAaC7ye4Vr xxnev0HDqpkHgd5aR64piOwv8fDlEIfJYTB5dXpkWSoUIS0oljAFT0icIHdBJEapEzjcBMPVSkmBL 2xmC6P6wYutMBdGkTAbTsEP15R1gBhvNetjWnTtlGuJukpRTCtVu+7RgI+PtnTORdIS1qVZRD3bnm RuVbRjmVdSZZSAHpBCywvg5Y1D6OB79tJh8FcvmiBNFd4YRUdxCa/l2gAyCi5m3PBApY+AhGQvXN9 DdxSLoIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltoYg-009hoK-MQ; Thu, 17 Jun 2021 09:43:34 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltoYc-009hnZ-Bv for linux-arm-kernel@lists.infradead.org; Thu, 17 Jun 2021 09:43:32 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4G5H7w6kgSz6vT9; Thu, 17 Jun 2021 17:39:24 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:25 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 17 Jun 2021 17:43:24 +0800 Subject: Re: [PATCH v6 1/4] KVM: arm64: Introduce cache maintenance callbacks for guest stage-2 To: Marc Zyngier CC: Will Deacon , Quentin Perret , Alexandru Elisei , , , , , Catalin Marinas , James Morse , Julien Thierry , Suzuki K Poulose , Gavin Shan , , , References: <20210616095200.38008-1-wangyanan55@huawei.com> <20210616095200.38008-2-wangyanan55@huawei.com> <87eed2lzcc.wl-maz@kernel.org> <8340be12-cc80-8c2a-3597-ecba05eaf35a@huawei.com> <87o8c4dikn.wl-maz@kernel.org> <0dced974-b507-ce48-b89d-344d41a02418@huawei.com> <87mtrodgn2.wl-maz@kernel.org> From: "wangyanan (Y)" Message-ID: <0af45a89-03cd-ac0d-9fa2-7f57eb828c86@huawei.com> Date: Thu, 17 Jun 2021 17:43:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87mtrodgn2.wl-maz@kernel.org> Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme712-chm.china.huawei.com (10.1.199.108) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210617_024330_816998_F3104386 X-CRM114-Status: GOOD ( 23.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, On 2021/6/17 16:44, Marc Zyngier wrote: > On Thu, 17 Jun 2021 09:22:51 +0100, > "wangyanan (Y)" wrote: >> >> >> On 2021/6/17 16:03, Marc Zyngier wrote: >>> On Thu, 17 Jun 2021 07:48:29 +0100, >>> "wangyanan (Y)" wrote: >>>> Hi Marc, >>>> >>>> On 2021/6/16 21:21, Marc Zyngier wrote: >>>>> Hi Yanan, >>>>> >>>>> On Wed, 16 Jun 2021 10:51:57 +0100, >>>>> Yanan Wang wrote: >>>>>> To prepare for performing guest CMOs in the fault handlers in pgtable.c, >>>>>> introduce two cache maintenance callbacks in struct kvm_pgtable_mm_ops. >>>>>> >>>>>> The new callbacks are specific for guest stage-2, so they will only be >>>>>> initialized in 'struct kvm_pgtable_mm_ops kvm_s2_mm_ops'. >>>>>> >>>>>> Signed-off-by: Yanan Wang >>>>>> --- >>>>>> arch/arm64/include/asm/kvm_pgtable.h | 7 +++++++ >>>>>> 1 file changed, 7 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/include/asm/kvm_pgtable.h b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> index c3674c47d48c..302eca32e0af 100644 >>>>>> --- a/arch/arm64/include/asm/kvm_pgtable.h >>>>>> +++ b/arch/arm64/include/asm/kvm_pgtable.h >>>>>> @@ -44,6 +44,11 @@ typedef u64 kvm_pte_t; >>>>>> * in the current context. >>>>>> * @virt_to_phys: Convert a virtual address mapped in the current context >>>>>> * into a physical address. >>>>>> + * @flush_dcache: Clean data cache for a guest page address range before >>>>>> + * creating the corresponding stage-2 mapping. >>>>> Please don't reintroduce the word 'flush'. We are really trying to >>>>> move away from it as it doesn't describe what we want to do. >>>> I agree with this. I intended to make the names short and laconic, but this >>>> missed the information about the callback's actual behaviors. >>>>> Here this >>>>> should be 'clean_invalidate_dcache' which, despite being a mouthful, >>>>> describe accurately what we expect it to do. >>>> Sure, I will change the name as you suggested. >>>>> The comment is also missing the invalidate part, and we shouldn't >>>>> assume that this is only used for S2 mapping. >>>> Ok, will refine the comment. I think something like"Clean and invalidate the >>>> date cache for the specified memory address range" may be generic enough. >>>>>> + * @flush_icache: Invalidate instruction cache for a guest page address >>>>>> + * range before creating or updating the corresponding >>>>>> + * stage-2 mapping. >>>>> Same thing here; this should be 'invalidate_icache', and the comment >>>>> cleaned up. >>>> Thanks, I will also correct this part. >>>> >>>> Besides the callback names and comments, is there anything else that still >>>> needs some adjustment in the other three patches? :) >>> It looks pretty good so far, much nicer than the previous versions. >>> >>> I have a small nit on the last patch, which should be dead easy to >>> address. I'm currently running a bunch of tests, hopefully nothing bad >>> will come out of it. >>> >>> If you respin it shortly, that nothing fails, and unless someone >>> shouts, I'll queue it for -next. >> It would be nice, thanks! >> I will address the nit and respin the series soon. > By the way, what the status of your selftest series that originally > came with this series? Are you planning to respin it? It would be > useful to have something that checks for regressions, and that series > did seem to do the trick. Actually they have already gone into upstream, since v5.13-rc1. :) The path is tools/testing/selftests/kvm/kvm_page_table_test.c, so it will be much convenient to test a 5.13 kernel, you can also have a try. I am using the original test data from v3 in the cover-letter because I think the test results will be almost the same with a different kernel. Thanks, Yanan . > Thanks, > > M. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel