From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF3ECC433EF for ; Fri, 4 Mar 2022 16:49:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A89091F04; Fri, 4 Mar 2022 17:48:11 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A89091F04 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646412541; bh=YCNLQ3eme71gVy6Ftb97jrI1BX/A1fiORCPLznZg5LU=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YnjfxQ+k3BVU2H9FYZS/bIg1GXbgmZSsjwkORuTrNxXQGelASnI6ZuIz7z3HMj8LW YGeW45+nNdLCA+Ybd/OvMMxsL5VdYRtgwCEC51x2OIoCzBwXm+16O5Vdkqz4X8ki3Q StRAtaqr1Dr7pz4Zdn5E/U5nzySRHVmXPt0CiPO4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 48750F800FA; Fri, 4 Mar 2022 17:48:11 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E952CF800F2; Fri, 4 Mar 2022 17:48:09 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6905AF800F2 for ; Fri, 4 Mar 2022 17:47:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6905AF800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="aUfVMU9h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646412484; x=1677948484; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=YCNLQ3eme71gVy6Ftb97jrI1BX/A1fiORCPLznZg5LU=; b=aUfVMU9hzveb5j7naUhukN545fTQXbXVEPuzmyMmYXmrlZ1vVc/C42bC 7eqJ92cFMMIq3k+XVNO9xdlohEUj7IZQ27G1W72clWoMmD/htC+XiYcz8 Q2FwokI8U3MVFhlHZARuQYDV9R3P4Vwe1hTZGnEkBXZf6UcWxU6IMs7zK gTS66GTZbaGdscj58MdU3MnLcFz36LcIxawb2NhR6BSwc6Bd439ZwXRCm 9WYeMj5nygXyLBsn5PidY94i/DzHSMNx5EIWn3dH+OWpGQoWaSMScY41A T90xHGingOsgjV1NfkJ32jfHmG61d120fhG9ul/mBTQ7pMZwt8TmgZllb Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10276"; a="253944456" X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="253944456" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 08:47:43 -0800 X-IronPort-AV: E=Sophos;i="5.90,155,1643702400"; d="scan'208";a="779682564" Received: from srstocke-mobl.amr.corp.intel.com ([10.251.130.3]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2022 08:47:43 -0800 Message-ID: <0afcd1f47073d84b2871a4dc2cb12754ff0d1a7e.camel@linux.intel.com> Subject: Re: [PATCH v3 13/17] ASoC: Intel: avs: Dynamic firmware resources management From: Ranjani Sridharan To: Cezary Rojewski , alsa-devel@alsa-project.org Date: Fri, 04 Mar 2022 08:47:43 -0800 In-Reply-To: <20220304145755.2844173-14-cezary.rojewski@intel.com> References: <20220304145755.2844173-1-cezary.rojewski@intel.com> <20220304145755.2844173-14-cezary.rojewski@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com, tiwai@suse.com, pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, 2022-03-04 at 15:57 +0100, Cezary Rojewski wrote: > Wrap elementary DSP-core operations and resource control into more > complex handlers. This is done to reduce the number of invocations of > wrapped operations throughout the driver as order of operations > matters - > most flows involve register manipulation and IPCs combined. > > Signed-off-by: Amadeusz Sławiński < > amadeuszx.slawinski@linux.intel.com> > Signed-off-by: Cezary Rojewski > --- > sound/soc/intel/avs/avs.h | 10 +++ > sound/soc/intel/avs/dsp.c | 170 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 180 insertions(+) > > diff --git a/sound/soc/intel/avs/avs.h b/sound/soc/intel/avs/avs.h > index 02d7591d0eac..0034c075fa64 100644 > --- a/sound/soc/intel/avs/avs.h > +++ b/sound/soc/intel/avs/avs.h > @@ -89,6 +89,7 @@ struct avs_dev { > struct mutex modres_mutex; > struct ida ppl_ida; > struct list_head fw_list; > + int *core_refs; Is this a per core ref_count? a comment or explicitly calling it core_ref_count would help. Thanks,Ranjani