From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: Re: [PATCH v2 05/11] ethdev: add probing finish function Date: Thu, 10 May 2018 13:37:20 +0300 Message-ID: <0b071bfa-29e0-b014-1991-ef500b870a07@solarflare.com> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-1-thomas@monjalon.net> <20180509224313.27289-6-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit To: Thomas Monjalon , Return-path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E18C61BA17 for ; Thu, 10 May 2018 12:37:30 +0200 (CEST) In-Reply-To: <20180509224313.27289-6-thomas@monjalon.net> Content-Language: en-GB List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > A new hook function is added and called inside the PMDs at the end > of the device probing: > - in primary process, after allocating, init and config > - in secondary process, after attaching and local init > > This new function is almost empty for now. > It will be used later to add some post-initialization processing. > > For the PMDs calling the helpers rte_eth_dev_create() or > rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish() > is called from here, and not in the PMD itself. > > Note that the helper rte_eth_dev_create() could be used more, > especially for vdevs, avoiding some code duplication in PMDs. > > Cc: stable@dpdk.org Why Cc? > Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko