From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06CC710F4 for ; Sun, 28 Jan 2024 01:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706405314; cv=none; b=r5eBgU+4lk/07cPLSwwSMDRnS7HOTpFp9yMjMNEDRVjH53MyK5S5Gu1b/OPqvNF7bMhB+GtLTgI9muyRBfFaLcTHYvqzTB8axJhlfO8NyH9PGwWq3eSlZoT//4hmprjlxee3xVOfTd3+mxHd7DaTm+kn40yyyebtjAan+YAKGqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706405314; c=relaxed/simple; bh=+4n89C+gEBtsQDw1jUm0K1mb6NFfpf8Q6IFymcXODF4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BD7z5VTrQGkGADBhcms8mLrH38xzj+VJXarU8unfKhl491nSTJVz7SiYFV26dKH/XKaZC/b8s4gEMhncFDuadBSoqNsQIh6qqCgyiCFthoZi+fHcAw3dmauq3L7YKJVJfg9Co6EGx0P+t6hQDVE86iKGiljl9zUgEjfZ/JLnSVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NovSLQRI; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NovSLQRI" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40e8fec0968so26177335e9.1 for ; Sat, 27 Jan 2024 17:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706405311; x=1707010111; darn=lists.linux.dev; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=NovSLQRINfxKPQK9KlT7w96DDiLvbUW/byIDvwlBNKx1KMkiHHeF3AQxFKQBGN7Eru 2ciyodLVoNA+fvrliQaSwK26ZWw1qg9YZr7KcYmGbqzzPR4XgJ5XqSlgTF9bnvfnpfhE gu2McYY1bb28K97SrnsEpqs2IdYNFKoZBjGhk4+0NOS2gzXcH+7BoTPYPU/sfftc8/+o WMHjSYcYxxCAK0AKMoel2u4mXfTxh7aSIoU/SdjLrQf6pvExeZFaPmeZzY3SaekQyBRZ /clzJbTytOfRUPmIF264jYGjsabWuCQ+jUlmGiYDKifOzz++XXWm6ChTtaOfnHFmGIHU nKMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706405311; x=1707010111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=Zcm454uKxBImW6NPU+axDmQuMPbHXNGS9EZ7sheGuJLma/1OnAupz4txz08YADq+Iy pc23lBmGCop55KRCzq5Qk5Mfws70rnXyMd1979uEbWdKBMKQ3cuYBQbEG6dnZ0UPByN9 k7gB/SD7xor0k/yvYxQiztNi68AJNtguueU2vCI8LeXCbWfGadCDJ8LGm4uLff64ZqiG 98p65JvCNTLXIyDS+v/4eT0UgwyGfB+I+7mPE++fzbtAn5Q1kntuBwwqQ2LJqjxcMwED XWZ+IgQRhMuGuoYY3BdN/4hJB/hrA+FpB6MwYh6zJblDDtjCsPBc9xlXAkGhtCVW0yo+ b7Cw== X-Gm-Message-State: AOJu0YzEMecWxnJpyPLiICmyAM58lQBPyets7EkWQtg/naOsiufGiNxd agwksents8ryi/yhKzCXtKnnTdR/933vW7H73BJerktT6CIBKUut X-Google-Smtp-Source: AGHT+IHept3nMUj4LCYzYJiT9LNHHbS9INXuvww5u4glPmCjjXCtKxmvIBnhSwXHbRZoEWgm1HAkmA== X-Received: by 2002:a05:600c:1396:b0:40e:a569:3555 with SMTP id u22-20020a05600c139600b0040ea5693555mr2037091wmf.35.1706405310998; Sat, 27 Jan 2024 17:28:30 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1204:db7b:6df3:1a86:f66a? (soda.int.kasm.eu. [2001:678:a5c:1204:db7b:6df3:1a86:f66a]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040ee76ae773sm4537228wms.19.2024.01.27.17.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 17:28:30 -0800 (PST) Message-ID: <0b14826b-9373-4458-919d-1da2a62d4226@gmail.com> Date: Sun, 28 Jan 2024 02:28:28 +0100 Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Content-Language: en-US, sv-SE To: Baoquan He , linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, akpm@linux-foundation.org, ebiederm@xmission.com, hbathini@linux.ibm.com, piliu@redhat.com, viro@zeniv.linux.org.uk References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-2-bhe@redhat.com> From: Klara Modin In-Reply-To: <20240124051254.67105-2-bhe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 2024-01-24 06:12, Baoquan He wrote: > And also add config item CRASH_RESERVE to control its enabling of the > codes. And update config items which has relationship with crashkernel > reservation. > > And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE > when those scopes are only crashkernel reservation related. > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 502986237cb6..a9243e0948a3 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG > def_bool y > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > - def_bool CRASH_CORE > + def_bool CRASH_RESEERVE > > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP) CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my .config and `crashkernel=...` parameter has no effect). Kind regards, Klara Modin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C452C46CD2 for ; Sun, 28 Jan 2024 01:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bvwHnollQ3Wl9quechwtydDeeKH6q0eNt2ghuJ5WRkg=; b=HF5YW3k/mYExxu 3uBYl0KuYMKm1bILdnrRqqZcvySssL7ZLwsnVkiIPqdPVGXIa8UaHRzqUBuMZznlIh/E5jqxCNgit ZRA+hz1xrJRylKlqujmnniFzwPte24fcLbeoBrOm2PUisuvVv0bqfLnRuSRx9ga0MGytNkp4sDr2F LY2M5PnvRd+fznjq+UMckevn47ogb0bM8Wa0ayn+B2YjyD+4v9uT2+J8ty1DstLsL+vm/SaknwF2c PO34gL+itxFCbV7x1uYvbJJY2cCAcmwrxMxfD1YkDPlrtHj5A7QVhFvhkzWcd3jNVJI9tqpnwCihx xQe4mDQiFKMYYVPK4ABQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyR-00000008XP9-2Z8f; Sun, 28 Jan 2024 01:28:39 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyN-00000008XNk-09JL; Sun, 28 Jan 2024 01:28:36 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e86a9fc4bso26116695e9.2; Sat, 27 Jan 2024 17:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706405311; x=1707010111; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=RECg+THo0Le+e/2Bx3tVVGcuXDH+LmTokESV6748hAvFMIrhEc9Wq3KERHxklf8y9h QOvDqpijESggIXpJgqMRRAiXJAkBJXjR1SOnA60mak8VL6nqMcWNq8jd6n0lDzAIQhbh pPGUo5D3rqOBWWBfBf7yTbLAs6S1RhyPXe/i8lFpOhBSQP3Pinf6lUHN2C/a8G7LYSIA 1XJzxUqGhwZy6PBabLWWbhyMQpfYYZaQSAQzl6o3JG0YgmDsBVO+N2s/6edhO6iJ3jgt hmaU4FmuGc81SqcPnFyP7aNdP7gwOG4dIDOgISaOkzRwV7I6cBb3aKIPktiZYSg+YYwn +RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706405311; x=1707010111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=OaVR/hbIREVpIyOFULxHfM7Y1X4dQxx87gnkpIPfytPp1QR6eICYCeunBcdc6i2hVj 15mQ9w7axAIyZcixb1Nm5b74xZQuL5JmGBqx6c9CXA/Ze+lTdl7KlrOq5a2QyGb5Odli 7BANNGZiPgLJssML2Ra6H+U0KE3Nmft7OmqJwcA5JGpmznBHvfdddUuvUzaa0C6adVeb xXlGcPJFGpCQqpb+DSsnDVMt6+PaKbEbLBxt+hjLEd90mcw9PMpTria5qBizCXyB5GQc wBuDeTzPLcEHInvyg+By0AyA10R2ZekIIeJWtjzbwsixMomnAnhX6SwNoav3AMLGPKHi DWvw== X-Gm-Message-State: AOJu0Yw+gCNIQvbsQ2GGsziVGceKyxm/2MCQ/xFvhNkUncCGlujCIqd2 PQYLO9eYvA4l4oaZhHLC1oQGi+r31MMxuh4v1BG6U4SB7J/JMGaN X-Google-Smtp-Source: AGHT+IHept3nMUj4LCYzYJiT9LNHHbS9INXuvww5u4glPmCjjXCtKxmvIBnhSwXHbRZoEWgm1HAkmA== X-Received: by 2002:a05:600c:1396:b0:40e:a569:3555 with SMTP id u22-20020a05600c139600b0040ea5693555mr2037091wmf.35.1706405310998; Sat, 27 Jan 2024 17:28:30 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1204:db7b:6df3:1a86:f66a? (soda.int.kasm.eu. [2001:678:a5c:1204:db7b:6df3:1a86:f66a]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040ee76ae773sm4537228wms.19.2024.01.27.17.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 17:28:30 -0800 (PST) Message-ID: <0b14826b-9373-4458-919d-1da2a62d4226@gmail.com> Date: Sun, 28 Jan 2024 02:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Content-Language: en-US, sv-SE To: Baoquan He , linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, akpm@linux-foundation.org, ebiederm@xmission.com, hbathini@linux.ibm.com, piliu@redhat.com, viro@zeniv.linux.org.uk References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-2-bhe@redhat.com> From: Klara Modin In-Reply-To: <20240124051254.67105-2-bhe@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_172835_118961_FB77F842 X-CRM114-Status: UNSURE ( 8.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi, On 2024-01-24 06:12, Baoquan He wrote: > And also add config item CRASH_RESERVE to control its enabling of the > codes. And update config items which has relationship with crashkernel > reservation. > > And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE > when those scopes are only crashkernel reservation related. > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 502986237cb6..a9243e0948a3 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG > def_bool y > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > - def_bool CRASH_CORE > + def_bool CRASH_RESEERVE > > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP) CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my .config and `crashkernel=...` parameter has no effect). Kind regards, Klara Modin _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B940C46CD2 for ; Sun, 28 Jan 2024 01:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3/xVXgGOnWN6rsuI5toNFwAgQ+nhrR4iLBj99dziUok=; b=oV+GnXf8LM2c43 nLI38+YZFT2BVY100yXQNYu60yTiCTkVtc3ipLRjaXAIxnhizKia0hcYhED91m0/HnejXTmyH3PuD vd1uJQt4wmDDNPkDmZTjeUOg36Os6Jyt5YfTAmy/Dl4eehVVhLW9/TJLeYqaxhVwIYAp6FEHwZwQu 7jJvNwhWyCamoN2AHA+iX5tGxCoVmGZ+jDHHNUvhCoSkJ2GdXj2vYTGKnlvCVkKOyb7hkz739oNLp VuATnnSfSWiep3Ynj+dEHUxEK8s80sYI+gKiGhWtRftnoASVCrnW1K1feRzsCeXOZHaOwGt/PTmct 3pIXC0Wd1I3p6BdWs5BQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyQ-00000008XP3-3nKQ; Sun, 28 Jan 2024 01:28:38 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyN-00000008XNk-09JL; Sun, 28 Jan 2024 01:28:36 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e86a9fc4bso26116695e9.2; Sat, 27 Jan 2024 17:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706405311; x=1707010111; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=RECg+THo0Le+e/2Bx3tVVGcuXDH+LmTokESV6748hAvFMIrhEc9Wq3KERHxklf8y9h QOvDqpijESggIXpJgqMRRAiXJAkBJXjR1SOnA60mak8VL6nqMcWNq8jd6n0lDzAIQhbh pPGUo5D3rqOBWWBfBf7yTbLAs6S1RhyPXe/i8lFpOhBSQP3Pinf6lUHN2C/a8G7LYSIA 1XJzxUqGhwZy6PBabLWWbhyMQpfYYZaQSAQzl6o3JG0YgmDsBVO+N2s/6edhO6iJ3jgt hmaU4FmuGc81SqcPnFyP7aNdP7gwOG4dIDOgISaOkzRwV7I6cBb3aKIPktiZYSg+YYwn +RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706405311; x=1707010111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=OaVR/hbIREVpIyOFULxHfM7Y1X4dQxx87gnkpIPfytPp1QR6eICYCeunBcdc6i2hVj 15mQ9w7axAIyZcixb1Nm5b74xZQuL5JmGBqx6c9CXA/Ze+lTdl7KlrOq5a2QyGb5Odli 7BANNGZiPgLJssML2Ra6H+U0KE3Nmft7OmqJwcA5JGpmznBHvfdddUuvUzaa0C6adVeb xXlGcPJFGpCQqpb+DSsnDVMt6+PaKbEbLBxt+hjLEd90mcw9PMpTria5qBizCXyB5GQc wBuDeTzPLcEHInvyg+By0AyA10R2ZekIIeJWtjzbwsixMomnAnhX6SwNoav3AMLGPKHi DWvw== X-Gm-Message-State: AOJu0Yw+gCNIQvbsQ2GGsziVGceKyxm/2MCQ/xFvhNkUncCGlujCIqd2 PQYLO9eYvA4l4oaZhHLC1oQGi+r31MMxuh4v1BG6U4SB7J/JMGaN X-Google-Smtp-Source: AGHT+IHept3nMUj4LCYzYJiT9LNHHbS9INXuvww5u4glPmCjjXCtKxmvIBnhSwXHbRZoEWgm1HAkmA== X-Received: by 2002:a05:600c:1396:b0:40e:a569:3555 with SMTP id u22-20020a05600c139600b0040ea5693555mr2037091wmf.35.1706405310998; Sat, 27 Jan 2024 17:28:30 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1204:db7b:6df3:1a86:f66a? (soda.int.kasm.eu. [2001:678:a5c:1204:db7b:6df3:1a86:f66a]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040ee76ae773sm4537228wms.19.2024.01.27.17.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 17:28:30 -0800 (PST) Message-ID: <0b14826b-9373-4458-919d-1da2a62d4226@gmail.com> Date: Sun, 28 Jan 2024 02:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Content-Language: en-US, sv-SE To: Baoquan He , linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, akpm@linux-foundation.org, ebiederm@xmission.com, hbathini@linux.ibm.com, piliu@redhat.com, viro@zeniv.linux.org.uk References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-2-bhe@redhat.com> From: Klara Modin In-Reply-To: <20240124051254.67105-2-bhe@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_172835_118961_FB77F842 X-CRM114-Status: UNSURE ( 8.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 2024-01-24 06:12, Baoquan He wrote: > And also add config item CRASH_RESERVE to control its enabling of the > codes. And update config items which has relationship with crashkernel > reservation. > > And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE > when those scopes are only crashkernel reservation related. > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 502986237cb6..a9243e0948a3 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG > def_bool y > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > - def_bool CRASH_CORE > + def_bool CRASH_RESEERVE > > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP) CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my .config and `crashkernel=...` parameter has no effect). Kind regards, Klara Modin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2829C46CD2 for ; Sun, 28 Jan 2024 01:28:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SNKfr+uMA0Y4b6zz4q0aE8/c8ClD91rjzlOYWBEME9c=; b=gs87QIRk3FE4OV TVOcFs7dORaSLAbLVE0tbfIqKqsSkg6DmgrzANwk2yk0nTuKwtm56L27YdODkrdIe42BF10pRTAis WBJI6mMnfQtDoqYQHHQRYX1sQH4vEvDpm54H6ufSxyJ5JDwfm/IJER/8IdUXcVFSJIMlBofqMBq18 MCTDHf5I/C4/AhgJ9tPte6ImcS0G8Uag41lElZn0qeWLFege9deqoRLUExs43wjTD3OzmvQmSQ4U2 DW0r3qSyUbagELhBgan+Z6VAsehiy3UJIcofoItZXakjT89h306wsWpjpwI3QJUbi7ElddGoxZ2yZ NJHLHTLdhQwkMdnM59nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyQ-00000008XOk-1qP1; Sun, 28 Jan 2024 01:28:38 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTtyN-00000008XNk-09JL; Sun, 28 Jan 2024 01:28:36 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40e86a9fc4bso26116695e9.2; Sat, 27 Jan 2024 17:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706405311; x=1707010111; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=RECg+THo0Le+e/2Bx3tVVGcuXDH+LmTokESV6748hAvFMIrhEc9Wq3KERHxklf8y9h QOvDqpijESggIXpJgqMRRAiXJAkBJXjR1SOnA60mak8VL6nqMcWNq8jd6n0lDzAIQhbh pPGUo5D3rqOBWWBfBf7yTbLAs6S1RhyPXe/i8lFpOhBSQP3Pinf6lUHN2C/a8G7LYSIA 1XJzxUqGhwZy6PBabLWWbhyMQpfYYZaQSAQzl6o3JG0YgmDsBVO+N2s/6edhO6iJ3jgt hmaU4FmuGc81SqcPnFyP7aNdP7gwOG4dIDOgISaOkzRwV7I6cBb3aKIPktiZYSg+YYwn +RZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706405311; x=1707010111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=OaVR/hbIREVpIyOFULxHfM7Y1X4dQxx87gnkpIPfytPp1QR6eICYCeunBcdc6i2hVj 15mQ9w7axAIyZcixb1Nm5b74xZQuL5JmGBqx6c9CXA/Ze+lTdl7KlrOq5a2QyGb5Odli 7BANNGZiPgLJssML2Ra6H+U0KE3Nmft7OmqJwcA5JGpmznBHvfdddUuvUzaa0C6adVeb xXlGcPJFGpCQqpb+DSsnDVMt6+PaKbEbLBxt+hjLEd90mcw9PMpTria5qBizCXyB5GQc wBuDeTzPLcEHInvyg+By0AyA10R2ZekIIeJWtjzbwsixMomnAnhX6SwNoav3AMLGPKHi DWvw== X-Gm-Message-State: AOJu0Yw+gCNIQvbsQ2GGsziVGceKyxm/2MCQ/xFvhNkUncCGlujCIqd2 PQYLO9eYvA4l4oaZhHLC1oQGi+r31MMxuh4v1BG6U4SB7J/JMGaN X-Google-Smtp-Source: AGHT+IHept3nMUj4LCYzYJiT9LNHHbS9INXuvww5u4glPmCjjXCtKxmvIBnhSwXHbRZoEWgm1HAkmA== X-Received: by 2002:a05:600c:1396:b0:40e:a569:3555 with SMTP id u22-20020a05600c139600b0040ea5693555mr2037091wmf.35.1706405310998; Sat, 27 Jan 2024 17:28:30 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1204:db7b:6df3:1a86:f66a? (soda.int.kasm.eu. [2001:678:a5c:1204:db7b:6df3:1a86:f66a]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040ee76ae773sm4537228wms.19.2024.01.27.17.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 17:28:30 -0800 (PST) Message-ID: <0b14826b-9373-4458-919d-1da2a62d4226@gmail.com> Date: Sun, 28 Jan 2024 02:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Content-Language: en-US, sv-SE To: Baoquan He , linux-kernel@vger.kernel.org Cc: kexec@lists.infradead.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, akpm@linux-foundation.org, ebiederm@xmission.com, hbathini@linux.ibm.com, piliu@redhat.com, viro@zeniv.linux.org.uk References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-2-bhe@redhat.com> From: Klara Modin In-Reply-To: <20240124051254.67105-2-bhe@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_172835_118961_FB77F842 X-CRM114-Status: UNSURE ( 8.28 ) X-CRM114-Notice: Please train this message. X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org Hi, On 2024-01-24 06:12, Baoquan He wrote: > And also add config item CRASH_RESERVE to control its enabling of the > codes. And update config items which has relationship with crashkernel > reservation. > > And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE > when those scopes are only crashkernel reservation related. > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 502986237cb6..a9243e0948a3 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG > def_bool y > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > - def_bool CRASH_CORE > + def_bool CRASH_RESEERVE > > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP) CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my .config and `crashkernel=...` parameter has no effect). Kind regards, Klara Modin _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10A6DC47258 for ; Sun, 28 Jan 2024 18:52:30 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JNb2N6eo; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TNLCK1q0lz3cTt for ; Mon, 29 Jan 2024 05:52:29 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=JNb2N6eo; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::333; helo=mail-wm1-x333.google.com; envelope-from=klarasmodin@gmail.com; receiver=lists.ozlabs.org) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TMv2w1rSnz3bmN for ; Sun, 28 Jan 2024 12:28:38 +1100 (AEDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40ef5316e01so440665e9.3 for ; Sat, 27 Jan 2024 17:28:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706405311; x=1707010111; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=JNb2N6eonrBZJYKNW95KMpytxXwVnQDQFSgoB+Z2d4OhNPexBPWn6zCVaL16sX3WFC VSRmhCa4CPymm4igeDNPsTGp/OMcAp9kcQabX0TGiutcSZ0L4m9JJA/IIUjGvNZWtnQb AE958B4+W57CIDJjPOQ2HJr6DTRUMaPgfspEb3uFl8MmSF5jIo/jYMxo5ex7xbrzyU1J iT+WQBLhTOpdI9cn0GlHQhuQOms+dfVGsAOvH8Qg0ocYSrBgJ20U11rcnJYk9bM95Jg9 sMUoQEbzv27N3VsIwFWP8MoIwaXm3BTgWuC0rCJxhdQsQuoqdbnhvx/Tn8xgmKlOnJF+ 9l+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706405311; x=1707010111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oUXUIxIBKb7yXVS8ERVW4fwa4sKRyx0T69mWwoqQkWg=; b=f2ng6Y/oxFFpkTBO6n4C+ebHd5BBVWTs27i2XD+X98lqLYbTiGSAgLNJwfJC71kTct F3mC66lmJKiPqliVJdFNvyIKc9HXwzwqm1WCZf1rYg7ITqAweFtuBbpAEN4vCCJDPBQ5 1/c7v6MBJV47e3JEZaAEP1WVSCwpe8bDapIHPF0gR7F+arr4gqwDeCFB+4ycN8p9la9l uwiVqx0rZUzzarsb7G2FBXHRrW6l0BA+qCGBh9NHZH7iGLAN2HGZmjnRsNMWyd85vszK Y7p1NMHH79VgTq15150TtIOsMiuHEmu7LuDQvGgJXYOn9WJ9qK+hRAGwgqrB4O756qd+ u2qg== X-Gm-Message-State: AOJu0YyuzgflSm7OiKfFWUmmox6vIUeEkPvMZvL3mVy9/Nlgdh55+Yhf j9Rtr/3a3INt5T/E1AlzuIB70k9LJvv32UCbxabgRJg0RFkWyv1A X-Google-Smtp-Source: AGHT+IHept3nMUj4LCYzYJiT9LNHHbS9INXuvww5u4glPmCjjXCtKxmvIBnhSwXHbRZoEWgm1HAkmA== X-Received: by 2002:a05:600c:1396:b0:40e:a569:3555 with SMTP id u22-20020a05600c139600b0040ea5693555mr2037091wmf.35.1706405310998; Sat, 27 Jan 2024 17:28:30 -0800 (PST) Received: from ?IPV6:2001:678:a5c:1204:db7b:6df3:1a86:f66a? (soda.int.kasm.eu. [2001:678:a5c:1204:db7b:6df3:1a86:f66a]) by smtp.gmail.com with ESMTPSA id p6-20020a05600c1d8600b0040ee76ae773sm4537228wms.19.2024.01.27.17.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 27 Jan 2024 17:28:30 -0800 (PST) Message-ID: <0b14826b-9373-4458-919d-1da2a62d4226@gmail.com> Date: Sun, 28 Jan 2024 02:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Content-Language: en-US, sv-SE To: Baoquan He , linux-kernel@vger.kernel.org References: <20240124051254.67105-1-bhe@redhat.com> <20240124051254.67105-2-bhe@redhat.com> From: Klara Modin In-Reply-To: <20240124051254.67105-2-bhe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 29 Jan 2024 05:51:46 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, piliu@redhat.com, linux-sh@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-mips@vger.kernel.org, ebiederm@xmission.com, loongarch@lists.linux.dev, hbathini@linux.ibm.com, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org, viro@zeniv.linux.org.uk Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On 2024-01-24 06:12, Baoquan He wrote: > And also add config item CRASH_RESERVE to control its enabling of the > codes. And update config items which has relationship with crashkernel > reservation. > > And also change ifdeffery from CONFIG_CRASH_CORE to CONFIG_CRASH_RESERVE > when those scopes are only crashkernel reservation related. > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 502986237cb6..a9243e0948a3 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2106,7 +2106,7 @@ config ARCH_SUPPORTS_CRASH_HOTPLUG > def_bool y > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > - def_bool CRASH_CORE > + def_bool CRASH_RESEERVE > > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if (EXPERT || CRASH_DUMP) CRASH_RESEERVE is probably a typo and should be CRASH_RESERVE (with the former ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION isn't defined in my .config and `crashkernel=...` parameter has no effect). Kind regards, Klara Modin