From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 434B220E0 for ; Wed, 4 May 2022 02:18:19 +0000 (UTC) Received: by mail-pg1-f172.google.com with SMTP id a191so66719pge.2 for ; Tue, 03 May 2022 19:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=oRTJFa40kHEh7n+tr3P07b1F40qTa0npYYEBgfPr++w=; b=n/0q8ggAw/ULQhiaru0IV3uK2w+sdISkFouZ1TEhbqIcrsZxTnBxvgzZXKMtWCK5gf cRbvr41Ie/Dz1d6ZSbVSxXS8ghz15CLo7dmzdO1hR1aVz6BCDd9NLKdYbpXpySsPZ4yg +elIiZRfRerfPmK+ESdtpIxNLDywj4X4dwyW+IL69pF4x2fypmlL5aZycoCU8iSUSQ2j 85xi7aRskoAA5rgZAQCgK06QjKUD61do2Qu28KqDLLKSLIJHksYlULKSMIJ6mG8WfUBd dtpHtYo5MmRbRA+k0o5YH6fp7dkQS2uhJQST9DN6bz/fts85PKiiPjse/lPOas8qsAt8 2aiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oRTJFa40kHEh7n+tr3P07b1F40qTa0npYYEBgfPr++w=; b=gLQrC+fZSwnaG+geDKx8d2idoih0unDq4Q7BFtYXT6tQ5wimzXBn6vQHaOD6YDYR4s wxPqJQ5MjGC2GZJjOJoer7lDMXDdvik0+LCOpuo1xrDp67WwGUvgXRj8iQWPHeE4Qu2O qO+c4Chg4towd+aqlaMR5igBEV1+KFF5q6KO9KKZBsFZ+jXn6n+UbSlJPHMotAPof6a5 LwZ4GsDNtWbtRC4oxu8V1UzstrapOdZ2vjr79f5y4ODb6QqJ1H3A3elZPMiRFaKRFwZA Hkcn6e2RiVDSdGpoqrD7yy35IDLwA47n0VyRzH/HqV5uZ4UFvppSrAq5UQqqPuVBApl8 RJBg== X-Gm-Message-State: AOAM532Obv8pXMuTj3vHGuKHPKGbOfG045yIdWRZBTWNioYizX1BeIrT rNKANY3iAln9GqoLXiR4baw1yQ== X-Google-Smtp-Source: ABdhPJxU0wXZroQ6HfCO+s6K0BJhScDxfmzFomW6S3SzG3CgbjBZpzrMge6CMRgp7CAdqn4/FP3RXA== X-Received: by 2002:a63:1b5e:0:b0:3aa:593c:9392 with SMTP id b30-20020a631b5e000000b003aa593c9392mr16086048pgm.470.1651630699497; Tue, 03 May 2022 19:18:19 -0700 (PDT) Received: from [10.61.2.177] (110-175-254-242.static.tpgi.com.au. [110.175.254.242]) by smtp.gmail.com with ESMTPSA id q26-20020a63505a000000b003aa8b87feb5sm13968274pgl.0.2022.05.03.19.18.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 19:18:18 -0700 (PDT) Message-ID: <0b2a1361-e0a4-35b2-c58d-ef4b913c025e@ozlabs.ru> Date: Wed, 4 May 2022 12:18:13 +1000 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Subject: Re: [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds Content-Language: en-US To: Nick Desaulniers Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Nicholas Piggin , Nathan Chancellor , Michael Ellerman , Sathvika Vasireddy , Russell Currey , "Naveen N . Rao" , Sami Tolvanen References: <20220429064547.2334280-1-aik@ozlabs.ru> From: Alexey Kardashevskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/4/22 07:24, Nick Desaulniers wrote: > On Thu, Apr 28, 2022 at 11:46 PM Alexey Kardashevskiy wrote: >> >> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S >> index b66dd6f775a4..5b783bd51260 100644 >> --- a/arch/powerpc/kernel/exceptions-64s.S >> +++ b/arch/powerpc/kernel/exceptions-64s.S >> @@ -476,9 +476,11 @@ DEFINE_FIXED_SYMBOL(\name\()_common_real, text) >> .if IHSRR_IF_HVMODE >> BEGIN_FTR_SECTION >> bne masked_Hinterrupt >> + b 4f >> FTR_SECTION_ELSE > > Do you need to have the ELSE even if there's nothing in it; should it > have a nop? The rest of the assembler changes LGTM, but withholding > RB tag until we have Kconfig dependencies in better shape. The FTR patcher will add the necessary amount of "nop"s there and dropping "FTR_SECTION_ELSE" breaks the build as it does some "pushsection" magic. > >> - bne masked_interrupt >> ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206) >> + bne masked_interrupt >> +4: >> .elseif IHSRR >> bne masked_Hinterrupt >> .else > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B931CC433EF for ; Wed, 4 May 2022 02:19:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KtL9k0j1Tz3bvl for ; Wed, 4 May 2022 12:19:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ozlabs-ru.20210112.gappssmtp.com header.i=@ozlabs-ru.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=n/0q8ggA; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.ru (client-ip=2607:f8b0:4864:20::52b; helo=mail-pg1-x52b.google.com; envelope-from=aik@ozlabs.ru; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ozlabs-ru.20210112.gappssmtp.com header.i=@ozlabs-ru.20210112.gappssmtp.com header.a=rsa-sha256 header.s=20210112 header.b=n/0q8ggA; dkim-atps=neutral Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KtL8z0208z2xt0 for ; Wed, 4 May 2022 12:18:23 +1000 (AEST) Received: by mail-pg1-x52b.google.com with SMTP id 7so40519pga.12 for ; Tue, 03 May 2022 19:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ozlabs-ru.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=oRTJFa40kHEh7n+tr3P07b1F40qTa0npYYEBgfPr++w=; b=n/0q8ggAw/ULQhiaru0IV3uK2w+sdISkFouZ1TEhbqIcrsZxTnBxvgzZXKMtWCK5gf cRbvr41Ie/Dz1d6ZSbVSxXS8ghz15CLo7dmzdO1hR1aVz6BCDd9NLKdYbpXpySsPZ4yg +elIiZRfRerfPmK+ESdtpIxNLDywj4X4dwyW+IL69pF4x2fypmlL5aZycoCU8iSUSQ2j 85xi7aRskoAA5rgZAQCgK06QjKUD61do2Qu28KqDLLKSLIJHksYlULKSMIJ6mG8WfUBd dtpHtYo5MmRbRA+k0o5YH6fp7dkQS2uhJQST9DN6bz/fts85PKiiPjse/lPOas8qsAt8 2aiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=oRTJFa40kHEh7n+tr3P07b1F40qTa0npYYEBgfPr++w=; b=kSwbFCSH5N9R+rCCfSpNO1msH6lwSJDQ+HJNtnhht5LSOLCr0ZeOdo47hkrImwNCgv FuFC+4K4DWqOZySPFY1N/pcN/NHFDLjoV1pkrOojetU1MFJVqGjEAb/R0Cx9wz8eJfnM vI1HIAHPtROSJ80Z96pQ3540c+2G/oF2qX+RZQE4FfwAomXBn8wfMcRFOeVtNS5LgSYh XSVSJ3Bd8tBp8o7yHqBormwErbeBKctFbmPdfKiivoYsQVT6q4x+iYECV9utyc2lqQY4 OxXjLJZcPK9QvUnMABZ2R91SlTKQ/U5i7cmz7escRhebk8PP/HY6bZpd2Skx14seasZT gvbQ== X-Gm-Message-State: AOAM532VtZoPzQ9iE4Ya0ehxCVwEe9wWXr/pN4u2TuGdREtZK/YPe/ev dcFHFTbbtOo0i1dFFTG0/IGH+A== X-Google-Smtp-Source: ABdhPJxU0wXZroQ6HfCO+s6K0BJhScDxfmzFomW6S3SzG3CgbjBZpzrMge6CMRgp7CAdqn4/FP3RXA== X-Received: by 2002:a63:1b5e:0:b0:3aa:593c:9392 with SMTP id b30-20020a631b5e000000b003aa593c9392mr16086048pgm.470.1651630699497; Tue, 03 May 2022 19:18:19 -0700 (PDT) Received: from [10.61.2.177] (110-175-254-242.static.tpgi.com.au. [110.175.254.242]) by smtp.gmail.com with ESMTPSA id q26-20020a63505a000000b003aa8b87feb5sm13968274pgl.0.2022.05.03.19.18.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 19:18:18 -0700 (PDT) Message-ID: <0b2a1361-e0a4-35b2-c58d-ef4b913c025e@ozlabs.ru> Date: Wed, 4 May 2022 12:18:13 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Subject: Re: [PATCH kernel] powerpc/llvm/lto: Allow LLVM LTO builds Content-Language: en-US To: Nick Desaulniers References: <20220429064547.2334280-1-aik@ozlabs.ru> From: Alexey Kardashevskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: llvm@lists.linux.dev, Nicholas Piggin , Nathan Chancellor , Sathvika Vasireddy , Sami Tolvanen , "Naveen N . Rao" , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 5/4/22 07:24, Nick Desaulniers wrote: > On Thu, Apr 28, 2022 at 11:46 PM Alexey Kardashevskiy wrote: >> >> diff --git a/arch/powerpc/kernel/exceptions-64s.S b/arch/powerpc/kernel/exceptions-64s.S >> index b66dd6f775a4..5b783bd51260 100644 >> --- a/arch/powerpc/kernel/exceptions-64s.S >> +++ b/arch/powerpc/kernel/exceptions-64s.S >> @@ -476,9 +476,11 @@ DEFINE_FIXED_SYMBOL(\name\()_common_real, text) >> .if IHSRR_IF_HVMODE >> BEGIN_FTR_SECTION >> bne masked_Hinterrupt >> + b 4f >> FTR_SECTION_ELSE > > Do you need to have the ELSE even if there's nothing in it; should it > have a nop? The rest of the assembler changes LGTM, but withholding > RB tag until we have Kconfig dependencies in better shape. The FTR patcher will add the necessary amount of "nop"s there and dropping "FTR_SECTION_ELSE" breaks the build as it does some "pushsection" magic. > >> - bne masked_interrupt >> ALT_FTR_SECTION_END_IFSET(CPU_FTR_HVMODE | CPU_FTR_ARCH_206) >> + bne masked_interrupt >> +4: >> .elseif IHSRR >> bne masked_Hinterrupt >> .else >