From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Subject: Re: [PATCH 03/16] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 Date: Tue, 21 Jul 2020 11:17:53 +0800 Message-ID: <0b2fbd84-2ee3-5a8b-7a33-d9fab2160e16@rock-chips.com> References: <20200720185120.671064-1-jagan@amarulasolutions.com> <20200720185120.671064-4-jagan@amarulasolutions.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200720185120.671064-4-jagan@amarulasolutions.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" To: Jagan Teki , Philipp Tomsich , Simon Glass Cc: Suniel Mahesh , U-Boot-Denx , linux-rockchip@lists.infradead.org, linux-amarula List-Id: linux-rockchip.vger.kernel.org HI Jagan,     Does patch 3~6 also from mainline kernel? Thanks, - Kever On 2020/7/21 上午2:51, Jagan Teki wrote: > rk3288 and rk3288w have a usb host0 ohci controller. > > Although rk3288 ohci doesn't actually work on hardware, but > rk3288w ohci can work well. > > So add usb host0 ohci node in rk3288 dtsi and the quirk in > ohci platform driver will disable ohci on rk3288. > > Signed-off-by: Jagan Teki > --- > arch/arm/dts/rk3288.dtsi | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi > index 18b372db3a..22bb06cec5 100644 > --- a/arch/arm/dts/rk3288.dtsi > +++ b/arch/arm/dts/rk3288.dtsi > @@ -431,7 +431,16 @@ > status = "disabled"; > }; > > - /* NOTE: ohci@ff520000 doesn't actually work on hardware */ > + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */ > + usb_host0_ohci: usb@ff520000 { > + compatible = "generic-ohci"; > + reg = <0x0 0xff520000 0x0 0x100>; > + interrupts = ; > + clocks = <&cru HCLK_USBHOST0>; > + phys = <&usbphy1>; > + phy-names = "usb"; > + status = "disabled"; > + }; > > usb_host1: usb@ff540000 { > compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb", From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kever Yang Date: Tue, 21 Jul 2020 11:17:53 +0800 Subject: [PATCH 03/16] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 In-Reply-To: <20200720185120.671064-4-jagan@amarulasolutions.com> References: <20200720185120.671064-1-jagan@amarulasolutions.com> <20200720185120.671064-4-jagan@amarulasolutions.com> Message-ID: <0b2fbd84-2ee3-5a8b-7a33-d9fab2160e16@rock-chips.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de HI Jagan, ??? Does patch 3~6 also from mainline kernel? Thanks, - Kever On 2020/7/21 ??2:51, Jagan Teki wrote: > rk3288 and rk3288w have a usb host0 ohci controller. > > Although rk3288 ohci doesn't actually work on hardware, but > rk3288w ohci can work well. > > So add usb host0 ohci node in rk3288 dtsi and the quirk in > ohci platform driver will disable ohci on rk3288. > > Signed-off-by: Jagan Teki > --- > arch/arm/dts/rk3288.dtsi | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/dts/rk3288.dtsi b/arch/arm/dts/rk3288.dtsi > index 18b372db3a..22bb06cec5 100644 > --- a/arch/arm/dts/rk3288.dtsi > +++ b/arch/arm/dts/rk3288.dtsi > @@ -431,7 +431,16 @@ > status = "disabled"; > }; > > - /* NOTE: ohci at ff520000 doesn't actually work on hardware */ > + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */ > + usb_host0_ohci: usb at ff520000 { > + compatible = "generic-ohci"; > + reg = <0x0 0xff520000 0x0 0x100>; > + interrupts = ; > + clocks = <&cru HCLK_USBHOST0>; > + phys = <&usbphy1>; > + phy-names = "usb"; > + status = "disabled"; > + }; > > usb_host1: usb at ff540000 { > compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",