All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Sikorski <belegdol@gmail.com>
To: Shyam Prasad N <nspmangalore@gmail.com>,
	Enzo Matsumiya <ematsumiya@suse.de>
Cc: Paulo Alcantara <pc@cjr.nz>,
	ronnie sahlberg <ronniesahlberg@gmail.com>,
	CIFS <linux-cifs@vger.kernel.org>
Subject: Re: kernel-5.18.8 breaks cifs mounts
Date: Mon, 4 Jul 2022 18:30:44 +0200	[thread overview]
Message-ID: <0b4243c5-4838-1f12-7269-dcf99e6db220@gmail.com> (raw)
In-Reply-To: <CANT5p=oSgvPeQLLYC=JHbc6EAoqmW8x9Jysf00KG93-djHthEw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]

Am 04.07.22 um 10:12 schrieb Shyam Prasad N:
> On Fri, Jul 1, 2022 at 2:07 AM Enzo Matsumiya <ematsumiya@suse.de> wrote:
>>
>> On 06/30, Julian Sikorski wrote:
>>>>> Openmediavault 6.0.30 running on top of armbian bullseye. The samba
>>>>> package version is 4.13.13+dfsg-1~deb11u3.
>>
>> [ ... ]
>>
>>> 16d5d9100927 smb3: use netname when available on secondary channels
>>>
>>> initally, and reverting it did not help. Reverting
>>>
>>> ca83f50b43a0 smb3: fix empty netname context on secondary channels
>>>
>>> makes the mounts work again.
>>
>> It's possible that server is not discarding/ignoring SMB2_NETNAME_NEGOTIATE_CONTEXT_ID
>> negotiate context as it should, and rather treating it as an error.
>>
>> I took a quick look in SLE15-SP3 samba 4.15 code and I didn't spot any
>> obvious mishandling there (it seems it's not supported yet). Also I
>> couldn't reproduce the issue with that server.
>>
>> Maybe it's possible it's a vendor modification?
>>
>>
>> Cheers,
>>
>> Enzo
> 
> I tried mounting a samba share, and it seems to work fine.
> 
>  From the network capture attached, I see that the netname is not
> empty, and seems fine.
> Negotiate Context: SMB2_NETNAME_NEGOTIATE_CONTEXT_ID
>      Type: SMB2_NETNAME_NEGOTIATE_CONTEXT_ID (0x0005)
>      DataLength: 30
>      Reserved: 00000000
>      Netname: odroidxu4.local
> 
> Julian,
> Will you be able to capture network traces with the two changes
> reverted? i.e. when it works for you?
> 
Looks like some messages were not CCed to the list, apologies. Please 
find the traces attached.

Best regards,
Julian

[-- Attachment #2: trace_reverted.pcap --]
[-- Type: application/vnd.tcpdump.pcap, Size: 17839 bytes --]

  reply	other threads:[~2022-07-04 16:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-30 16:47 kernel-5.18.8 breaks cifs mounts Julian Sikorski
2022-06-30 17:02 ` ronnie sahlberg
2022-06-30 17:41   ` Julian Sikorski
2022-06-30 17:55     ` Paulo Alcantara
2022-06-30 18:11       ` Julian Sikorski
2022-06-30 18:28         ` Paulo Alcantara
2022-06-30 19:12           ` Julian Sikorski
2022-06-30 20:32             ` Enzo Matsumiya
2022-07-04  8:12               ` Shyam Prasad N
2022-07-04 16:30                 ` Julian Sikorski [this message]
     [not found]               ` <CAH2r5mtVwZggJ9Fi0zsK5hCci4uxee-kOSC3brb56xpb0_xn7w@mail.gmail.com>
     [not found]                 ` <56afe80b-bf6a-2508-063a-7b091cdbbe0f@gmail.com>
     [not found]                   ` <CAH2r5mvoyhZGjf_wgvjgmkCz=+2iDxCSpbyJ79NMtpE1Ecjdnw@mail.gmail.com>
     [not found]                     ` <fccdb4af-697e-b7fc-6421-f16e9b35bb8e@samba.org>
2022-07-04 16:29                       ` Julian Sikorski
2022-07-05  5:28                         ` Shyam Prasad N
2022-07-05 10:55                           ` Julian Sikorski
2022-07-06 11:18                         ` Julian Sikorski
2022-07-12  4:36                           ` Steve French
2022-07-13 21:25                             ` Georg Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0b4243c5-4838-1f12-7269-dcf99e6db220@gmail.com \
    --to=belegdol@gmail.com \
    --cc=ematsumiya@suse.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --cc=pc@cjr.nz \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.