From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/4] target/arm: Improve exception-taken logging
Date: Fri, 20 Jul 2018 09:15:34 -0700 [thread overview]
Message-ID: <0b4983d9-e6e0-c97b-3868-f923bc13def5@linaro.org> (raw)
In-Reply-To: <20180720145647.8810-2-peter.maydell@linaro.org>
On 07/20/2018 07:56 AM, Peter Maydell wrote:
> Improve the exception-taken logging by logging in
> v7m_exception_taken() the exception we're going to take
> and whether it is secure/nonsecure.
>
> This requires us to move logging at many callsites from after the
> call to before it, so that the logging appears in a sensible order.
>
> (This will make tail-chaining produce more useful logs; for the
> current callers of v7m_exception_taken() we know which exception
> we're going to take, so custom log messages at the callsite sufficed;
> for tail-chaining only v7m_exception_taken() knows the exception
> number that we're going to tail-chain to.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/helper.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2018-07-20 16:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 14:56 [Qemu-devel] [PATCH 0/4] target/arm: Implement tailchaining for M profile cores Peter Maydell
2018-07-20 14:56 ` [Qemu-devel] [PATCH 1/4] target/arm: Improve exception-taken logging Peter Maydell
2018-07-20 16:15 ` Richard Henderson [this message]
2018-07-21 19:47 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-20 14:56 ` [Qemu-devel] [PATCH 2/4] target/arm: Initialize exc_secure correctly in do_v7m_exception_exit() Peter Maydell
2018-07-20 16:17 ` Richard Henderson
2018-07-21 19:48 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-07-20 14:56 ` [Qemu-devel] [PATCH 3/4] target/arm: Restore M-profile CONTROL.SPSEL before any tailchaining Peter Maydell
2018-07-20 16:19 ` Richard Henderson
2018-07-20 14:56 ` [Qemu-devel] [PATCH 4/4] target/arm: Implement tailchaining for M profile cores Peter Maydell
2018-07-20 16:22 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4983d9-e6e0-c97b-3868-f923bc13def5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.