Re: [Qemu-devel] [PATCH v2 06/12] boards.h: Ignore migration for SMBus devices on older machines

From: Laurent Vivier <lvivier@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Corey Minyard <minyard@acm.org>,
	dgibson@redhat.com
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Corey Minyard <cminyard@mvista.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 06/12] boards.h: Ignore migration for SMBus devices on older machines
Date: Tue, 27 Nov 2018 19:41:15 +0100	[thread overview]
Message-ID: <0b51df6b-d0e1-37a6-be32-a3f052ea9e4b@redhat.com> (raw)
In-Reply-To: <20181127181448.GC2616@work-vm>

On 27/11/2018 19:14, Dr. David Alan Gilbert wrote:
> * Corey Minyard (minyard@acm.org) wrote:
>> On 11/27/18 10:01 AM, Dr. David Alan Gilbert wrote:
>>> * Corey Minyard (minyard@acm.org) wrote:
>>>> On 11/26/18 11:23 AM, Dr. David Alan Gilbert wrote:
>>>>> * minyard@acm.org (minyard@acm.org) wrote:
>>>>>> From: Corey Minyard <cminyard@mvista.com>
...
>>>> The pm_smbus device is also used by mips fulong.  From what I can tell, that
>>>> machine doesn't have any concept of backwards compatibility, so it seemed
>>>> save to no worry about it there.  If it weren't for that, this bool could go
>>>> into the
>>> Yeh that's fine.
>>>
>>> What about the eeprom's are they used more widely?
>>
>> The only other I2C EEPROM I see is hw/nvram/eeprom_at24c.c.  That device is
>> only
>> configured for PPC.  It has a block device backend, too.  This is a little
>> annoying
>> because smbus_eeprom.c emulates an at24c02.  It would be nice to only have
>> one of these.
> 
> Added in David and Laurent for odd-ppc stuff;  if I'm reading it right
> it's not used by one of the versioned machines.

Yes, it seems unused.

It has been introduced for the mvme31100 machine emulation, by:

commit 5d8424dbd3e8335ea3d57f64eaa603c8fc80706f
Author: Michael Davidsaver <mdavidsaver@gmail.com>
Date:   Sun Nov 19 21:24:17 2017 -0600

    nvram: add AT24Cx i2c eeprom

    Signed-off-by: Michael Davidsaver <mdavidsaver@gmail.com>
    Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

from the series:

[00/12] Add MVME3100 PPC SBC
https://patchwork.ozlabs.org/cover/839400/

[12/12] tests: add mvme3100-test	
[11/12] ppc: add mvme3100 machine
[10/12] timer: add ds1375 RTC	
[09/12] nvram: add AT24Cx i2c eeprom	
[08/12] e500: add mpc8540 i2c controller to ccsr
[07/12] qtest: add e500_i2c_create()
[06/12] i2c: add mpc8540 i2c controller
[05/12] e500: name openpic and pci host bridge
[04/12] e500: additional CCSR registers
[03/12] e500: note possible bug with host bridge	
[02/12] e500: consolidate mpc8540 guts with e500-ccsr
[01/12] e500: add board config options
https://patchwork.ozlabs.org/project/qemu-devel/list/?series=14303

But the patch adding the machine type has never been commited:

[11/12] ppc: add mvme3100 machine
https://patchwork.ozlabs.org/patch/839407/

Thanks,
Laurent