From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758476AbcJYIJx (ORCPT ); Tue, 25 Oct 2016 04:09:53 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52113 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbcJYIJf (ORCPT ); Tue, 25 Oct 2016 04:09:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 69C7961B2A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 1/8] drm/bridge: rgb-to-vga: Support an enable GPIO To: Chen-Yu Tsai , Maxime Ripard , David Airlie , Rob Herring , Mark Rutland References: <20161020034344.14154-1-wens@csie.org> <20161020034344.14154-2-wens@csie.org> Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Archit Taneja Message-ID: <0b5fbe8e-e51b-c874-e1a3-0b88dc65e361@codeaurora.org> Date: Tue, 25 Oct 2016 13:39:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20161020034344.14154-2-wens@csie.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: > Some rgb-to-vga bridges have an enable GPIO, either directly tied to > an enable pin on the bridge IC, or indirectly controlling a power > switch. > > Add support for it. Does the bridge on your platform have an active/passive DAC, or is it a smarter encoder chip that is capable of doing more? If so, it might be good to have a separate DT compatible string to it, like what's done in the patch titled: drm: bridge: vga-dac: Add adi,adv7123 compatible string so that we can switch to a different driver later if needed. Thanks, Archit > > Signed-off-by: Chen-Yu Tsai > --- > .../bindings/display/bridge/dumb-vga-dac.txt | 2 ++ > drivers/gpu/drm/bridge/dumb-vga-dac.c | 28 ++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > index 003bc246a270..d3484822bf77 100644 > --- a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > +++ b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > @@ -16,6 +16,8 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - Video port 0 for RGB input > - Video port 1 for VGA output > > +Optional properties: > +- enable-gpios: GPIO pin to enable or disable the bridge > > Example > ------- > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c > index afec232185a7..b487e5e9b56d 100644 > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > @@ -10,6 +10,7 @@ > * the License, or (at your option) any later version. > */ > > +#include > #include > #include > > @@ -23,6 +24,7 @@ struct dumb_vga { > struct drm_connector connector; > > struct i2c_adapter *ddc; > + struct gpio_desc *enable_gpio; > }; > > static inline struct dumb_vga * > @@ -124,8 +126,26 @@ static int dumb_vga_attach(struct drm_bridge *bridge) > return 0; > } > > +static void dumb_vga_enable(struct drm_bridge *bridge) > +{ > + struct dumb_vga *vga = drm_bridge_to_dumb_vga(bridge); > + > + if (vga->enable_gpio) > + gpiod_set_value_cansleep(vga->enable_gpio, 1); > +} > + > +static void dumb_vga_disable(struct drm_bridge *bridge) > +{ > + struct dumb_vga *vga = drm_bridge_to_dumb_vga(bridge); > + > + if (vga->enable_gpio) > + gpiod_set_value_cansleep(vga->enable_gpio, 0); > +} > + > static const struct drm_bridge_funcs dumb_vga_bridge_funcs = { > .attach = dumb_vga_attach, > + .enable = dumb_vga_enable, > + .disable = dumb_vga_disable, > }; > > static struct i2c_adapter *dumb_vga_retrieve_ddc(struct device *dev) > @@ -169,6 +189,14 @@ static int dumb_vga_probe(struct platform_device *pdev) > return -ENOMEM; > platform_set_drvdata(pdev, vga); > > + vga->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", > + GPIOD_OUT_LOW); > + if (IS_ERR(vga->enable_gpio)) { > + ret = PTR_ERR(vga->enable_gpio); > + dev_err(&pdev->dev, "failed to request GPIO: %d\n", ret); > + return ret; > + } > + > vga->ddc = dumb_vga_retrieve_ddc(&pdev->dev); > if (IS_ERR(vga->ddc)) { > if (PTR_ERR(vga->ddc) == -ENODEV) { > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH v2 1/8] drm/bridge: rgb-to-vga: Support an enable GPIO Date: Tue, 25 Oct 2016 13:39:27 +0530 Message-ID: <0b5fbe8e-e51b-c874-e1a3-0b88dc65e361@codeaurora.org> References: <20161020034344.14154-1-wens@csie.org> <20161020034344.14154-2-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161020034344.14154-2-wens@csie.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chen-Yu Tsai , Maxime Ripard , David Airlie , Rob Herring , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: devicetree@vger.kernel.org SGksCgpPbiAxMC8yMC8yMDE2IDA5OjEzIEFNLCBDaGVuLVl1IFRzYWkgd3JvdGU6Cj4gU29tZSBy Z2ItdG8tdmdhIGJyaWRnZXMgaGF2ZSBhbiBlbmFibGUgR1BJTywgZWl0aGVyIGRpcmVjdGx5IHRp ZWQgdG8KPiBhbiBlbmFibGUgcGluIG9uIHRoZSBicmlkZ2UgSUMsIG9yIGluZGlyZWN0bHkgY29u dHJvbGxpbmcgYSBwb3dlcgo+IHN3aXRjaC4KPgo+IEFkZCBzdXBwb3J0IGZvciBpdC4KCkRvZXMg dGhlIGJyaWRnZSBvbiB5b3VyIHBsYXRmb3JtIGhhdmUgYW4gYWN0aXZlL3Bhc3NpdmUgREFDLCBv ciBpcyBpdCBhCnNtYXJ0ZXIgZW5jb2RlciBjaGlwIHRoYXQgaXMgY2FwYWJsZSBvZiBkb2luZyBt b3JlPyBJZiBzbywgaXQgbWlnaHQgYmUKZ29vZCB0byBoYXZlIGEgc2VwYXJhdGUgRFQgY29tcGF0 aWJsZSBzdHJpbmcgdG8gaXQsIGxpa2Ugd2hhdCdzIGRvbmUKaW4gdGhlIHBhdGNoIHRpdGxlZDoK CmRybTogYnJpZGdlOiB2Z2EtZGFjOiBBZGQgYWRpLGFkdjcxMjMgY29tcGF0aWJsZSBzdHJpbmcK CnNvIHRoYXQgd2UgY2FuIHN3aXRjaCB0byBhIGRpZmZlcmVudCBkcml2ZXIgbGF0ZXIgaWYgbmVl ZGVkLgoKVGhhbmtzLApBcmNoaXQKCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaGVuLVl1IFRzYWkgPHdl bnNAY3NpZS5vcmc+Cj4gLS0tCj4gIC4uLi9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9kdW1iLXZn YS1kYWMudHh0ICAgICAgIHwgIDIgKysKPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kdW1iLXZn YS1kYWMuYyAgICAgICAgICAgICAgfCAyOCArKysrKysrKysrKysrKysrKysrKysrCj4gIDIgZmls ZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS9kdW1iLXZnYS1kYWMudHh0IGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2R1bWItdmdh LWRhYy50eHQKPiBpbmRleCAwMDNiYzI0NmEyNzAuLmQzNDg0ODIyYmY3NyAxMDA2NDQKPiAtLS0g YS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvZHVtYi12 Z2EtZGFjLnR4dAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNw bGF5L2JyaWRnZS9kdW1iLXZnYS1kYWMudHh0Cj4gQEAgLTE2LDYgKzE2LDggQEAgZ3JhcGggYmlu ZGluZ3Mgc3BlY2lmaWVkIGluIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncmFw aC50eHQuCj4gIC0gVmlkZW8gcG9ydCAwIGZvciBSR0IgaW5wdXQKPiAgLSBWaWRlbyBwb3J0IDEg Zm9yIFZHQSBvdXRwdXQKPgo+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICstIGVuYWJsZS1ncGlv czogR1BJTyBwaW4gdG8gZW5hYmxlIG9yIGRpc2FibGUgdGhlIGJyaWRnZQo+Cj4gIEV4YW1wbGUK PiAgLS0tLS0tLQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R1bWItdmdh LWRhYy5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9kdW1iLXZnYS1kYWMuYwo+IGluZGV4IGFm ZWMyMzIxODVhNy4uYjQ4N2U1ZTliNTZkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2UvZHVtYi12Z2EtZGFjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R1bWIt dmdhLWRhYy5jCj4gQEAgLTEwLDYgKzEwLDcgQEAKPiAgICogdGhlIExpY2Vuc2UsIG9yIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCj4gICAqLwo+Cj4gKyNpbmNsdWRlIDxsaW51 eC9ncGlvL2NvbnN1bWVyLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiAgI2luY2x1 ZGUgPGxpbnV4L29mX2dyYXBoLmg+Cj4KPiBAQCAtMjMsNiArMjQsNyBAQCBzdHJ1Y3QgZHVtYl92 Z2Egewo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IJY29ubmVjdG9yOwo+Cj4gIAlzdHJ1Y3QgaTJj X2FkYXB0ZXIJKmRkYzsKPiArCXN0cnVjdCBncGlvX2Rlc2MJKmVuYWJsZV9ncGlvOwo+ICB9Owo+ Cj4gIHN0YXRpYyBpbmxpbmUgc3RydWN0IGR1bWJfdmdhICoKPiBAQCAtMTI0LDggKzEyNiwyNiBA QCBzdGF0aWMgaW50IGR1bWJfdmdhX2F0dGFjaChzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlKQo+ ICAJcmV0dXJuIDA7Cj4gIH0KPgo+ICtzdGF0aWMgdm9pZCBkdW1iX3ZnYV9lbmFibGUoc3RydWN0 IGRybV9icmlkZ2UgKmJyaWRnZSkKPiArewo+ICsJc3RydWN0IGR1bWJfdmdhICp2Z2EgPSBkcm1f YnJpZGdlX3RvX2R1bWJfdmdhKGJyaWRnZSk7Cj4gKwo+ICsJaWYgKHZnYS0+ZW5hYmxlX2dwaW8p Cj4gKwkJZ3Bpb2Rfc2V0X3ZhbHVlX2NhbnNsZWVwKHZnYS0+ZW5hYmxlX2dwaW8sIDEpOwo+ICt9 Cj4gKwo+ICtzdGF0aWMgdm9pZCBkdW1iX3ZnYV9kaXNhYmxlKHN0cnVjdCBkcm1fYnJpZGdlICpi cmlkZ2UpCj4gK3sKPiArCXN0cnVjdCBkdW1iX3ZnYSAqdmdhID0gZHJtX2JyaWRnZV90b19kdW1i X3ZnYShicmlkZ2UpOwo+ICsKPiArCWlmICh2Z2EtPmVuYWJsZV9ncGlvKQo+ICsJCWdwaW9kX3Nl dF92YWx1ZV9jYW5zbGVlcCh2Z2EtPmVuYWJsZV9ncGlvLCAwKTsKPiArfQo+ICsKPiAgc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fYnJpZGdlX2Z1bmNzIGR1bWJfdmdhX2JyaWRnZV9mdW5jcyA9IHsK PiAgCS5hdHRhY2gJCT0gZHVtYl92Z2FfYXR0YWNoLAo+ICsJLmVuYWJsZQkJPSBkdW1iX3ZnYV9l bmFibGUsCj4gKwkuZGlzYWJsZQk9IGR1bWJfdmdhX2Rpc2FibGUsCj4gIH07Cj4KPiAgc3RhdGlj IHN0cnVjdCBpMmNfYWRhcHRlciAqZHVtYl92Z2FfcmV0cmlldmVfZGRjKHN0cnVjdCBkZXZpY2Ug KmRldikKPiBAQCAtMTY5LDYgKzE4OSwxNCBAQCBzdGF0aWMgaW50IGR1bWJfdmdhX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAlwbGF0 Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCB2Z2EpOwo+Cj4gKwl2Z2EtPmVuYWJsZV9ncGlvID0gZGV2 bV9ncGlvZF9nZXRfb3B0aW9uYWwoJnBkZXYtPmRldiwgImVuYWJsZSIsCj4gKwkJCQkJCSAgIEdQ SU9EX09VVF9MT1cpOwo+ICsJaWYgKElTX0VSUih2Z2EtPmVuYWJsZV9ncGlvKSkgewo+ICsJCXJl dCA9IFBUUl9FUlIodmdhLT5lbmFibGVfZ3Bpbyk7Cj4gKwkJZGV2X2VycigmcGRldi0+ZGV2LCAi ZmFpbGVkIHRvIHJlcXVlc3QgR1BJTzogJWRcbiIsIHJldCk7Cj4gKwkJcmV0dXJuIHJldDsKPiAr CX0KPiArCj4gIAl2Z2EtPmRkYyA9IGR1bWJfdmdhX3JldHJpZXZlX2RkYygmcGRldi0+ZGV2KTsK PiAgCWlmIChJU19FUlIodmdhLT5kZGMpKSB7Cj4gIAkJaWYgKFBUUl9FUlIodmdhLT5kZGMpID09 IC1FTk9ERVYpIHsKPgoKLS0gClF1YWxjb21tIElubm92YXRpb24gQ2VudGVyLCBJbmMuIGlzIGEg bWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3Jh dGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: architt@codeaurora.org (Archit Taneja) Date: Tue, 25 Oct 2016 13:39:27 +0530 Subject: [PATCH v2 1/8] drm/bridge: rgb-to-vga: Support an enable GPIO In-Reply-To: <20161020034344.14154-2-wens@csie.org> References: <20161020034344.14154-1-wens@csie.org> <20161020034344.14154-2-wens@csie.org> Message-ID: <0b5fbe8e-e51b-c874-e1a3-0b88dc65e361@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 10/20/2016 09:13 AM, Chen-Yu Tsai wrote: > Some rgb-to-vga bridges have an enable GPIO, either directly tied to > an enable pin on the bridge IC, or indirectly controlling a power > switch. > > Add support for it. Does the bridge on your platform have an active/passive DAC, or is it a smarter encoder chip that is capable of doing more? If so, it might be good to have a separate DT compatible string to it, like what's done in the patch titled: drm: bridge: vga-dac: Add adi,adv7123 compatible string so that we can switch to a different driver later if needed. Thanks, Archit > > Signed-off-by: Chen-Yu Tsai > --- > .../bindings/display/bridge/dumb-vga-dac.txt | 2 ++ > drivers/gpu/drm/bridge/dumb-vga-dac.c | 28 ++++++++++++++++++++++ > 2 files changed, 30 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > index 003bc246a270..d3484822bf77 100644 > --- a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > +++ b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > @@ -16,6 +16,8 @@ graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - Video port 0 for RGB input > - Video port 1 for VGA output > > +Optional properties: > +- enable-gpios: GPIO pin to enable or disable the bridge > > Example > ------- > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c > index afec232185a7..b487e5e9b56d 100644 > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > @@ -10,6 +10,7 @@ > * the License, or (at your option) any later version. > */ > > +#include > #include > #include > > @@ -23,6 +24,7 @@ struct dumb_vga { > struct drm_connector connector; > > struct i2c_adapter *ddc; > + struct gpio_desc *enable_gpio; > }; > > static inline struct dumb_vga * > @@ -124,8 +126,26 @@ static int dumb_vga_attach(struct drm_bridge *bridge) > return 0; > } > > +static void dumb_vga_enable(struct drm_bridge *bridge) > +{ > + struct dumb_vga *vga = drm_bridge_to_dumb_vga(bridge); > + > + if (vga->enable_gpio) > + gpiod_set_value_cansleep(vga->enable_gpio, 1); > +} > + > +static void dumb_vga_disable(struct drm_bridge *bridge) > +{ > + struct dumb_vga *vga = drm_bridge_to_dumb_vga(bridge); > + > + if (vga->enable_gpio) > + gpiod_set_value_cansleep(vga->enable_gpio, 0); > +} > + > static const struct drm_bridge_funcs dumb_vga_bridge_funcs = { > .attach = dumb_vga_attach, > + .enable = dumb_vga_enable, > + .disable = dumb_vga_disable, > }; > > static struct i2c_adapter *dumb_vga_retrieve_ddc(struct device *dev) > @@ -169,6 +189,14 @@ static int dumb_vga_probe(struct platform_device *pdev) > return -ENOMEM; > platform_set_drvdata(pdev, vga); > > + vga->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", > + GPIOD_OUT_LOW); > + if (IS_ERR(vga->enable_gpio)) { > + ret = PTR_ERR(vga->enable_gpio); > + dev_err(&pdev->dev, "failed to request GPIO: %d\n", ret); > + return ret; > + } > + > vga->ddc = dumb_vga_retrieve_ddc(&pdev->dev); > if (IS_ERR(vga->ddc)) { > if (PTR_ERR(vga->ddc) == -ENODEV) { > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project