From: Paolo Abeni <pabeni@redhat.com>
To: Carlos Fernandez <carlos.escuin@gmail.com>,
carlos.fernandez@technica-engineering.de, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: macsec: retrieve the XPN attributes before offloading
Date: Tue, 10 May 2022 09:09:53 +0200 [thread overview]
Message-ID: <0b66ddcc8428231632e7e1050045b2c282dc92d7.camel@redhat.com> (raw)
In-Reply-To: <20220506105540.9868-1-carlos.fernandez@technica-engineering.de>
Hello,
On Fri, 2022-05-06 at 12:55 +0200, Carlos Fernandez wrote:
> When MACsec offloading is used with XPN, before mdo_add_rxsa
> and mdo_add_txsa functions are called, the key salt is not
> copied to the macsec context struct. Offloaded phys will need
> this data when performing offloading.
>
> Fix by copying salt and id to context struct before calling the
> offloading functions.
>
> Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
>
> Signed-off-by: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
I'm sorry for nit-picking, but you must avoid empty lines between the
the 'Fixes' and the 'Signed-off-by' tags (or any other tag).
Additionnaly you should include a summary of the changes WRT the
previous patch version, see e.g. commit cec16052d5a7.
The patch contents looks good, but it's better if you address the
above, thanks!
Paolo
next prev parent reply other threads:[~2022-05-10 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 10:55 [PATCH net v2] net: macsec: retrieve the XPN attributes before offloading Carlos Fernandez
2022-05-10 7:09 ` Paolo Abeni [this message]
2022-05-10 8:01 ` Carlos Fernandez
2022-05-18 8:57 ` [PATCH net v2] Retrieve MACSec-XPN " Carlos Fernandez
2022-05-18 9:01 ` Carlos Fernandez
2022-05-18 16:23 ` Jakub Kicinski
2022-05-19 7:43 ` Carlos Fernandez
2022-05-19 16:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b66ddcc8428231632e7e1050045b2c282dc92d7.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=carlos.escuin@gmail.com \
--cc=carlos.fernandez@technica-engineering.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.