From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53442) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxa8e-0007O6-8B for qemu-devel@nongnu.org; Fri, 21 Oct 2016 09:45:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxa8c-0000Lg-RL for qemu-devel@nongnu.org; Fri, 21 Oct 2016 09:45:36 -0400 References: <1476971169-31604-1-git-send-email-kwolf@redhat.com> <1476971169-31604-4-git-send-email-kwolf@redhat.com> <20161021105932.GB3805@noname.redhat.com> From: Eric Blake Message-ID: <0b68af1c-3549-7032-7406-4a9c45481470@redhat.com> Date: Fri, 21 Oct 2016 08:45:27 -0500 MIME-Version: 1.0 In-Reply-To: <20161021105932.GB3805@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LsoV5G76RnwdGTdC6nERmCgBhf4RkOFIU" Subject: Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LsoV5G76RnwdGTdC6nERmCgBhf4RkOFIU From: Eric Blake To: Kevin Wolf Cc: qemu-block@nongnu.org, pbonzini@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Message-ID: <0b68af1c-3549-7032-7406-4a9c45481470@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/9] block: Remove bdrv_aio_pdiscard() References: <1476971169-31604-1-git-send-email-kwolf@redhat.com> <1476971169-31604-4-git-send-email-kwolf@redhat.com> <20161021105932.GB3805@noname.redhat.com> In-Reply-To: <20161021105932.GB3805@noname.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/21/2016 05:59 AM, Kevin Wolf wrote: > Am 20.10.2016 um 19:32 hat Eric Blake geschrieben: >> On 10/20/2016 08:46 AM, Kevin Wolf wrote: >>> It is unused now. >>> >>> Signed-off-by: Kevin Wolf >>> --- >>> block/io.c | 29 ----------------------------- >>> block/trace-events | 1 - >>> include/block/block.h | 3 --- >>> 3 files changed, 33 deletions(-) >> >> Might be nice to research which commit id removed the last use, and >> mention it in the commit message as an idea for how long we've had dea= d >> code, but that's not a necessity. >=20 > Patch 2 removed the last user. Aha. So maybe "removed in the previous patch" is all the more mention it needs, if at all. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LsoV5G76RnwdGTdC6nERmCgBhf4RkOFIU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYChv3AAoJEKeha0olJ0NqlKEH/2tB9AvtDpDCRK0+O2AjDibz 9tNTV96WsYoDGANFxdWXFexh/2H4+BFwescF5pUvJrV5gbegndV7gYjuMqJLou5l obHATUm69k/AY4C28WnvxrcJ9f4nOQT8q07xZNgdzwclQT5jX8Nmn20XAuhJRHxQ 461SPSP1o6fDnbYbt5FPKMSZGUpn5YE617kS4b3kNwEG5mfuQ836FcQB00L4MJ27 3cBbiBzDviKWZSlRxDt4i/dFz8SbG76cqCBt+FxF/oV/nC3ZBb2kM4RzWVAO8lil ch2u6u1wVT1yjDyfr3FzECxycd/SFQHlHx4ehqoPobKtLCONmeB27SMW58xOo3U= =HVRa -----END PGP SIGNATURE----- --LsoV5G76RnwdGTdC6nERmCgBhf4RkOFIU--