From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Robert Foss <robert.foss@linaro.org>,
todor.too@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH v1] media: camss: vfe: Don't use vfe->base before it's assigned
Date: Wed, 11 Aug 2021 09:48:32 +0200 [thread overview]
Message-ID: <0b694e24-5cc8-4944-d3a2-115306ae7b89@samsung.com> (raw)
In-Reply-To: <20210810103336.114077-1-robert.foss@linaro.org>
On 10.08.2021 12:33, Robert Foss wrote:
> vfe->ops->hw_version(vfe) being called before vfe->base has been assigned
> is incorrect and causes crashes.
>
> Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version needlessly")
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
With this patch applied on top of linux next-20210810 instead of the
NULL pointer dereference I get following error on DragonBoard410c while
loading kernel modules:
[ 18.480608] qcom-venus 1d00000.video-codec: Adding to iommu group 1
[ 18.536167] qcom-camss 1b0ac00.camss: Adding to iommu group 2
[ 18.600373] Internal error: synchronous external abort: 96000010 [#1]
PREEMPT SMP
> ---
> drivers/media/platform/qcom/camss/camss-vfe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 6b2f33fc9be22..1c8d2f0f81207 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -1299,7 +1299,6 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> return -EINVAL;
> }
> vfe->ops->subdev_init(dev, vfe);
> - vfe->ops->hw_version(vfe);
>
> /* Memory */
>
> @@ -1309,6 +1308,8 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe,
> return PTR_ERR(vfe->base);
> }
>
> + vfe->ops->hw_version(vfe);
> +
> /* Interrupt */
>
> r = platform_get_resource_byname(pdev, IORESOURCE_IRQ,
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2021-08-11 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 10:33 [PATCH v1] media: camss: vfe: Don't use vfe->base before it's assigned Robert Foss
[not found] ` <CGME20210811074838eucas1p2a0e8625af27c10209d9bcfc732254ae7@eucas1p2.samsung.com>
2021-08-11 7:48 ` Marek Szyprowski [this message]
2021-08-11 9:41 ` Robert Foss
2021-08-11 13:42 ` Robert Foss
2021-08-12 7:40 ` Marek Szyprowski
2021-08-12 9:22 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b694e24-5cc8-4944-d3a2-115306ae7b89@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=mchehab@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=robert.foss@linaro.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.