From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D8C1C433ED for ; Wed, 28 Apr 2021 18:37:44 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4D6261423 for ; Wed, 28 Apr 2021 18:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4D6261423 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cs.pub.ro Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.119551.226074 (Exim 4.92) (envelope-from ) id 1lbp44-0002h7-9d; Wed, 28 Apr 2021 18:37:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 119551.226074; Wed, 28 Apr 2021 18:37:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lbp44-0002h0-6D; Wed, 28 Apr 2021 18:37:36 +0000 Received: by outflank-mailman (input) for mailman id 119551; Wed, 28 Apr 2021 18:37:35 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lbp43-0002gu-E3 for xen-devel@lists.xenproject.org; Wed, 28 Apr 2021 18:37:35 +0000 Received: from mx.upb.ro (unknown [141.85.13.220]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id a4a473da-f179-436f-a8c9-77c2d90ae833; Wed, 28 Apr 2021 18:37:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mx.upb.ro (Postfix) with ESMTP id DFE4BB560061; Wed, 28 Apr 2021 21:37:33 +0300 (EEST) Received: from mx.upb.ro ([127.0.0.1]) by localhost (mx.upb.ro [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id A_siWEe2lhhp; Wed, 28 Apr 2021 21:37:32 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by mx.upb.ro (Postfix) with ESMTP id E38A2B56006C; Wed, 28 Apr 2021 21:37:31 +0300 (EEST) Received: from mx.upb.ro ([127.0.0.1]) by localhost (mx.upb.ro [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cRuVjwTr9jPD; Wed, 28 Apr 2021 21:37:31 +0300 (EEST) Received: from [192.168.1.35] (unknown [188.25.174.245]) by mx.upb.ro (Postfix) with ESMTPSA id F2E09B560061; Wed, 28 Apr 2021 21:37:30 +0300 (EEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4a473da-f179-436f-a8c9-77c2d90ae833 X-Virus-Scanned: amavisd-new at upb.ro Subject: Re: [PATCH 0/5] Fix redefinition errors for toolstack libs To: Christian Lindig Cc: "xen-devel@lists.xenproject.org" , "Tim (Xen.org)" , Ian Jackson , Wei Liu , David Scott References: From: Costin Lupu Message-ID: <0b82dc88-fe59-3074-471f-2e36ba3b840e@cs.pub.ro> Date: Wed, 28 Apr 2021 21:37:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/28/21 3:34 PM, Christian Lindig wrote: >=20 >=20 >> On 27 Apr 2021, at 13:05, Costin Lupu > > wrote: >> >> For replication I used gcc 10.3 on an Alpine system. In order to >> replicate the >> redefinition error for PAGE_SIZE one should install the 'fortify-heade= rs' >> package which will change the chain of included headers by indirectly >> including >> /usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined. >> >> Costin Lupu (5): >> =C2=A0tools/debugger: Fix PAGE_SIZE redefinition error >> =C2=A0tools/libfsimage: Fix PATH_MAX redefinition error >> =C2=A0tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error >> =C2=A0tools/libs/gnttab: Fix PAGE_SIZE redefinition error >> =C2=A0tools/ocaml: Fix redefinition errors >> >> tools/debugger/kdd/kdd-xen.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 4 +++= + >> tools/debugger/kdd/kdd.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0| 4 ++++ >> tools/libfsimage/ext2fs/fsys_ext2fs.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0| 2 ++ >> tools/libfsimage/reiserfs/fsys_reiserfs.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= | 2 ++ >> tools/libs/foreignmemory/private.h =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 6 ++++-- >> tools/libs/gnttab/linux.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0| 6 ++++++ >> tools/ocaml/libs/xc/xenctrl_stubs.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 8 ++++++++ >> tools/ocaml/libs/xentoollog/xentoollog_stubs.c | 4 ++++ >> tools/ocaml/libs/xl/xenlight_stubs.c =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0| 4 ++++ >> 9 files changed, 38 insertions(+), 2 deletions(-) >> >> =E2=80=94 >> 2.20.1 >> >=20 > For the OCaml bindings, this avoids redefinitions as you say. Looks goo= d > to me. >=20 > Acked-by: Christian Lindig > >=20 Thanks, Christian, I'll add your ack on the Ocaml patch for the next version of the series. Cheers, Costin