From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Saurav Sachidanand <sauravsachidanand@gmail.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Hajnoczi <stefanha@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c
Date: Tue, 4 Apr 2017 07:15:15 -0300 [thread overview]
Message-ID: <0ba0e60d-aa7f-eb38-a303-ea06f07f61d7@amsat.org> (raw)
In-Reply-To: <CAFEAcA9__yPLkfyjqp62F7T0gYMFdKoNZH=hJN9RN9x6+guRDA@mail.gmail.com>
On 03/28/2017 10:47 AM, Peter Maydell wrote:
> On 28 March 2017 at 14:44, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> Hi Saurav,
>>
>> you should read the QEMU Coding Style and replace your tabs by 4 spaces.
>
> Er, in review comments on v3 we said not to do that...
oops I missed Stefan comment in v2, sorry!
>
> thanks
> -- PMM
>
next prev parent reply other threads:[~2017-04-04 10:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:38 [Qemu-devel] [Qemu-trivial] [PATCH v5] util: Use g_malloc/g_free in envlist.c Saurav Sachidanand
2017-03-23 8:34 ` Stefan Hajnoczi
2017-03-28 13:26 ` no-reply
2017-03-28 13:44 ` Philippe Mathieu-Daudé
2017-03-28 13:47 ` Peter Maydell
2017-04-04 10:15 ` Philippe Mathieu-Daudé [this message]
2017-04-04 10:19 ` Philippe Mathieu-Daudé
2017-04-23 9:01 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ba0e60d-aa7f-eb38-a303-ea06f07f61d7@amsat.org \
--to=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sauravsachidanand@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.