From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09A23C4361A for ; Mon, 10 May 2021 06:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D08F761456 for ; Mon, 10 May 2021 06:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbhEJGSz (ORCPT ); Mon, 10 May 2021 02:18:55 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2669 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230140AbhEJGSy (ORCPT ); Mon, 10 May 2021 02:18:54 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FdrPn6m1jz1BKlN; Mon, 10 May 2021 14:15:09 +0800 (CST) Received: from [127.0.0.1] (10.174.177.72) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 14:17:45 +0800 Subject: Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Anton Ivanov , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210510031606.3112-1-thunder.leizhen@huawei.com> <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> From: "Leizhen (ThunderTown)" Message-ID: <0bb32dc4-b47e-25e8-70a6-fe9bf2c5078f@huawei.com> Date: Mon, 10 May 2021 14:17:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021/5/10 14:01, Anton Ivanov wrote: > On 10/05/2021 04:16, Zhen Lei wrote: >> v1 --> v2: >> According to Anton Ivanov's review comments, detele the unnecessary local >> variable initialization "ret = 0". >> >> >> Zhen Lei (1): >>    drm/msm/dpu: Fix error return code in dpu_mdss_init() >> >>   drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- >>   1 file changed, 5 insertions(+), 3 deletions(-) >> > I do not recall reviewing this. Oh, Sorry, the two e-mails next to each other. I lost sight of them. > > I think you got the wrong Anton Ivanov - I maintain UML so the previous revision hit someone's else inbox. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279B1C43460 for ; Mon, 10 May 2021 06:17:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68403613E1 for ; Mon, 10 May 2021 06:17:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68403613E1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE4DB6E405; Mon, 10 May 2021 06:17:52 +0000 (UTC) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by gabe.freedesktop.org (Postfix) with ESMTPS id F23C789F8E; Mon, 10 May 2021 06:17:50 +0000 (UTC) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FdrPn6m1jz1BKlN; Mon, 10 May 2021 14:15:09 +0800 (CST) Received: from [127.0.0.1] (10.174.177.72) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 14:17:45 +0800 Subject: Re: [PATCH v2 0/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Anton Ivanov , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno , linux-kernel References: <20210510031606.3112-1-thunder.leizhen@huawei.com> <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> From: "Leizhen (ThunderTown)" Message-ID: <0bb32dc4-b47e-25e8-70a6-fe9bf2c5078f@huawei.com> Date: Mon, 10 May 2021 14:17:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <9109a395-099b-ed14-4433-d4bf6dbf5cef@cambridgegreys.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.72] X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021/5/10 14:01, Anton Ivanov wrote: > On 10/05/2021 04:16, Zhen Lei wrote: >> v1 --> v2: >> According to Anton Ivanov's review comments, detele the unnecessary local >> variable initialization "ret = 0". >> >> >> Zhen Lei (1): >>    drm/msm/dpu: Fix error return code in dpu_mdss_init() >> >>   drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 8 +++++--- >>   1 file changed, 5 insertions(+), 3 deletions(-) >> > I do not recall reviewing this. Oh, Sorry, the two e-mails next to each other. I lost sight of them. > > I think you got the wrong Anton Ivanov - I maintain UML so the previous revision hit someone's else inbox. >