From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A699C433EF for ; Mon, 14 Mar 2022 22:17:44 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.290477.492634 (Exim 4.92) (envelope-from ) id 1nTt0L-0007qb-Hf; Mon, 14 Mar 2022 22:17:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 290477.492634; Mon, 14 Mar 2022 22:17:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nTt0L-0007qU-Eh; Mon, 14 Mar 2022 22:17:29 +0000 Received: by outflank-mailman (input) for mailman id 290477; Mon, 14 Mar 2022 22:17:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nTt0J-0007qO-M6 for xen-devel@lists.xenproject.org; Mon, 14 Mar 2022 22:17:27 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nTt0I-0006FC-TE; Mon, 14 Mar 2022 22:17:26 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nTt0I-0000N1-NB; Mon, 14 Mar 2022 22:17:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=/JMkfVbjvJoUrBVgIkbk7OJ/HowPnJtGt7OZ1kUa3bM=; b=leX+sgX4MgC3Qx+Js6CyHsJzg5 6gRocbAI2nxjEuZxiTq+GEN95FYnRNmbsPgelh7yAKSboto9mWMAiBvkMlKTWgGPEfADYvkq/ybnM FCPFH30/1s7u69U1WyNYsfxaixtAAvI95+zYUKuAKuLIMVlxuVgXYY830Ez5w1BUYSWo=; Message-ID: <0bba1cf7-dd08-c908-251d-e712eb819a8a@xen.org> Date: Mon, 14 Mar 2022 22:17:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 To: Marco Solieri , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Marco Solieri , Andrea Bastoni , Luca Miccio References: <20220304174701.1453977-1-marco.solieri@minervasys.tech> <20220304174701.1453977-36-marco.solieri@minervasys.tech> From: Julien Grall Subject: Re: [PATCH 35/36] doc, device-tree: introduce 'colors' property In-Reply-To: <20220304174701.1453977-36-marco.solieri@minervasys.tech> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 04/03/2022 17:47, Marco Solieri wrote: > From: Luca Miccio > > Dom0less uses device tree for DomUs when booting them without using > Dom0. Add a new device tree property 'colors' that specifies the > coloring configuration for DomUs when using Dom0less. > > Signed-off-by: Luca Miccio > Signed-off-by: Marco Solieri The documentation is small enough that I would prefer if this is folded in the patch parsing the property. > --- > docs/misc/arm/device-tree/booting.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt > index a94125394e..44971bfe60 100644 > --- a/docs/misc/arm/device-tree/booting.txt > +++ b/docs/misc/arm/device-tree/booting.txt > @@ -162,6 +162,9 @@ with the following properties: > > An integer specifying the number of vcpus to allocate to the guest. > > +- colors > + A 64 bit bitmask specifying the color configuration for the guest. Why are we limiting dom0less domUs to 64 colors when Xen can support up to 128 colors (potentially more in the future)? To avoid tie the bindings too much to Xen, I would instead explicitly list the colors. Something like: colors = < 10 20 30 > This would also help users that manually write the DT to confirm they put the correct numbers. Cheers, -- Julien Grall