From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: George Dunlap <george.dunlap@citrix.com>, xen-devel@lists.xen.org
Cc: george.dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
kevin.tian@intel.com, jun.nakajima@intel.com, jbeulich@suse.com
Subject: Re: [PATCH V5] x86/altp2m: Fix crash with INVALID_ALTP2M EPTP index
Date: Mon, 23 Jul 2018 14:34:38 +0300 [thread overview]
Message-ID: <0bbd3381-a0b4-d21e-da32-30b1b7b04622@bitdefender.com> (raw)
In-Reply-To: <b2d62b43-f38b-a918-7d83-118fd2e58156@citrix.com>
On 07/23/2018 01:29 PM, George Dunlap wrote:
> It's possible my analysis is wrong there (I'm not intimately familiar
> with the code), but I think my patch is better anyway for a couple of
> reasons:
>
> * The logic to keep EPTP_INDEX in sync is explicit, and all in the same
> file.
>
> * It doesn't do unnecessary updates to other bits of state
>
> * If we ever have reason to call vmx_vcpu_update_vmfunc_ve() directly,
> we won't re-introduce this bug. (Or to put it a different way: We don't
> have to remember that we can't call it directly.)
Very good reasons, and I completely agree. Thanks again for your help!
Thanks,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-07-23 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 14:35 [PATCH V5] x86/altp2m: Fix crash with INVALID_ALTP2M EPTP index Razvan Cojocaru
2018-06-28 14:38 ` Jan Beulich
2018-07-02 5:48 ` Tian, Kevin
2018-07-16 8:30 ` Razvan Cojocaru
2018-07-16 8:51 ` Jan Beulich
2018-07-20 15:07 ` George Dunlap
2018-07-20 16:29 ` Razvan Cojocaru
2018-07-20 17:18 ` George Dunlap
2018-07-20 18:02 ` Razvan Cojocaru
2018-07-23 10:29 ` George Dunlap
2018-07-23 11:34 ` Razvan Cojocaru [this message]
2018-08-01 9:02 ` Razvan Cojocaru
2018-08-02 6:32 ` Tian, Kevin
2018-08-02 6:35 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bbd3381-a0b4-d21e-da32-30b1b7b04622@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.