All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Greg Gallagher <greg@embeddedgreg.com>, xenomai@xenomai.org
Subject: Re: [PATCH v2 1/2] kernel: cobalt: Remove header file for newer kernels
Date: Fri, 5 Feb 2021 15:45:03 +0100	[thread overview]
Message-ID: <0bbdd664-2065-1680-313c-fcb7dbd6388e@siemens.com> (raw)
In-Reply-To: <15001d4b-48ce-7192-d5e8-0e4dab9a55e0@siemens.com>

On 03.02.21 10:50, Jan Kiszka via Xenomai wrote:
> On 03.02.21 08:01, Greg Gallagher via Xenomai wrote:
>> 5.4 kernels do not have compiler.h, only include this header file for kernels older then 5.4
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>>  kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h b/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
>> index 7444cc823..17be10339 100644
>> --- a/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
>> +++ b/kernel/cobalt/arch/arm64/include/asm/xenomai/machine.h
>> @@ -29,7 +29,11 @@
>>  #define XNARCH_HOST_TICK_IRQ __ipipe_hrtimer_irq
>>  
>>  #include <asm/barrier.h>
>> +
>> +#if LINUX_VERSION_CODE < KERNEL_VERSION(5,4,0)
>>  #include <asm/compiler.h>
>> +#endif
>> +
>>  #include <asm/cmpxchg.h>
>>  #include <asm/switch_to.h>
>>  #include <asm/system_misc.h>
>>
> 
> There is still arch/arm64/include/asm/compiler.h in today's master.
> 
> What error exactly are you fixing? That we should rather including
> linux/compiler.h? Or is that header obsolete for us now, for all kernels?
> 

OK, that file vanished in 4.20 and resurrected in 5.7. Given that we do
not head for ipipe over > 5.4, I will just merge this (ported to next).

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux


  reply	other threads:[~2021-02-05 14:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03  7:01 [PATCH v2 1/2] kernel: cobalt: Remove header file for newer kernels Greg Gallagher
2021-02-03  7:01 ` [PATCH v2 2/2] kernel: cobalt: Fix up elf_hwcap Greg Gallagher
2021-02-03  9:52   ` Jan Kiszka
2021-02-03  9:50 ` [PATCH v2 1/2] kernel: cobalt: Remove header file for newer kernels Jan Kiszka
2021-02-05 14:45   ` Jan Kiszka [this message]
2021-02-05 14:47     ` Greg Gallagher
2021-02-05 16:32       ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bbdd664-2065-1680-313c-fcb7dbd6388e@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=greg@embeddedgreg.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.