From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure Date: Fri, 1 Jun 2018 07:04:40 -0700 Message-ID: <0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com> References: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-io0-f194.google.com ([209.85.223.194]:34615 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751692AbeFAOE4 (ORCPT ); Fri, 1 Jun 2018 10:04:56 -0400 In-Reply-To: <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/30/2018 09:42 PM, Prashant Bhole wrote: > Test failures are not identified because exit code of RX/TX threads > is not checked. Also threads are not returning correct exit code. > > - Return exit code from threads depending on test execution status > - In main thread, check the exit code of RX/TX threads > - Skip error checking for corked tests as they are expected to timeout > > Fixes: 16962b2404ac ("bpf: sockmap, add selftests") > Signed-off-by: Prashant Bhole > --- Acked-by: John Fastabend From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.fastabend at gmail.com (John Fastabend) Date: Fri, 1 Jun 2018 07:04:40 -0700 Subject: [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure In-Reply-To: <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> References: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> Message-ID: <0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com> On 05/30/2018 09:42 PM, Prashant Bhole wrote: > Test failures are not identified because exit code of RX/TX threads > is not checked. Also threads are not returning correct exit code. > > - Return exit code from threads depending on test execution status > - In main thread, check the exit code of RX/TX threads > - Skip error checking for corked tests as they are expected to timeout > > Fixes: 16962b2404ac ("bpf: sockmap, add selftests") > Signed-off-by: Prashant Bhole > --- Acked-by: John Fastabend -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.fastabend@gmail.com (John Fastabend) Date: Fri, 1 Jun 2018 07:04:40 -0700 Subject: [PATCH bpf-next v4 1/5] selftests/bpf: test_sockmap, check test failure In-Reply-To: <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> References: <20180531044240.796-1-bhole_prashant_q7@lab.ntt.co.jp> <20180531044240.796-2-bhole_prashant_q7@lab.ntt.co.jp> Message-ID: <0bc10468-cee4-978d-9f7b-10463a8506ba@gmail.com> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180601140440.4rYSF5SqC9yYn-pgjKloxzDvjmFGd_v7X4jOL6dVZlQ@z> On 05/30/2018 09:42 PM, Prashant Bhole wrote: > Test failures are not identified because exit code of RX/TX threads > is not checked. Also threads are not returning correct exit code. > > - Return exit code from threads depending on test execution status > - In main thread, check the exit code of RX/TX threads > - Skip error checking for corked tests as they are expected to timeout > > Fixes: 16962b2404ac ("bpf: sockmap, add selftests") > Signed-off-by: Prashant Bhole > --- Acked-by: John Fastabend -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html