From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D71FC433B4 for ; Thu, 20 May 2021 23:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7EA2613BD for ; Thu, 20 May 2021 23:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234008AbhETX0l (ORCPT ); Thu, 20 May 2021 19:26:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:31362 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbhETX0h (ORCPT ); Thu, 20 May 2021 19:26:37 -0400 IronPort-SDR: 3RneZUIdDGPwtyOlirvVkVI8C6gDd8hfR1V0vAk+Tmi8bl+ja7z1auSRzvyiX/NxevVs+3nMp7 sbDAtqfOZvog== X-IronPort-AV: E=McAfee;i="6200,9189,9990"; a="201068151" X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="201068151" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 16:25:15 -0700 IronPort-SDR: J0gOtlZQ8GZdPG3UzlJ6lHZEb4Yr2tMFcw7ka/cKgseryEAxeiLaLoNP/pirWnN/07FfVamb3/ oEs0rl4Dd86g== X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="475437911" Received: from akleen-mobl1.amr.corp.intel.com (HELO [10.212.197.177]) ([10.212.197.177]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2021 16:25:15 -0700 Subject: Re: [RFC v2 27/32] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK To: "Kuppuswamy, Sathyanarayanan" , Dave Hansen , Sean Christopherson Cc: Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , linux-kernel@vger.kernel.org References: <87b31425b79df3cc44d2bdc6a79d6aa36c42d116.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <3ae38a0b-0676-1543-7015-39a589b2807a@intel.com> <0df80c0f-e0da-e86e-0ab8-abc58f0da559@linux.intel.com> <283b3d47-f1f6-3c53-0909-ba0540993203@intel.com> <6d508f80-4a76-64c2-9772-da23bb467e0b@linux.intel.com> From: Andi Kleen Message-ID: <0bcb46ed-4bdf-9a82-3bdc-2c4d5ffcb627@linux.intel.com> Date: Thu, 20 May 2021 16:25:14 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <6d508f80-4a76-64c2-9772-da23bb467e0b@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/2021 2:28 PM, Kuppuswamy, Sathyanarayanan wrote: > > > On 5/20/21 2:23 PM, Dave Hansen wrote: >> Sathya has even mis-typed "tdx" instead of "tdg" this in his own >> changelogs up to this point.  That massively weakens the argument that >> "tdg" is a good idea. > > It is not a typo. But when we did the initial rename from "tdx_" -> > "tdg_", > somehow I missed the change log change. That's why I am bit reluctant > to go for another rename (since we have scan change log, comments and > code) > in all the patches. Yes I agree. If there's another rename it should be after a full review by all the maintainers. If there is still consensus that a rename is needed then it can be done then. And we'll just hope that Sean's brain will get used to tdg_ by then. -Andi