From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 3/3] iotests: Increase pause_wait() timeout
Date: Fri, 20 Mar 2020 11:21:21 +0100 [thread overview]
Message-ID: <0bce89e1-7bce-68bf-7bf0-194a273eebb4@redhat.com> (raw)
In-Reply-To: <20200313083617.8326-4-kwolf@redhat.com>
On 3/13/20 9:36 AM, Kevin Wolf wrote:
> Waiting for only 1 second proved to be too short on a loaded system,
> resulting in false positives when testing pull requests. Increase the
> timeout a bit to make this less likely.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/iotests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index b859c303a2..7bc4934cd2 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -925,7 +925,7 @@ class QMPTestCase(unittest.TestCase):
> self.assert_qmp(event, 'data/type', 'mirror')
>
> def pause_wait(self, job_id='job0'):
> - with Timeout(1, "Timeout waiting for job to pause"):
> + with Timeout(3, "Timeout waiting for job to pause"):
> while True:
> result = self.vm.qmp('query-block-jobs')
> found = False
>
I wonder if this might be more accurate:
load_timeout = math.ceil(os.getloadavg()[0])
with Timeout(1 + load_timeout, "Timeout waiting for job to pause"):
...
Anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-03-20 10:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 8:36 [PATCH 0/3] iotests: Fix intermittent 030 hang Kevin Wolf
2020-03-13 8:36 ` [PATCH 1/3] iotests.py: Enable faulthandler Kevin Wolf
2020-03-16 19:56 ` John Snow
2020-03-13 8:36 ` [PATCH 2/3] python/qemu: Kill QEMU process if 'quit' doesn't work Kevin Wolf
2020-03-16 19:57 ` John Snow
2020-03-20 10:15 ` Philippe Mathieu-Daudé
2020-03-13 8:36 ` [PATCH 3/3] iotests: Increase pause_wait() timeout Kevin Wolf
2020-03-16 19:58 ` John Snow
2020-03-20 10:21 ` Philippe Mathieu-Daudé [this message]
2020-03-23 18:30 ` John Snow
2020-03-20 10:12 ` [PATCH 0/3] iotests: Fix intermittent 030 hang Philippe Mathieu-Daudé
2020-03-22 11:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bce89e1-7bce-68bf-7bf0-194a273eebb4@redhat.com \
--to=philmd@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.