All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@mellanox.com, alexpe@mellanox.com,
	mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 03/17] ipv6: Extend notifier info for multipath routes
Date: Sun, 16 Jun 2019 19:22:44 -0600	[thread overview]
Message-ID: <0bd8a588-0c6a-de20-c2d4-39e46e433a7e@gmail.com> (raw)
In-Reply-To: <20190615140751.17661-4-idosch@idosch.org>

On 6/15/19 8:07 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@mellanox.com>
> 
> Extend the IPv6 FIB notifier info with number of sibling routes being
> notified.
> 
> This will later allow listeners to process one notification for a
> multipath routes instead of N, where N is the number of nexthops.
> 
> Signed-off-by: Ido Schimmel <idosch@mellanox.com>
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> ---
>  include/net/ip6_fib.h |  7 +++++++
>  net/ipv6/ip6_fib.c    | 17 +++++++++++++++++
>  2 files changed, 24 insertions(+)
> 

The need for a second notifier stems from the append case? versus using
call_fib6_entry_notifiers and letting the nsiblings fallout from
rt->fib6_nsiblings? The append case is a weird thing for userspace to
maintain order, but it seems like the offload case should not care.

Also, .multipath_rt seems redundant with .nsiblings > 1

  reply	other threads:[~2019-06-17  1:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-15 14:07 [PATCH net-next 00/17] mlxsw: Improve IPv6 route insertion rate Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 01/17] netlink: Document all fields of 'struct nl_info' Ido Schimmel
2019-06-17  1:16   ` David Ahern
2019-06-15 14:07 ` [PATCH net-next 02/17] netlink: Add field to skip in-kernel notifications Ido Schimmel
2019-06-17  1:17   ` David Ahern
2019-06-17  6:37     ` Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 03/17] ipv6: Extend notifier info for multipath routes Ido Schimmel
2019-06-17  1:22   ` David Ahern [this message]
2019-06-17  6:46     ` Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 04/17] mlxsw: spectrum_router: Ignore IPv6 multipath notifications Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 05/17] netdevsim: " Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 06/17] ipv6: Add IPv6 multipath notifications for add / replace Ido Schimmel
2019-06-17 13:01   ` David Ahern
2019-06-15 14:07 ` [PATCH net-next 07/17] ipv6: Add IPv6 multipath notification for route delete Ido Schimmel
2019-06-17 13:03   ` David Ahern
2019-06-15 14:07 ` [PATCH net-next 08/17] netdevsim: Adjust accounting for IPv6 multipath notifications Ido Schimmel
2019-06-17  1:27   ` David Ahern
2019-06-17  6:49     ` Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 09/17] mlxsw: spectrum_router: Remove processing of IPv6 append notifications Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 10/17] mlxsw: spectrum_router: Prepare function to return errors Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 11/17] mlxsw: spectrum_router: Pass multiple routes to work item Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 12/17] mlxsw: spectrum_router: Adjust IPv6 replace logic to new notifications Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 13/17] mlxsw: spectrum_router: Pass array of routes to route handling functions Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 14/17] mlxsw: spectrum_router: Add / delete multiple IPv6 nexthops Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 15/17] mlxsw: spectrum_router: Create IPv6 multipath routes in one go Ido Schimmel
2019-06-15 14:07 ` [PATCH net-next 16/17] ipv6: Stop sending in-kernel notifications for each nexthop Ido Schimmel
2019-06-17 13:06   ` David Ahern
2019-06-15 14:07 ` [PATCH net-next 17/17] selftests: mlxsw: Add a test for FIB offload indication Ido Schimmel
2019-06-16 21:04 ` [PATCH net-next 00/17] mlxsw: Improve IPv6 route insertion rate David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bd8a588-0c6a-de20-c2d4-39e46e433a7e@gmail.com \
    --to=dsahern@gmail.com \
    --cc=alexpe@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=idosch@idosch.org \
    --cc=idosch@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.