From mboxrd@z Thu Jan  1 00:00:00 1970
From: cgxu519@gmx.com (cgxu519)
Date: Wed, 12 Sep 2018 22:05:26 +0800
Subject: [PATCH 4/7] staging: erofs: return -EINVAL when specifying fault
 rate to 0
In-Reply-To: <20180912091631.xgxx5zj457z7srlo@mwanda>
References: <20180912051034.3463-1-cgxu519@gmx.com>
 <20180912051034.3463-5-cgxu519@gmx.com>
 <20180912091631.xgxx5zj457z7srlo@mwanda>
Message-ID: <0bee6199-25b4-a4bc-0655-ceac650e482a@gmx.com>

On 09/12/2018 05:16 PM, Dan Carpenter wrote:
> On Wed, Sep 12, 2018@01:10:31PM +0800, Chengguang Xu wrote:
>> Set fault rate to 0 is useless and confusable, so add check to
>> avoid it.
>>
> I would have assumed setting rate to zero just disabled it.

I think currently it is useless because we have not implemented
option parsing in remount yet, maybe it's better adding another
option 'no_fault_injection' to explicitly disable it.

Thanks,
Chengguang